Page MenuHomeWildfire Games

Mister (Ricardo C)
User

Projects

User Details

User Since
Jul 24 2022, 12:36 AM (9 w, 3 d)

Recent Activity

Aug 7 2022

Mister updated the diff for D4740: [WIP] - Allow to limit the structures a builder can construct..
Aug 7 2022, 10:49 PM
Mister updated the diff for D4740: [WIP] - Allow to limit the structures a builder can construct..

Change to use cmpFoundation to get the currentTemplateName, with this, there is no need to use cmpTemplateManager.

Aug 7 2022, 10:28 PM
Mister added a comment to D4740: [WIP] - Allow to limit the structures a builder can construct..

A bit more explanation seems in place.
You use now the template of the foundation (foundation|<sometemplatename>). However, Foundation.js has a property called finalTemplateName, which is the truth about what the foundation will become when finished. E.g. foundation|<sometemplatename> may become foundation|<someothertemplatename> when finished.
As such, when cmpFoundation is present, it ought to be used. Else one can use the current template name (no need for the includes then).

Let me know whether this sounds about right.

Aug 7 2022, 9:26 PM

Aug 1 2022

Mister added a comment to D4740: [WIP] - Allow to limit the structures a builder can construct..

I'll write you some tests when I have some more time on my hands. Feel free to do it yourself though.

Aug 1 2022, 5:06 PM

Jul 31 2022

Mister added a comment to D4740: [WIP] - Allow to limit the structures a builder can construct..

This is how we say a patch is WIP. :) (By prefixing the title.)
Regarding the "cannot repair structures not known", it means that once captured a barracks of the enemy, we cannot repair it. Be aware of that. :) (One can check around that, using the hint provided inline.)

Jul 31 2022, 5:49 PM
Mister added a comment to D4740: [WIP] - Allow to limit the structures a builder can construct..

I'll write you some tests when I have some more time on my hands. Feel free to do it yourself though.

Jul 31 2022, 5:47 PM

Jul 25 2022

Mister updated the diff for D4740: [WIP] - Allow to limit the structures a builder can construct..

Fixed what suggested on the comments.

Jul 25 2022, 12:22 AM

Jul 24 2022

Mister updated the diff for D4740: [WIP] - Allow to limit the structures a builder can construct..

Modified the subString condition to be more specific about the regex.

Jul 24 2022, 11:34 PM
Mister updated the test plan for D4740: [WIP] - Allow to limit the structures a builder can construct..
Jul 24 2022, 11:05 PM
Mister updated the diff for D4740: [WIP] - Allow to limit the structures a builder can construct..

I have made some changes to removing the 'warns' and this is correctly comparing the buildList with the entityName. I don't like how this looks yet because of the subString im doing, will need to fix that.

Jul 24 2022, 10:14 PM
Mister added a comment to D4740: [WIP] - Allow to limit the structures a builder can construct..

Thanks for your comments on this diff.
I'll continue working on it and will add that test plan as soon as i can reproduce it.

Jul 24 2022, 7:58 PM
Mister requested review of D4740: [WIP] - Allow to limit the structures a builder can construct..
Jul 24 2022, 3:18 AM