Page MenuHomeWildfire Games

Neinea (Thibault)
User

Projects

User Details

User Since
Oct 7 2022, 11:54 PM (16 w, 3 d)

Recent Activity

Oct 26 2022

Neinea added a comment to D4802: Allow Music tracks to be ordered. .
In D4802#204817, @Stan wrote:
In D4802#204816, @lyv wrote:

Is there any advantage of having an index attribute rather than relying on the order of definition? I guess it would allow having similarly named tracks grouped while not having them played like that, but is that worth the tradeoff? An attribute also makes it abundantly clear to someone not familiar with this code.

All indexes seem to follow the array index anyway, except one which I presume is a test case.

Well I suppose the only advantage is reducing diff size in case of reorder if the JSON specification says arrays are always parsed in order.

Not sure to understand everything. I thought the scope of this change was to add shuffle only to peace music type. Do we want to shuffle every music? If yes, even when music are shuffled, should Honor Bound music be played at first?

The scope of the change sorry if wasn't clear was to allow to sort (or not) all types of music. I think Honorbound should always be first yeah.

Oct 26 2022, 9:40 AM

Oct 23 2022

Neinea added a comment to D4802: Allow Music tracks to be ordered. .
In D4802#204731, @Stan wrote:

I think we should be a bit smarter than this. What your patch does is break the randomness because tracks are only shuffled once.

We should instead keep the music object from the json intact until we get into startPlayList(). See inline.

That also requires adding more info to default tracks.

sortFunction sadly cannot be a class member, because players might change the settings.

Does that make sense?

Oct 23 2022, 5:15 PM

Oct 22 2022

Neinea added a comment to D4802: Allow Music tracks to be ordered. .

Done !

Oct 22 2022, 7:29 PM
Neinea updated the diff for D4802: Allow Music tracks to be ordered. .
Oct 22 2022, 7:29 PM

Oct 15 2022

Neinea added inline comments to D4802: Allow Music tracks to be ordered. .
Oct 15 2022, 11:33 PM
Neinea updated the diff for D4802: Allow Music tracks to be ordered. .
Oct 15 2022, 11:28 PM
Lionkanzen awarded D4802: Allow Music tracks to be ordered. a Love token.
Oct 15 2022, 4:39 AM
asterix awarded D4802: Allow Music tracks to be ordered. a Love token.
Oct 15 2022, 12:04 AM

Oct 14 2022

Neinea requested review of D4802: Allow Music tracks to be ordered. .
Oct 14 2022, 11:42 PM