• remove spelling correction from diff due to string freeze

• enemey -> enemy

• do not show filename in file opening dialog

• fixed syntax errors in a switch loop

• implemented a few suggestions by elexis and vladislavbelov
• increased size of dialog to 750x500 px
• decreased padding at the bottom between file name display and buttons

• remove diff lines that result from local changes to files rather than spelling errors

follow suggestions of Stan:

• excluded files from JQuery, a third-party library
• removed dubious whitespace in './source/network/NetMessage.h'
• comments begins with uppercase in './binaries/data/mods/public/simulation/helpers/Walls.js' and './source/gui/CInput.h'
• corrected grammar mistake in './build/premake/premake4/src/actions/make/_make.lua'
• improved wording in './source/gui/CDropDown.cpp'
• turn boolean name Checked into lowercase in './source/simulation2/helpers/HierarchicalPathfinder.cpp' , in accordance with './source/gui/CCheckBox.cpp'
• reverted changes to './source/lib/sysdep/os/linux/dir_watch_inotify.cpp'

In D604#24973, @elexis wrote:

While at it, might also want to fix the other "patroling" occurance in unit_actions.js that wasn't fixed by that commit

In D604#24907, @Stan wrote:

You are missing

ps\trunk\binaries\data\mods\public\art\actors\props\units\shields\hele_round_thermistocles.xml

Found by running the following in cmd (grep equivalent on windows):

dir /a /s /b | findstr /R /C:"thermistocles"

• as suggested by Itms: Penteconter -> Pentekonter

• remove diff lines that result from local changes to files rather than spelling errors

• loop on -> loop over
• may-be -> maybe

• smallish -> small

• smallish correction

• fixed errors found by Itms

Patch introduces no new problems, but fixes a few old ones.

Also revert the aura effect for Cyrus the Great.

Revert the quote from Leonidas and I'm fine with the patch.

• included changes to file 'polar_sea_triggers.js', which were missing previously

Replace "plenty of game and fish" with "plenty of game", since fish is included in game (https://en.wikipedia.org/wiki/Game_fish), then I'm happy with the map.

• improved map description

• improving map description

In D523#21865, @scythetwirler wrote:

Why are there rating parsing changes in the context of this patch?

IMO "Enable Treasures: False" and "Enable Treasures: True" or "Treasures: Enabled" and "Treasures: Disabled" is more natural.

Is there a consensus on which kills should provide loot and which not? I noticed lately elexis didn't like loot for the fox, but we do award it for killing of deer among other animals.

In D523#21868, @elexis wrote:

In D523#21865, @scythetwirler wrote:

IMO "Enable Treasures: False" and "Enable Treasures: True" or "Treasures: Enabled" and "Treasures: Disabled" is more natural.

Should we display Treasues: Enabled even if there are no treasures placed? Seems misleading. My idea was "Treasures: Maybe" and "Treasures: If the map places it", but not happy about any proposal

• renamed Britomartus to Viridomarus, since the latter form is better known and could lead to a false association with the Britons

altered two spellings:
-> 'Britomartos' -> 'Britomartus'
-> 'Valetiacos' -> 'Valetiacus'

The patch fixed minor syntax errors and did not introduce any new errors.

In D531#21658, @fatherbushido wrote:

@Phormio: can you quickly describe why you accept it?

• renamed option 'Disable Treasures' to 'Remove Treasures'
• 'Disabled' and 'Enabled' are lowercase for all other match settings, adjusted accordingly
• elexis can now be happy that someone reviews his patch :)

I don't like the wording of this patch:

• added myself to list of contributors. 'History references' seemed the most accurate category.

There is no reason why this shouldn't follow D507.

• removed skirmish map 'Thessalian Plains (4)' that was erroneously included in the diff. It has already been committed in D511.

• included arctic fox on random map 'Polar Sea'

In D493#20418, @fatherbushido wrote:

In D493#19963, @fatherbushido wrote:

You reviewed all the Gauls templates?

I meant, while at it, perhaps review all the gauls things?

In D507#20737, @fatherbushido wrote:

I would prefer not change the file names (it would need artists agreement and would require some checks) but just focus on strings for that one.

• included PNG images

The Athenian hero Themistocles is intended to be garrisoned in a ship; it's his main feature.

• allow hunting the great white shark
• buff whales

• 'fellow citizens' instead of 'fellow-citizens'

• pullTranslations.py script is now compatible with both Python 2 and Python 3

• just read the new revision summary

• updated file referencing old filename

In D508#20458, @elexis wrote:

Then you must edit all places that hardcode this filename too. The civ json for example.

In D507#20419, @fatherbushido wrote:

I am not good for those things but perhaps you can edit the inconsistant case for bireme and Triremes (low case?).
Else thanks :)

Good suggestion.

• ditched pot file for obvious reasons.

In D497#19931, @elexis wrote:

In D497#19928, @Phormio wrote:

Age of Empires allows hunting dangerous animals like lions. I expected the same when first playing 0.A.D. and found it confusing that the bear could be hunted while other predators could not. And less fun, too. Hence the diff.

Me too in fact, I wanted to change that as well a year ago, but I'm not convinced anymore that this is a good idea

In D498#19961, @fatherbushido wrote:

ok, did you look if there was some reports on transifex?

In D493#19963, @fatherbushido wrote:

You reviewed all the Gauls templates?

Great patch, I'm working on the tree right now and this solved one of my problems.