- User Since
- Apr 17 2017, 9:58 PM (95 w, 5 d)
He means the context lines (lines before and after the codes that are modified).
For each patch, you must add the full context.
To add these lines, refer here.
Thu, Feb 7
One ticket about this. #3800
What do you mean by the sprite's attribute?
Wed, Feb 6
Disables the notification by default.
Change user to client in option's description.
Tue, Feb 5
You are right. I will change that.
Thu, Jan 31
Upload the sound.
New update with a new dedicated Bell tree sound.
Thank's to @Samulis for the creation.
Fri, Jan 25
Maybe try rather adapts the code with the fonction enunciate by smiley.
Thu, Jan 24
Maybe a better balcony scale.
And remove the effect.
- Rephrase in options.
- Changes according to Imarok comments. (don't hide all messages of currents players)
I added this without really take account of what is it.
I think this wrapping effect was useful for avoid the occurence of black border.
But since rev 16747 its use has become useless.
Fri, Jan 18
Oct 18 2018
Oct 17 2018
Apr 22 2018
Dec 20 2017
Nov 17 2017
The number of games can be split above the GamePanel imo.
I think it can be useful when a multiplayer game starts after the countdown.
But this is probably the only way this function can appear.
Idk if the new globals.js file is needed, there isn't another file where this function can be placed?
Oct 25 2017
Oct 13 2017
This countdown can be useful also if added with a countdown sound.
2 differents sounds:
- during the countdown
- and when the game start really.
If the idea is to find the game where the player was playing, i think it would be better to display a pop-up to reconnect to the game when the player is in the lobby.
Oct 2 2017
Sep 28 2017
Sep 27 2017
Sep 25 2017
Nice add and it will be useful for future notifications (e.g. Friend Connection in lobby or others stuffs like that).
I noticed you remove the splitRating part.
Sep 23 2017
Sep 22 2017
Forgot the capital letter in g_SoundNotifications
Sep 21 2017
Sep 20 2017
Aug 21 2017
Jun 13 2017
tutorials.po files are not generated.
Translation on transifex aren't taken into account.
Jun 9 2017
Jun 7 2017
Jun 6 2017
Filenames seem to look more like:
"animal_species" than "species_animal".
It will be "wolf_arctic" for all the filenames.
Jun 2 2017
May 24 2017
I don't like the "if the map places it" sentence.
May 22 2017
Full context this time.
reupload with context
Remove the cleanup file part.
May 21 2017
May 19 2017
This rewriting seems cleaner/better coding style than the actual code.
Object literals increase readability and maintainability in this case.
May 16 2017
You made a mistake that broke the slider case.
May 11 2017
Works for me. Just one suggestion.
May 9 2017
The condition block:
if (this.queue.length == 0) cmpTechnologyManager.StartedResearch(templateName, false);
allows to display faster the in-progress status than to pass by the second call in ProductionQueue.ProgressTimeout (1 to 2 seconds if removed).
I don't think it should be removed.
The patch doesn't break the phase notification.
With actual numerical values (0, 1 and 2) only the completed phase is displayed.
May 1 2017
Apr 26 2017
researchStarted allows to mark the techs currently researched (not in queue).
So the 2 lines can be removed in AddBatch. (condition+call)
If we started the tech. when the queue is empty, we don't need to recall the function through the second step.
It's not really a problem just logic thing.
Apr 23 2017
Apr 22 2017
add a new boolean argument notification, thanks @elexis
- move the started notification in TechnologyManager.
- In ProductionQueue if we are starting a technology and the queue is empty, define productionStarted as true. (avoids double calls of StartedResearch and obviously to display twice started notification)
remove an useless condition
Apr 21 2017
updated in accordance to @elexis review
Apr 19 2017
@mimo: reverting not fixing. it was a bad choice of word. ;)
Change the boolean type by a dropdown in options with 3 news values.
This change allows display or not the notification when the research is started.
Fix some errors with the ia. (can cause problem with the serialize function)
Apr 18 2017
- Fix POV where the notifications weren't displayed.
- Add autoResearch property for hide the phase_village.
- Separate the state and name of phase.
- Using .startsWith("phase_") for check the tech name.
- Collect phase name from the phase template.
Fix some if