Page MenuHomeWildfire Games

Polakrity
User

Projects

User Details

User Since
Apr 17 2017, 9:58 PM (122 w, 3 d)

Recent Activity

Jun 19 2019

Polakrity added inline comments to D1993: petra: Fix all ESLint and JSHint warnings.
Jun 19 2019, 7:44 PM

Jun 5 2019

Polakrity added a comment to D1928: Refactors Developer Overlay.

Just create an object literal.

Jun 5 2019, 1:31 PM
Polakrity added a comment to D1928: Refactors Developer Overlay.

Why not just use Singleton pattern instead using prototypes if only one instance?

Jun 5 2019, 1:16 PM

Jun 1 2019

Polakrity added a comment to D1936: Load damageTypes from "simulation/data/damagetypes"-files..

You can remove descriptions if they are not really descriptive and used for the moment .
Maybe change the name of GetTypes() -> GetCodes() to reflect what it really returns and to be consistent with resources.

Jun 1 2019, 12:27 PM
Polakrity added a comment to D1940: UnitAI cleanup [GATHER].

You can remove some return true.

Jun 1 2019, 12:49 AM

May 31 2019

Polakrity added inline comments to D1938: Easier introduction of new damage types..
May 31 2019, 9:03 PM
Polakrity added inline comments to D1936: Load damageTypes from "simulation/data/damagetypes"-files..
May 31 2019, 8:54 PM
Polakrity added a comment to D1936: Load damageTypes from "simulation/data/damagetypes"-files..

For the translation, you need to focus only in the GUI part.
Look specially to common/tooltips.js

May 31 2019, 8:51 PM
Polakrity added inline comments to D1940: UnitAI cleanup [GATHER].
May 31 2019, 8:07 PM

May 25 2019

Polakrity raised a concern with rP18977: Remove silencing of resource-not-found errors (that were introduced with an….

Templates.js
resources parameter in GetTemplateDataHelper() became unused in the function.

May 25 2019, 4:49 AM

May 20 2019

Polakrity added a comment to D1680: Do not hardcode screen ratio in the main menu..

Test is better than words.

May 20 2019, 1:39 PM
Polakrity added a comment to D1680: Do not hardcode screen ratio in the main menu..

The problem with the current code is that at no time we recover the real size of the backgrounds.
Depending on the window size the tiling backgrounds are more or less fully displayed.

May 20 2019, 10:35 AM
Polakrity added inline comments to D1730: Scroll through loading screen tips.
May 20 2019, 10:02 AM
Polakrity added a comment to D1906: ProductionQueue - Cleanup timer.

For the rounding I thought about ceil rounding timeRemaining in GetQueue().
But I don't know if it's the best thing to do or the best place.

May 20 2019, 9:51 AM · Contributors
Polakrity added a comment to D1776: Cleanup Timer.js and update documentation.

You forgot to put the full context to the diff.

May 20 2019, 9:10 AM
Polakrity updated the diff for D1906: ProductionQueue - Cleanup timer.

var -> let

May 20 2019, 2:29 AM · Contributors

May 19 2019

Polakrity added inline comments to D1906: ProductionQueue - Cleanup timer.
May 19 2019, 7:23 PM · Contributors
Polakrity updated the diff for D1906: ProductionQueue - Cleanup timer.
  • Moves MAX_QUEUE_SIZE into the prototype.
  • Integrates the lateness parameter from Timers.
  • Also fix errors forgotten according to the comments.
May 19 2019, 7:13 PM · Contributors

May 18 2019

Polakrity added inline comments to D1906: ProductionQueue - Cleanup timer.
May 18 2019, 11:39 PM · Contributors
Polakrity added a comment to D1906: ProductionQueue - Cleanup timer.

The timers can have lateness, should not we include this?

May 18 2019, 4:09 PM · Contributors
Polakrity created D1906: ProductionQueue - Cleanup timer.
May 18 2019, 4:03 PM · Contributors

May 12 2019

Polakrity added a comment to D1879: Fix limit restriction for training units in ProductionQueue .

Tested and its works as expected in relation to the ticket.
Move the decrementation entity limit only when the entity has been successfully spawned and before the ownership attribution seems correct.

May 12 2019, 3:33 PM

May 6 2019

Polakrity added a comment to rP22247: Slight cleanup of fogging OnDestroy and some comments.

You are right but it's not easier and usual to use length form to iterate in an array?

May 6 2019, 1:20 AM
Polakrity added a comment to rP22247: Slight cleanup of fogging OnDestroy and some comments.

this.mirages is an array.

May 6 2019, 12:56 AM

Apr 27 2019

Polakrity abandoned D534: ProductionQueue cleanup.

Better to separate this into several differentials and with real things to cleanup.

Apr 27 2019, 1:03 AM
Polakrity added a comment to D1843: ProductionQueue - Refactor the remove item function.
In D1843#76399, @bb wrote:

Careful with Extinct volcano OP-ness (on that map autogarrison would give a significant advantage to some civs)

Apr 27 2019, 1:01 AM · Contributors
Polakrity updated the diff for D1843: ProductionQueue - Refactor the remove item function.

Refactor RemoveBatch function.
Then correct the length check entityCache.

Apr 27 2019, 12:43 AM · Contributors

Apr 25 2019

Polakrity added a comment to rP22230: Fix forgotten tab in rP22227 line 1337..

So it was intended. :d

Apr 25 2019, 11:12 PM
Polakrity added inline comments to rP22227: Reload wheel-adjusted batchsize immediately.
Apr 25 2019, 10:57 PM

Apr 24 2019

Polakrity added a comment to D1758: Smooth new Kushite background.

It should be determined if we want certain elements of the background can't be stretched.
But it can also cause this sprite could be too small compared to other elements for wide screens.

Apr 24 2019, 4:05 AM · Contributors
Polakrity updated the diff for D1758: Smooth new Kushite background.

Use a hack instead of JS modifications.
The JS changes were almost the same as the code for tilling.

Apr 24 2019, 3:44 AM · Contributors

Apr 22 2019

Polakrity accepted rP22204: Rename generic ballista template to boltshooter and onager to stonethrower to….
Apr 22 2019, 6:21 PM
Polakrity updated the test plan for D1843: ProductionQueue - Refactor the remove item function.
Apr 22 2019, 5:36 PM · Contributors
Polakrity created D1843: ProductionQueue - Refactor the remove item function.
Apr 22 2019, 5:34 PM · Contributors
Polakrity raised a concern with rP22204: Rename generic ballista template to boltshooter and onager to stonethrower to….

The Icons of units concerned are no longer displayed.
You forgot to include the renaming pictures with the new names.
Eg: hele_mechanical_siege_lithobolos_packed.png -> hele_siege_lithobolos_packed.png

Apr 22 2019, 5:24 PM

Mar 8 2019

Polakrity added a comment to D1784: Fixed assert fails in Actor Editor.

You could use "Update Diff" in right panel or update via arch.

Mar 8 2019, 3:38 PM · Windows Developers

Feb 16 2019

Polakrity added a comment to D1581: Mod Interface: Enable setting territory visibility.

He means the context lines (lines before and after the codes that are modified).
For each patch, you must add the full context.
To add these lines, refer here.

Feb 16 2019, 7:35 PM

Feb 7 2019

Polakrity added a comment to D1775: Delete unused technologies.

One ticket about this. #3800

Feb 7 2019, 6:22 PM
Polakrity added a comment to D1758: Smooth new Kushite background.

What do you mean by the sprite's attribute?

Feb 7 2019, 6:12 PM · Contributors
Polakrity updated the diff for D1758: Smooth new Kushite background.
Feb 7 2019, 3:24 PM · Contributors

Feb 6 2019

Polakrity updated the diff for D932: Acoustic notification when people join hosted game.

Disables the notification by default.
Change user to client in option's description.

Feb 6 2019, 1:21 PM · Contributors

Feb 5 2019

Polakrity added a comment to D932: Acoustic notification when people join hosted game.
In D932#71669, @Imarok wrote:

The only question that remains: Should it be enabled by default?
It could be quite annoying, so I'd lean to disable it by default.
What do you think?

You are right. I will change that.

Feb 5 2019, 7:51 PM · Contributors

Jan 31 2019

Polakrity added a comment to D932: Acoustic notification when people join hosted game.

Upload the sound.

Jan 31 2019, 4:12 PM · Contributors
Polakrity added a comment to D932: Acoustic notification when people join hosted game.
Jan 31 2019, 3:59 PM · Contributors
Polakrity updated the diff for D932: Acoustic notification when people join hosted game.

New update with a new dedicated Bell tree sound.
Thank's to @Samulis for the creation.

Jan 31 2019, 3:47 PM · Contributors

Jan 25 2019

Polakrity added a comment to D1764: Dynamically sizes the dataCounter overlay.

Maybe try rather adapts the code with the fonction enunciate by smiley.

Jan 25 2019, 8:43 PM

Jan 24 2019

Polakrity updated the diff for D1758: Smooth new Kushite background.

Update patch:
Maybe a better balcony scale.
And remove the effect.

Jan 24 2019, 2:08 PM · Contributors
Polakrity updated the diff for D932: Acoustic notification when people join hosted game.

Update patch:

  • Rephrase in options.
  • Changes according to Imarok comments. (don't hide all messages of currents players)
Jan 24 2019, 1:03 PM · Contributors
Polakrity added inline comments to D1758: Smooth new Kushite background.
Jan 24 2019, 12:12 PM · Contributors
Polakrity added a comment to D1758: Smooth new Kushite background.

I didn't really notice the clouds move too fast but maybe its just me.

Jan 24 2019, 12:11 PM · Contributors
Polakrity updated the summary of D1758: Smooth new Kushite background.
Jan 24 2019, 5:47 AM · Contributors
Polakrity created D1758: Smooth new Kushite background.
Jan 24 2019, 5:40 AM · Contributors

Jan 18 2019

Polakrity awarded D1751: [WIP] Map ping a Pterodactyl token.
Jan 18 2019, 3:31 PM

Oct 18 2018

Polakrity added inline comments to D1651: aiTips gamesetup cleanup.
Oct 18 2018, 8:49 AM · Contributors

Oct 17 2018

Polakrity added a comment to D594: Fix tooltips not used in gamesetup.
In D594#24518, @elexis wrote:

Ok to add the missing ones, even if not all of them seem needed. I'd prefer to wait after the release, so that we don't lose the translations of the existing strings for now.

Oct 17 2018, 1:21 AM · Contributors
Polakrity updated the diff for D594: Fix tooltips not used in gamesetup.
Oct 17 2018, 1:17 AM · Contributors
Polakrity retitled D594: Fix tooltips not used in gamesetup from Fix tooltips in gamesetup to Fix tooltips not used in gamesetup.
Oct 17 2018, 1:16 AM · Contributors
Polakrity created D1651: aiTips gamesetup cleanup.
Oct 17 2018, 12:41 AM · Contributors

Apr 22 2018

Polakrity awarded rP21759: mod.io support. a Like token.
Apr 22 2018, 8:29 PM

Dec 20 2017

Polakrity awarded D1160: Use correct distance for determining nearest dropsite a Yellow Medal token.
Dec 20 2017, 6:28 PM

Nov 17 2017

Polakrity added a comment to D948: Players/Games Numbers Stats in Lobby.

The number of games can be split above the GamePanel imo.

Nov 17 2017, 11:27 AM
Polakrity added a comment to D959: Notify player to take action when window in background.

I think it can be useful when a multiplayer game starts after the countdown.
But this is probably the only way this function can appear.

Nov 17 2017, 11:15 AM
Polakrity added a comment to D816: Make Options Dialog hotkey toggleable in gamesetup, lobby, mainmenu and ingame.

Idk if the new globals.js file is needed, there isn't another file where this function can be placed?

Nov 17 2017, 11:06 AM

Oct 25 2017

Imarok awarded D982: Fix bottom corners alignment in Modern dialog a Mountain of Wealth token.
Oct 25 2017, 4:21 PM · Contributors
Polakrity created D982: Fix bottom corners alignment in Modern dialog.
Oct 25 2017, 3:16 PM · Contributors

Oct 13 2017

Polakrity added a comment to D233: Gamesetup - Countdown before launching the game.

This countdown can be useful also if added with a countdown sound.
2 differents sounds:

  • during the countdown
  • and when the game start really.
Oct 13 2017, 12:48 PM
Polakrity added a comment to D799: Optional highlight user and buddies in lobby.

If the idea is to find the game where the player was playing, i think it would be better to display a pop-up to reconnect to the game when the player is in the lobby.

Oct 13 2017, 12:14 PM

Oct 2 2017

Polakrity awarded D920: Observer Dashboard a Like token.
Oct 2 2017, 11:34 AM
Polakrity added inline comments to D932: Acoustic notification when people join hosted game.
Oct 2 2017, 11:29 AM · Contributors
Polakrity added inline comments to D932: Acoustic notification when people join hosted game.
Oct 2 2017, 9:51 AM · Contributors

Sep 28 2017

Polakrity added inline comments to D932: Acoustic notification when people join hosted game.
Sep 28 2017, 9:09 PM · Contributors
Polakrity updated the diff for D932: Acoustic notification when people join hosted game.
Sep 28 2017, 9:09 PM · Contributors

Sep 27 2017

Polakrity created D932: Acoustic notification when people join hosted game.
Sep 27 2017, 1:40 PM · Contributors

Sep 25 2017

Polakrity added a comment to D929: Acoustic GUI notification test before modifying input.

Nice add and it will be useful for future notifications (e.g. Friend Connection in lobby or others stuffs like that).
I noticed you remove the splitRating part.

Sep 25 2017, 3:39 PM
Polakrity awarded D929: Acoustic GUI notification test before modifying input a Like token.
Sep 25 2017, 2:36 PM

Sep 23 2017

Polakrity updated the diff for D821: Improve acoustic GUI notifications.
Sep 23 2017, 12:28 PM

Sep 22 2017

Polakrity updated the diff for D821: Improve acoustic GUI notifications.

Forgot the capital letter in g_SoundNotifications

Sep 22 2017, 11:01 AM
Polakrity updated the diff for D821: Improve acoustic GUI notifications.
Sep 22 2017, 10:58 AM

Sep 21 2017

Lionkanzen awarded D821: Improve acoustic GUI notifications a Like token.
Sep 21 2017, 1:29 AM
Polakrity updated the diff for D821: Improve acoustic GUI notifications.
Sep 21 2017, 1:22 AM

Sep 20 2017

Polakrity updated the diff for D821: Improve acoustic GUI notifications.

Changes according to @bb and @elexis review.

Sep 20 2017, 4:36 PM

Aug 21 2017

Polakrity created D821: Improve acoustic GUI notifications.
Aug 21 2017, 6:26 PM

Jun 13 2017

Polakrity raised a concern with rP19730: fix tutorial not translated.

tutorials.po files are not generated.
Translation on transifex aren't taken into account.

Jun 13 2017, 2:29 PM

Jun 9 2017

Polakrity added inline comments to rP19733: Spelling corrections for Gauls..
Jun 9 2017, 1:30 PM

Jun 7 2017

Polakrity added inline comments to D533: renamed 'Snow Wolf' to 'Arctic Wolf', renamed wolf template for consistency with other template names.
Jun 7 2017, 1:01 PM

Jun 6 2017

Polakrity added a comment to D533: renamed 'Snow Wolf' to 'Arctic Wolf', renamed wolf template for consistency with other template names.

Filenames seem to look more like:
"animal_species" than "species_animal".
It will be "wolf_arctic" for all the filenames.

Jun 6 2017, 3:59 PM

Jun 2 2017

Polakrity updated the diff for D594: Fix tooltips not used in gamesetup.
Jun 2 2017, 8:36 PM · Contributors
Polakrity created D594: Fix tooltips not used in gamesetup.
Jun 2 2017, 8:35 PM · Contributors

May 24 2017

Polakrity added a comment to D523: Fix objectives dialog value of the Disable Treasures setting and remove double negative.

I don't like the "if the map places it" sentence.

May 24 2017, 6:57 PM

May 22 2017

Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.

Full context this time.

May 22 2017, 5:20 PM
Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.
May 22 2017, 4:33 PM
Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.
May 22 2017, 2:36 PM
Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.

reupload with context

May 22 2017, 1:29 PM
Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.
May 22 2017, 11:15 AM
Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.
May 22 2017, 1:17 AM
Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.

Remove the cleanup file part.

May 22 2017, 1:17 AM
Polakrity created D534: ProductionQueue cleanup.
May 22 2017, 12:17 AM

May 21 2017

Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.
May 21 2017, 8:15 PM
Polakrity updated the diff for D375: Progress more quickly next item in queue & remove duplicate call.
May 21 2017, 8:05 PM
Polakrity retitled D375: Progress more quickly next item in queue & remove duplicate call from StartedResearch function called twice when a research is added in an empty queue to ProductionQueue cleanup and process more quickly next item in queue.
May 21 2017, 8:04 PM