Page MenuHomeWildfire Games

Schweini (Laurenz Reinthaler)
User

Projects

User Details

User Since
Apr 29 2021, 1:30 PM (8 w, 18 h)

Recent Activity

Mon, Jun 21

Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.

@Langbart, if you could test the changes I just made, that would be great!
I sadly don't have 2 machines ready right now (or could I just open up another account ?), so I can't test it, but I think it's right.

Mon, Jun 21, 3:35 PM
Schweini updated the diff for D3958: Add an extra button for seeing the summary page when quitting a session.
Mon, Jun 21, 3:33 PM

Sun, Jun 13

Schweini updated the diff for D3958: Add an extra button for seeing the summary page when quitting a session.
  • Quit to campaign menu, when in campaign session
Sun, Jun 13, 9:07 PM

May 19 2021

Schweini updated the diff for D3958: Add an extra button for seeing the summary page when quitting a session.

Improve on Freagarach's feedback and increase the size of the QuitConfirmation and the QuitConfirmationReplay dialog, so the text doesn't clip out of it's boundaries

May 19 2021, 6:06 PM
Schweini updated the diff for D3958: Add an extra button for seeing the summary page when quitting a session.

Missing Semicolon

May 19 2021, 5:07 PM
Schweini updated the diff for D3958: Add an extra button for seeing the summary page when quitting a session.

Improve on Freagarach's feedback

May 19 2021, 5:04 PM
Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.

I am not quite sure if should change the translation files, as there are now other strings, but I've been told once on the IRC that that's normally not included in the patch.

May 19 2021, 4:44 PM
Schweini updated the diff for D3958: Add an extra button for seeing the summary page when quitting a session.

Change QuitConfirmation and QuitConfirmationReplay strings, as well as fix lint warnings

May 19 2021, 4:41 PM
Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.

I think "Quit and View Summary" translates best what the button does, more back and forth shouldn't be necessary.

May 19 2021, 3:47 PM
Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.

Of course there were multiple opinions in the forum post, but the most prominent answer was this:

May 19 2021, 3:03 PM

May 17 2021

Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.

If I ask you: "Do you want coffee?" and give you three options: "Yes", "Pie" and "No", you don't really know what the implications of "Pie" are. Do you get the coffee and the pie? Dou you only get pie? Is it a bogus answer that has no impact (since it is not an answer to the question).

Thanks that helped a lot!

May 17 2021, 2:42 PM
Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.

Link to the forum discussion: https://wildfiregames.com/forum/topic/40219-discussion-which-dialog-looks-and-sounds-the-best/

May 17 2021, 2:40 PM

May 16 2021

Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.

Thanks for the feedback @Freagarach,

May 16 2021, 11:17 AM

May 15 2021

Schweini added a comment to D3958: Add an extra button for seeing the summary page when quitting a session.

@Langbart regarding your suggestions:

May 15 2021, 10:38 PM
Schweini updated the diff for D3958: Add an extra button for seeing the summary page when quitting a session.

Fix error and translate strings

May 15 2021, 10:33 PM

May 13 2021

Schweini requested review of D3958: Add an extra button for seeing the summary page when quitting a session.
May 13 2021, 5:28 PM

May 11 2021

Schweini added a comment to D1849: Add a "Mac Mouse" option.

Sorry for the late reply @wraitii .
I just tested your changes and everything works as expected.

May 11 2021, 9:15 PM · macOS Developers

May 3 2021

Schweini updated the diff for D1849: Add a "Mac Mouse" option.

Minor change

May 3 2021, 4:17 PM · macOS Developers
Schweini updated the diff for D1849: Add a "Mac Mouse" option.

Add forgotten preprocessor

May 3 2021, 4:09 PM · macOS Developers
Schweini added a comment to D1849: Add a "Mac Mouse" option.

I sadly couldn't get the the hook to work without changing too much of the code, so I've let it be. It would probably the best if you did it.

May 3 2021, 4:02 PM · macOS Developers
Schweini updated the diff for D1849: Add a "Mac Mouse" option.

Improve on wraitii's feedback

May 3 2021, 4:01 PM · macOS Developers
Schweini added a comment to D1849: Add a "Mac Mouse" option.

There is a way to set up a configuration hook to reload things without adding the code in JS, if you're up for that (otherwise I'll see if I can do it myself), but that's a minor thing.

I would be up for doing this, sure. I want to get to know the codebase more anyways :D.
If you could just point me in the right direction? Thanks!

May 3 2021, 3:05 PM · macOS Developers
Schweini updated the diff for D1849: Add a "Mac Mouse" option.

Improved on Stan's feedback and moved the code that emulates the right-click so it can be done without restarting

May 3 2021, 2:42 PM · macOS Developers
Schweini updated the diff for D1849: Add a "Mac Mouse" option.

Rework solution based on wraitii's feedback

May 3 2021, 2:07 PM · macOS Developers
Schweini updated the test plan for D1849: Add a "Mac Mouse" option.
May 3 2021, 2:07 PM · macOS Developers
Schweini added a comment to D1849: Add a "Mac Mouse" option.

I'll update the diff in a second.

First, I would probably do the change in LoadHotkeys: when FindScancode returns UNIFIED_CTRL, you'd instead use UNIFIED_SUPER. It should work the same, but it would work better with the in-game editor.

I have worked on this yesterday and it works much better now, you don't even need a restart.
I am only unsure about the Engine.ReloadHotkeys() call I made in the options.js file.

May 3 2021, 2:05 PM · macOS Developers
Schweini added a comment to D1849: Add a "Mac Mouse" option.

Secondly, you would probably need to change the key names in the hotkey editor, too, because CTRL would need to show as SUPER. I'm not sure if it's better to do that in C++, in CHotkeyPicker, or in JS.

After looking at it, I don't think this should be done as it's confusing when Ctrl appears when you type in Super or the other way around. The user should already know that those actions are changed, so I would let it be as it is.

May 3 2021, 9:29 AM · macOS Developers

May 1 2021

Schweini added a comment to D1849: Add a "Mac Mouse" option.

Thanks for the feedback!

May 1 2021, 6:54 PM · macOS Developers
Schweini updated the diff for D1849: Add a "Mac Mouse" option.
May 1 2021, 1:50 PM · macOS Developers
Schweini retitled D1849: Add a "Mac Mouse" option from Clarify the use of the macmouse config option to Add a "Mac Mouse" option.
May 1 2021, 1:29 PM · macOS Developers
Schweini updated the diff for D1849: Add a "Mac Mouse" option.

Added a "Mac Mouse" option

May 1 2021, 1:21 PM · macOS Developers
Schweini commandeered D1849: Add a "Mac Mouse" option.
May 1 2021, 1:15 PM · macOS Developers

Apr 29 2021

Schweini added a comment to D1849: Add a "Mac Mouse" option.

I also should add that only hotkeys that only use Ctrl should be changed, because of conflicts that could happen, as seen above.

Apr 29 2021, 6:01 PM · macOS Developers
Schweini added a comment to D1849: Add a "Mac Mouse" option.

I think the easiest solution would be to do this change in C++, to be honest, and just pretend 'Ctrl' is pressed when 'Cmd/Super' is pressed, and not considering Ctrl for hotkey resolution. Might be a bit tricky.

Apr 29 2021, 5:54 PM · macOS Developers
Schweini added a comment to D1849: Add a "Mac Mouse" option.

I think this wouldn't be the best solution as:

Apr 29 2021, 5:42 PM · macOS Developers
Schweini added a comment to D1849: Add a "Mac Mouse" option.

After recently looking into this topic I would propose the following change:

Apr 29 2021, 1:35 PM · macOS Developers