Page MenuHomeWildfire Games

Teiresias
User

Projects

User Details

User Since
May 20 2018, 4:44 PM (122 w, 3 d)

Recent Activity

Jan 3 2020

Teiresias created D2531: Analysis of unique_range assertion failure on MacOS.
Jan 3 2020, 7:45 PM · Contributors

Jan 2 2020

Teiresias added inline comments to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).
Jan 2 2020, 7:38 PM
Teiresias added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

No, but I can give it a try on FreeBSD (closely related to MacOS). Further, I have trouble decoding the error:

Jan 2 2020, 10:29 AM

Jan 1 2020

Teiresias updated the diff for D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

Unit test case now writes the binary sample test.zip to the _test.lib directory tree on its own.
This way CI can pass although SVN patches cannot include binary files (suggested by Stan).

Jan 1 2020, 8:22 PM

Dec 27 2019

Teiresias added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

I cannot comment on the segfault, as I do not have a stacktrace available. Here is what I can say by now:

Dec 27 2019, 10:20 PM

Oct 16 2019

Teiresias updated the diff for D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

Minor second update to get parameter references to match CCs

Oct 16 2019, 10:13 PM
Teiresias updated the diff for D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

Updated patch according to Stans requests

Oct 16 2019, 10:10 PM

Oct 5 2019

Teiresias added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

I am sorry, I lost track of this ticket for health reasons. Regarding your questions, it seems I was so occupied by the zip archive problem that I neglected styleguide and common appearance. Here are attempts to answer your observations:

Oct 5 2019, 10:17 PM

Jun 1 2019

Teiresias added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

I uploaded a new .patch file which - checked using local text editor - contains the full context of archive_zip.cpp.
However, using the "Download Raw Diff" button on the topright menu bar it seems that still only the "changed areas" are exported, although Phabricator accepted the new .patch file (Copyright changed from 2018 to 2019).

Jun 1 2019, 10:22 PM
Teiresias updated the diff for D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

Updated diff file to contain full context (using command svn diff --diff-cmd diff -x "-U 99999")

Jun 1 2019, 10:18 PM

May 31 2018

Teiresias created D1545: Provide AI json description files with ID tag to tell them apart from other JSON files.
May 31 2018, 5:32 PM

May 26 2018

Teiresias added a comment to D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

I have updated the patch to match the review items as far as I could to. Refactoring to get rid of the casts has been intentionally skipped for now since the remainder of the file uses the same style and the code has been working that ways for many years. I don't think it is worth to put this at stake.

May 26 2018, 9:43 PM
Teiresias updated the diff for D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).

Fixed most review issues:

  • Updated year in copyright declaration.
  • Adapted braces to CC
  • Changed NULL to nullptr
  • Added missing separator line between includes in test_archive_zip.h
  • Removed references to delete in test case
  • Reduced size of test.zip from 13Kbytes to 0,3KBytes
May 26 2018, 9:38 PM
Teiresias updated the test plan for D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).
May 26 2018, 9:22 PM

May 21 2018

Teiresias updated the test plan for D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).
May 21 2018, 10:54 PM

May 20 2018

Teiresias added a reviewer for D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup): Restricted Project.
May 20 2018, 5:51 PM
Teiresias created D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).
May 20 2018, 5:48 PM