- User Since
- May 20 2018, 4:44 PM (132 w, 5 d)
Jan 3 2020
Jan 2 2020
No, but I can give it a try on FreeBSD (closely related to MacOS). Further, I have trouble decoding the error:
Jan 1 2020
Unit test case now writes the binary sample test.zip to the _test.lib directory tree on its own.
This way CI can pass although SVN patches cannot include binary files (suggested by Stan).
Dec 27 2019
I cannot comment on the segfault, as I do not have a stacktrace available. Here is what I can say by now:
Oct 16 2019
Minor second update to get parameter references to match CCs
Updated patch according to Stans requests
Oct 5 2019
I am sorry, I lost track of this ticket for health reasons. Regarding your questions, it seems I was so occupied by the zip archive problem that I neglected styleguide and common appearance. Here are attempts to answer your observations:
Jun 1 2019
I uploaded a new .patch file which - checked using local text editor - contains the full context of archive_zip.cpp.
However, using the "Download Raw Diff" button on the topright menu bar it seems that still only the "changed areas" are exported, although Phabricator accepted the new .patch file (Copyright changed from 2018 to 2019).
Updated diff file to contain full context (using command svn diff --diff-cmd diff -x "-U 99999")
May 31 2018
May 26 2018
I have updated the patch to match the review items as far as I could to. Refactoring to get rid of the casts has been intentionally skipped for now since the remainder of the file uses the same style and the code has been working that ways for many years. I don't think it is worth to put this at stake.
Fixed most review issues:
- Updated year in copyright declaration.
- Adapted braces to CC
- Changed NULL to nullptr
- Added missing separator line between includes in test_archive_zip.h
- Removed references to delete in test case
- Reduced size of test.zip from 13Kbytes to 0,3KBytes