- User Since
- Aug 5 2018, 1:11 AM (197 w, 4 d)
Mar 5 2022
Mar 3 2022
Mar 2 2022
Rebased against master at d25309b (Wed Mar 2 05:00:23 2022 +0100). The only merge conflict I saw was that "chicken" was changed to "starting_animal" in mainland.js and african_plains.js.
Feb 22 2022
I tested the patch and it works on Manjaro 21.2.3 with python 3.10.2
Dec 16 2021
Nov 20 2021
@Jammyjamjamman attempts to fix the remaining linter messages
Nov 19 2021
Betterize the code
Computes the gap between allies based on radius(g_PlayerbaseTypes[pattern].distance)
Nov 15 2021
In this example (mainland, medium), the 3 players are on the same team, but do you think they are too close together? If so, any suggestions or pseudo-code ideas on how to alter the algorithm on how to prevent that?
Fix placement of players when they are not assigned teams
Nov 12 2021
Me and @Jammyjamjamman have found that on a setup such as a 6 player game, when 2 players are on T1 and the other 4 not assigned to any team, the placement is not correct:
Nov 3 2021
Oct 27 2021
Another attempt to remove linter errors
fix opposing teams spacing, finish de-linting
No, the circle doesn't look right either
@Jammyjamjamman the opposing teams are so close together (3v3 medium map)! Is there anything we can do about that?
Fixes more linter errors
Attempt to fix most linter errors.
Oct 21 2021
As long as the scope of this patch as already expanded, I wanted to suggest enabling "allied view" as the default option. I just anticipate that the majority of hosts or players would want to see their allies when the game starts. Any opinions on this?
Oct 17 2021
I added the besideAllies placement option to Frontier and Ambush
removed some of @Jammyjamjamman 's crazy comments
Oct 16 2021
This fixes the error about the playerIDs.map function I mentioned in the previous diff.
This mostly uses existing code that's used for Frontier and Ambush to create the TeamPlacement drop down box, and adds the same options to Mainland and African plains, plus adds the "Beside Allies" placement option.
Oct 14 2021
Duplicate of D2432
Oct 13 2021
Oct 12 2021
I think it would be good to also add the "stronghold" formation that's used on the Frontier map. I haven't figured out how to implement it cleanly yet though.
temporarily revert african_plains to original version
remove unused tight_arc from g_PlayerbaseTypes (setup.js)
implemented TeamPlacement (per-map) settings similar to Frontier
removed 2 duplicated variables
Oct 11 2021
Still trying to get the value of g_MapSettings.EvenPlayerSpacing for the newly-added condition in the .js files. Still getting the same result. Always evaluates to true.
No changes, just regenerated the diff with 'git diff -U9999 master'
I completed removed african_plains_tg.js and mainland_tg.js. The option is now in the .json files.
So now I've avoided duplicating the maps, and just use 2 distinct json files, adding the setting "EvenPlayerSpacing".
These 2 maps are from the stock mainland and African Plains map.
Sep 29 2021
After applying this patch, rebuilding, I tried this with a skirmish map I made. It didn't turn out correctly:
Sep 28 2021
I understand you'd rather I use C++ code. I'm not famillar with C++ actually, so I'll probably not do anymore with this diff.
Sep 27 2021
This obviously isn't finished yet. I wanted to get some feedback before I proceeded.
Jul 18 2021
Sure. I'm currently building the game+developing this patch from the github mirror. What would "adding this option to atlas" involve?
Jul 12 2021
Jul 6 2021
Me and @Jammyjamjamman just tested it with an Internet game; no problems.
Jul 5 2021
I didn't get any warnings or errors while patching.
Jun 6 2021
imo, I don't really see any value in having periods at the ends of all these incomplete sentences.
Jun 25 2020
My bad.. he ran make clean before re-compiling but didn't run clean-workspaces.sh. Doing so now.. I'll update here shortly.
My friend who is using Manjaro 20, gcc 10.1.0 gets this error, before and after applying the patch.
Jun 23 2020
I have a friend who can't build on Manjaro, an arch derivative, using gcc 10. He's going to apply the patch tomorrow, and I can post results here if still needed. Still needed?
Oct 17 2018
I can't update this revision without creating a new one apparently. So I'll paste it.
Sep 4 2018
but it would be better to figure out how to make macOS work
Aug 28 2018
Aug 26 2018
Aug 22 2018
Aug 19 2018
I tested this patch using Travis..
Aug 18 2018
Aug 17 2018
Aug 15 2018
Aug 14 2018
Aug 13 2018
After reading the comments, I don't really understand what I should do next, if anything. Sounds like you want to fix this with another method, and need to discuss the best approach? I know it's low priority but just thought I'd touch base in case there's anything else I could do with it at the present time.
Aug 12 2018
I tested this patch and added my results to the ticket.