Page MenuHomeWildfire Games

andy5995 (Andy Alt)
User

Projects

User Details

User Since
Aug 5 2018, 1:11 AM (217 w, 20 h)

Recent Activity

Mon, Sep 19

andy5995 added a comment to D2743: [WP] MesonBuild support.

Also there's some info in the meson FAQ about how to use wildcards

Mon, Sep 19, 5:51 PM
andy5995 added inline comments to D2743: [WP] MesonBuild support.
Mon, Sep 19, 5:19 PM

Sep 2 2022

andy5995 added a comment to D2432: Add a -help option.

And if a decision were made, I'd help implement it. This is an example of how I implemented it on rmw https://github.com/theimpossibleastronaut/rmw/blob/master/src/parse_cli_options.c

Sep 2 2022, 8:52 PM
andy5995 added a comment to D2432: Add a -help option.

Well, I guess I'm repeating myself a bit... a man page can be a bitch to maintain. I suggest implementing a parser like C's getopt or https://theboostcpplibraries.com/boost.program_options , and using help2man to generate a man page (which can be at least customized a little with a template).

Sep 2 2022, 8:51 PM
andy5995 awarded D4677: span and string_view for CmdLineArgs a Mountain of Wealth token.
Sep 2 2022, 8:39 PM
andy5995 updated andy5995.
Sep 2 2022, 6:11 PM

Sep 1 2022

andy5995 added a comment to D4777: Fail when wxconfig is missing.
In D4777#203603, @Stan wrote:

Ah nvm the last inline then ^^

Sep 1 2022, 8:24 PM
andy5995 added inline comments to D4777: Fail when wxconfig is missing.
Sep 1 2022, 8:19 PM
andy5995 added inline comments to D4777: Fail when wxconfig is missing.
Sep 1 2022, 8:17 PM
andy5995 added a comment to D4777: Fail when wxconfig is missing.

Nice! After I applied the patch, and renamed /usr/bin/wx-config to /usr/bin/wx-config.old, this is the output

Sep 1 2022, 8:02 PM
andy5995 added a comment to D4777: Fail when wxconfig is missing.

@Stan I'm sorry for using abusive language like that. You didn't deserve it. I had some anger that's not at all related to you and unjustly took it out on you. You're dedicated on work very hard on this project, and definitely I was wrong to state my difference of opinion in such a hostile manner.

Sep 1 2022, 6:37 PM
andy5995 added a comment to D4777: Fail when wxconfig is missing.
In D4777#203583, @lyv wrote:

I am not sure the check should happen earlier. It's only relevant for the pyrogenesis atlas make process, building the other dependencies does not require wx.

Maybe easier on CI I suppose.

Sep 1 2022, 6:22 PM
andy5995 added a comment to D4777: Fail when wxconfig is missing.

@Stan Well... who gives a shit what the ticket was about... if there's a better way to implement the ultimate goal of the ticket.

Sep 1 2022, 6:14 PM
andy5995 added a comment to D4777: Fail when wxconfig is missing.

I was thinking something like

Sep 1 2022, 5:41 PM
andy5995 added a comment to D4777: Fail when wxconfig is missing.

Ok, but why not check for its existence near the top of update-workspaces.sh?

Sep 1 2022, 5:33 PM
andy5995 added a comment to D4777: Fail when wxconfig is missing.

Looks good @Stan , but the check and fail should happen earlier, before the Collada build.

Sep 1 2022, 4:25 PM

Aug 29 2022

andy5995 added a comment to D4777: Fail when wxconfig is missing.

Is it guaranteed that we'll get the error for compile settings earlier?

Aug 29 2022, 9:41 PM

Aug 9 2022

andy5995 updated subscribers of rP27039: [maps] Adjust playerPlacementRiver to group teams on the same side in most cases.
Aug 9 2022, 6:28 AM
andy5995 updated subscribers of D4747: Adjust playerPlacementRiver to group teams on the same side for the most part.
Aug 9 2022, 6:27 AM
andy5995 added a comment to rP27039: [maps] Adjust playerPlacementRiver to group teams on the same side in most cases.

I did some more testing. Teams are correct in a 3v2 or 2v3 or 3v4 or 4v3, but in a 2v4, the placement is incorrect.

Aug 9 2022, 6:26 AM

Aug 8 2022

andy5995 added a comment to D4747: Adjust playerPlacementRiver to group teams on the same side for the most part.

imo, this is a bug fix, not a new feature, so it should get merged before a26 is released if it can get reviewed in time.

Aug 8 2022, 8:42 PM

Aug 7 2022

andy5995 accepted D4747: Adjust playerPlacementRiver to group teams on the same side for the most part.

Works for me. Thanks @marder

Aug 7 2022, 6:57 PM

Jul 31 2022

andy5995 awarded D4747: Adjust playerPlacementRiver to group teams on the same side for the most part a Like token.
Jul 31 2022, 9:43 PM

Jul 6 2022

andy5995 awarded rP26993: Fix formation merging issues. a Cup of Joe token.
Jul 6 2022, 8:12 PM

Jun 14 2022

andy5995 added a comment to P275 Shortlist for potentially removable random maps.

It seems like I see Latium played pretty regularly in the lobby. But I think it could be replaced by a rectangular map that supports all the biomes, like Mainland Rectangled in community maps. Nothing special about that one, it's just Mainland but with canyons on each side so the playing area is rectangular. Although Latium has rivers on each side, so more like Yekaterinaville (also in community maps).

Jun 14 2022, 7:08 AM

Jun 8 2022

andy5995 abandoned D4303: Copy TeamPlacement options from Frontier.

Thanks for reviewing. It sounds pretty confusing and complicated to me, probably partly because I'm not proficient in Javascript. I'll free this up in case someone else would like to do it.

Jun 8 2022, 9:58 PM

Jun 7 2022

andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

var clPlayer = g_TileClasses.player (painted in the createBases function)

Jun 7 2022, 6:18 AM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Simplify

Jun 7 2022, 5:35 AM

Jun 6 2022

andy5995 added a comment to P275 Shortlist for potentially removable random maps.

I suggest we give all removed maps to the 'Community Maps' mod, if the curator of that mod wants them.

Jun 6 2022, 6:26 AM

May 27 2022

andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.
In D4303#198634, @smiley wrote:

This is the desired positions for this placement right?

May 27 2022, 11:49 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.
In D4303#198624, @smiley wrote:

I haven't looked at the actual arc function in detail yet.

(who freely and ethically admits to pinching code from other sources)

Well and good, but would need a link to the original in a comment with the relevant code. And licensing details of course unless the code is public domain and is sufficiently changed.

May 27 2022, 11:49 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

I understand there's a feature freeze now. Is there a chance we could get this in before the a26 release is if we removed the BesideAllies code and associated function, and then just keep the existing placements that we're already using for Frontier. So Mainland and African Plains would still have the same options for Team placement in this patch, but without the new BesideAllies placement (Then we stick that in *after* the a26 release). @marder

May 27 2022, 9:12 AM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

rebased against code in github master and fixed merge conflict in mainland.js

May 27 2022, 9:09 AM

Mar 5 2022

andy5995 awarded D3973: [WIP] Pyrogenesis as a dedicated server a Like token.
Mar 5 2022, 11:59 PM

Mar 3 2022

asterix awarded D4303: Copy TeamPlacement options from Frontier a Love token.
Mar 3 2022, 2:59 PM

Mar 2 2022

andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Rebased against master at d25309b (Wed Mar 2 05:00:23 2022 +0100). The only merge conflict I saw was that "chicken" was changed to "starting_animal" in mainland.js and african_plains.js.

Mar 2 2022, 11:46 PM

Feb 22 2022

andy5995 awarded D4437: Fix building bundled SM78 with python 3.10 a Like token.
Feb 22 2022, 11:12 PM
andy5995 added a comment to D4437: Fix building bundled SM78 with python 3.10.

I tested the patch and it works on Manjaro 21.2.3 with python 3.10.2

Feb 22 2022, 11:12 PM

Dec 16 2021

andy5995 awarded D3998: [PetraAI] - Implement an emergency mode in case of huge losses. a Like token.
Dec 16 2021, 8:50 PM

Nov 20 2021

andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

@Jammyjamjamman attempts to fix the remaining linter messages

Nov 20 2021, 11:03 PM

Nov 19 2021

andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Betterize the code

Nov 19 2021, 10:50 PM
andy5995 awarded D4303: Copy TeamPlacement options from Frontier a Love token.
Nov 19 2021, 6:57 AM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Computes the gap between allies based on radius(g_PlayerbaseTypes[pattern].distance)

Nov 19 2021, 6:15 AM

Nov 15 2021

andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

In this example (mainland, medium), the 3 players are on the same team, but do you think they are too close together? If so, any suggestions or pseudo-code ideas on how to alter the algorithm on how to prevent that?

Nov 15 2021, 8:48 PM
ValihrAnt awarded D4303: Copy TeamPlacement options from Frontier a Love token.
Nov 15 2021, 9:12 AM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Fix placement of players when they are not assigned teams

Nov 15 2021, 6:57 AM

Nov 12 2021

andy5995 added inline comments to D4303: Copy TeamPlacement options from Frontier.
Nov 12 2021, 7:34 AM
andy5995 updated subscribers of D4303: Copy TeamPlacement options from Frontier.

Me and @Jammyjamjamman have found that on a setup such as a 6 player game, when 2 players are on T1 and the other 4 not assigned to any team, the placement is not correct:

Nov 12 2021, 7:24 AM

Nov 3 2021

andy5995 updated andy5995.
Nov 3 2021, 6:54 PM

Oct 27 2021

andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Another attempt to remove linter errors

Oct 27 2021, 10:16 PM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

fix opposing teams spacing, finish de-linting

Oct 27 2021, 8:51 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

No, the circle doesn't look right either

Oct 27 2021, 7:27 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

@Jammyjamjamman the opposing teams are so close together (3v3 medium map)! Is there anything we can do about that?

Oct 27 2021, 7:54 AM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Fixes more linter errors

Oct 27 2021, 7:53 AM
andy5995 updated the summary of D4303: Copy TeamPlacement options from Frontier.
Oct 27 2021, 7:37 AM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Attempt to fix most linter errors.

Oct 27 2021, 7:27 AM

Oct 21 2021

andy5995 added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

As long as the scope of this patch as already expanded, I wanted to suggest enabling "allied view" as the default option. I just anticipate that the majority of hosts or players would want to see their allies when the game starts. Any opinions on this?

Oct 21 2021, 11:59 PM

Oct 17 2021

andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

I added the besideAllies placement option to Frontier and Ambush

Oct 17 2021, 8:54 PM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

removed some of @Jammyjamjamman 's crazy comments

Oct 17 2021, 8:47 PM

Oct 16 2021

andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

This fixes the error about the playerIDs.map function I mentioned in the previous diff.

Oct 16 2021, 9:06 PM
andy5995 retitled D4303: Copy TeamPlacement options from Frontier from Add options to Mainland and African Plains that place teammates more closely together to Add new TeamPlacement option "Beside Allies"; Add more TeamPlacement options to Mainland and African Plains: stronghold, line, randomGroup.
Oct 16 2021, 8:40 PM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

This mostly uses existing code that's used for Frontier and Ambush to create the TeamPlacement drop down box, and adds the same options to Mainland and African plains, plus adds the "Beside Allies" placement option.

Oct 16 2021, 8:31 PM

Oct 14 2021

andy5995 abandoned D4283: Implement "-help" as a command line option.

Duplicate of D2432

Oct 14 2021, 8:44 PM
andy5995 added a comment to D4283: Implement "-help" as a command line option.
In D4283#182540, @sera wrote:

I'm not sure why you've mentioned implementing a command line parser. 0ad already has this.

A poor man solution only.

Oct 14 2021, 8:43 PM
andy5995 added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

[Dropdown] Map state: Concealed, Explored, Revealed.
[Toggle] Allied view

Given the rather minor impact of the bug fixed, and the (seemingly) large (code) readability improvements created, I'd say do that in this patch (which should also fix the bug this patch fixes now).

Oct 14 2021, 8:32 PM

Oct 13 2021

andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

Should the option appear if there are only two players? Better just disable and gray them out.

That would be a separate patch. The random option is also presented for the Frontier and Ambush map.

It seems the default when using "TeamPlacements" is to add that random option (not the randomGroup which is completely different); So any patch that changes the code to remove the random option would affect all maps that use TeamPlacements in the .json file.

Oct 13 2021, 7:58 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.
Oct 13 2021, 7:54 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

Should the option appear if there are only two players? Better just disable and gray them out.

Oct 13 2021, 7:50 PM
andy5995 awarded D4305: Fix bug where scenario map was not loading as revealed when set to revealed. a Like token.
Oct 13 2021, 12:58 AM
andy5995 set the repository for D4303: Copy TeamPlacement options from Frontier to rP 0 A.D. Public Repository.
Oct 13 2021, 12:57 AM
andy5995 added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

LGTM!

Oct 13 2021, 12:56 AM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

I think it would be good to also add the "stronghold" formation that's used on the Frontier map. I haven't figured out how to implement it cleanly yet though.

Oct 13 2021, 12:56 AM

Oct 12 2021

andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

I think it would be good to also add the "stronghold" formation that's used on the Frontier map. I haven't figured out how to implement it cleanly yet though.

Oct 12 2021, 9:40 PM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

temporarily revert african_plains to original version

Oct 12 2021, 9:26 PM
andy5995 retitled D4303: Copy TeamPlacement options from Frontier from Adds maps that place teammates more closely together to Add options to Mainland and African Plains that place teammates more closely together.
Oct 12 2021, 9:22 PM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

remove unused tight_arc from g_PlayerbaseTypes (setup.js)

Oct 12 2021, 9:20 PM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

implemented TeamPlacement (per-map) settings similar to Frontier

Oct 12 2021, 9:15 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

Also, have you seen the Frontier random map? That seems to have what you want.

Oct 12 2021, 7:32 AM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

clean-up

Oct 12 2021, 7:11 AM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

removed 2 duplicated variables

Oct 12 2021, 1:34 AM
andy5995 added inline comments to D4303: Copy TeamPlacement options from Frontier.
Oct 12 2021, 1:32 AM

Oct 11 2021

andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

Still trying to get the value of g_MapSettings.EvenPlayerSpacing for the newly-added condition in the .js files. Still getting the same result. Always evaluates to true.

Oct 11 2021, 8:37 PM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

No changes, just regenerated the diff with 'git diff -U9999 master'

Oct 11 2021, 7:58 PM
andy5995 updated the diff for D4303: Copy TeamPlacement options from Frontier.

I completed removed african_plains_tg.js and mainland_tg.js. The option is now in the .json files.

Oct 11 2021, 7:52 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.
Oct 11 2021, 7:43 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

So now I've avoided duplicating the maps, and just use 2 distinct json files, adding the setting "EvenPlayerSpacing".

Oct 11 2021, 7:36 PM
andy5995 added a comment to D4303: Copy TeamPlacement options from Frontier.

These 2 maps are from the stock mainland and African Plains map.

Oct 11 2021, 7:14 AM
andy5995 requested review of D4303: Copy TeamPlacement options from Frontier.
Oct 11 2021, 7:11 AM

Sep 29 2021

andy5995 added a comment to D4117: [hack] Hack for making a map preview.

After applying this patch, rebuilding, I tried this with a skirmish map I made. It didn't turn out correctly:

Sep 29 2021, 6:00 AM

Sep 28 2021

andy5995 added a comment to D4283: Implement "-help" as a command line option.

I understand you'd rather I use C++ code. I'm not famillar with C++ actually, so I'll probably not do anymore with this diff.

Sep 28 2021, 12:15 AM

Sep 27 2021

andy5995 added a comment to D2432: Add a -help option.
In D2432#102349, @Stan wrote:

Just for the record, only debian seems to provide a man command.

Sep 27 2021, 8:04 PM
andy5995 added a comment to D4283: Implement "-help" as a command line option.
In D4283#182511, @Stan wrote:
Sep 27 2021, 7:52 PM
andy5995 added a comment to D4283: Implement "-help" as a command line option.

This obviously isn't finished yet. I wanted to get some feedback before I proceeded.

Sep 27 2021, 7:19 AM
andy5995 requested review of D4283: Implement "-help" as a command line option.
Sep 27 2021, 7:15 AM

Jul 18 2021

andy5995 added a comment to D4191: Enable Cartography at Start of Game Option.

Sure. I'm currently building the game+developing this patch from the github mirror. What would "adding this option to atlas" involve?

Jul 18 2021, 9:16 PM

Jul 12 2021

andy5995 added inline comments to D4191: Enable Cartography at Start of Game Option.
Jul 12 2021, 6:56 PM

Jul 6 2021

andy5995 added a comment to D4191: Enable Cartography at Start of Game Option.

Me and @Jammyjamjamman just tested it with an Internet game; no problems.

Jul 6 2021, 1:38 AM

Jul 5 2021

andy5995 added a comment to D4191: Enable Cartography at Start of Game Option.

I didn't get any warnings or errors while patching.

Jul 5 2021, 10:41 PM

Jun 6 2021

andy5995 added a comment to D4097: Gamesetup: make tooltips compatible with enabled & disabled settings..

imo, I don't really see any value in having periods at the ends of all these incomplete sentences.

Jun 6 2021, 11:25 PM
andy5995 added inline comments to D4097: Gamesetup: make tooltips compatible with enabled & disabled settings..
Jun 6 2021, 11:10 PM