Page MenuHomeWildfire Games

baco (Dionisio E Alonso)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 18 2022, 3:54 AM (6 w, 3 h)

Recent Activity

Tue, Sep 13

baco updated the diff for D4698: Fix entvalidate.py.

Made Relese NG entity file an optional argument

Tue, Sep 13, 10:03 PM
baco added a comment to D4698: Fix entvalidate.py.
In D4698#203936, @Stan wrote:

Just realised I'm an idiot and you need a way to specify the location because you don't want to put the rng in the mod folder (since you're probably gonna zip it afterwards) and it won't be there on the CI either.

Tue, Sep 13, 2:15 PM
baco updated the diff for D4698: Fix entvalidate.py.

Deleted the middle directory scripts in entity.rng's location. Didn't made it eligible, by argument, to avoid directory creation in case of not existence.

Tue, Sep 13, 1:40 PM
baco added a comment to D4698: Fix entvalidate.py.
In D4698#203928, @Stan wrote:

~~ Sadly I'm not sure I can set you as author. There seem to be a way but I dunno if trac and phab support it https://stackoverflow.com/questions/2107719/how-to-set-author-for-svn#2107898 ~~

EDIT: Seems it's only for files.

Tue, Sep 13, 1:29 PM
baco added inline comments to D4698: Fix entvalidate.py.
Tue, Sep 13, 1:22 PM
baco updated the diff for D4698: Fix entvalidate.py.

It's been a complete overhaul of the file, but it is working. Now it receives the modules' location and name as parameters.

Tue, Sep 13, 12:41 AM

Sun, Sep 11

baco updated the diff for D4698: Fix entvalidate.py.

Added a new diff with the flag -U3000 as suggested on IRC.

Sun, Sep 11, 8:58 PM
baco updated the diff for D4698: Fix entvalidate.py.
Sun, Sep 11, 8:36 PM
baco commandeered D4698: Fix entvalidate.py.
Sun, Sep 11, 8:35 PM

Sun, Sep 4

baco requested changes to D4698: Fix entvalidate.py.

On lines 23 and 25 of the patched file, there is a call to the sys' module exit() function. That usage is discouraged because redefines the exit built-in in Python's interpreter when importing the module containing such import from the interactive Python interpreter. The usual way to handle exit statuses is to make the main function to return those values (def main() -> int) as integer values and handle them in the calling of the main function like so:

Sun, Sep 4, 11:24 PM

Aug 28 2022

baco updated the summary of D4776: Don't mix locally installed python libs when building.
Aug 28 2022, 7:22 PM · Contributors, Restricted Project
baco requested review of D4776: Don't mix locally installed python libs when building.
Aug 28 2022, 6:56 PM · Contributors, Restricted Project