Page MenuHomeWildfire Games

lonehawk
User

Projects

User Details

User Since
Aug 12 2020, 3:40 PM (10 w, 4 d)

Recent Activity

Wed, Sep 30

lonehawk added a comment to D2948: Move PopulationBonus to new component Population.

Do you guys think OnValueModification is where the problem would be? Isn't that what is called whenever the population bonus value is updated?

Wed, Sep 30, 12:26 PM

Aug 31 2020

lonehawk updated the diff for D2948: Move PopulationBonus to new component Population.

Updates GUIInterface for Population component changes

Aug 31 2020, 11:26 AM
lonehawk updated the diff for D2948: Move PopulationBonus to new component Population.

Fixes test case failure, as well as missing Engine while calling QueryInterface in GUIInterface

Aug 31 2020, 11:12 AM
lonehawk added a comment to D2948: Move PopulationBonus to new component Population.

Oops, looks like tests are failing, will fix them

Aug 31 2020, 11:06 AM
lonehawk added a comment to D2948: Move PopulationBonus to new component Population.

Oh, and if you want you can write a simple test for your new component.

Aug 31 2020, 11:00 AM
lonehawk updated the diff for D2948: Move PopulationBonus to new component Population.

Updates tooltips.js and GUIInterface for population bonus changes

Aug 31 2020, 10:58 AM
lonehawk added inline comments to D2948: Move PopulationBonus to new component Population.
Aug 31 2020, 10:16 AM
lonehawk updated the diff for D2948: Move PopulationBonus to new component Population.

Sorts the ordering of content in certain files

Aug 31 2020, 10:15 AM

Aug 29 2020

lonehawk retitled D2948: Move PopulationBonus to new component Population from Move PopulationBonus to new component PopulationHolder to Move PopulationBonus to new component Population.
Aug 29 2020, 2:40 PM
lonehawk updated the diff for D2948: Move PopulationBonus to new component Population.

Removes unnecessary population bonus entry for units and updates a comment in Cost.js

Aug 29 2020, 2:36 PM
lonehawk updated the diff for D2948: Move PopulationBonus to new component Population.

Renames component from PopulationHolder to Population, and also updates GUIInterface.js

Aug 29 2020, 2:23 PM

Aug 28 2020

lonehawk added a comment to D2948: Move PopulationBonus to new component Population.

@Freagarach Yes, I'll be wrapping this up this weekend.

Aug 28 2020, 11:32 AM

Aug 17 2020

lonehawk added a comment to D2948: Move PopulationBonus to new component Population.

Thanks for the review, folks. It's been a busy few days at work. I'll get around to working on this someday this week ๐Ÿ˜

Aug 17 2020, 10:45 AM

Aug 13 2020

lonehawk updated the diff for D2948: Move PopulationBonus to new component Population.

Refactors the code to follow conventions and also to improve performance (slightly)

Aug 13 2020, 2:30 PM
lonehawk added a comment to D2948: Move PopulationBonus to new component Population.

@Freagarach The sorter did sort all the files, but it sorted all the comments in some of those files as well. I wasn't sure how to proceed with those, so I discarded them alone. Around 4-5 files I believe. No worries, I'll run the script again and push them with the rest of the changes.

Aug 13 2020, 11:23 AM
lonehawk added a comment to D2948: Move PopulationBonus to new component Population.

General comments about style (see also @wiki CC):

  • We use let as much as possible as opposed to var to limit the scope of a variable.
  • Comments start with a capital and end in a dot.
  • We like to keep the templates in alphabetical order (there is a script for that in source/tools/templatessorter).

Regarding the name of the component, to me it seems that PopulationBonus would be more appropriate, then you can give it an Amount node in the template. PopulationHolder does not seem to cover what it does.

Another thought: Maybe all of the population ought to be moved to this new component, also the population "cost". Perhaps you would need for someone more experienced to answer this question. Then one can have the Population component with two possible entries Cost and Bonus (or Used and Provided).

Aug 13 2020, 10:41 AM
lonehawk updated the diff for D2948: Move PopulationBonus to new component Population.

Sorts template contents using the templatessorter script

Aug 13 2020, 10:36 AM

Aug 12 2020

lonehawk requested review of D2948: Move PopulationBonus to new component Population.
Aug 12 2020, 5:09 PM