Page MenuHomeWildfire Games

mmoanis (Mohamed Moanis)
User

Projects

User Details

User Since
May 27 2017, 1:53 PM (287 w, 6 d)

Recent Activity

Jan 6 2019

mmoanis added a comment to D1525: Add a lobby server port config option .

@Stan @Dunedan I will work on it, Currently I am about to start my exams so I will be delayed for a bit of time.

Jan 6 2019, 11:45 AM

Jan 3 2019

mmoanis updated subscribers of D1525: Add a lobby server port config option .

Hi @Itms I am available for any further modification needed.

Jan 3 2019, 12:02 PM

Jun 12 2018

mmoanis added inline comments to D1570: Fix typo in lobby server README.
Jun 12 2018, 8:29 PM

Jun 9 2018

mmoanis updated the diff for D1570: Fix typo in lobby server README.
Jun 9 2018, 11:02 PM
mmoanis created D1570: Fix typo in lobby server README.
Jun 9 2018, 11:01 PM
mmoanis added a comment to D1525: Add a lobby server port config option .

Sorry for the delay. Testing on a custom server (ejabberd 18.04) is done and working as expected, patch should be ready to go.

Jun 9 2018, 10:53 PM
mmoanis updated the test plan for D1525: Add a lobby server port config option .
Jun 9 2018, 10:41 PM

May 31 2018

mmoanis added inline comments to D1525: Add a lobby server port config option .
May 31 2018, 9:38 PM
mmoanis added a comment to D1525: Add a lobby server port config option .

ejabberd Ubunut package for Xenial turned to be version 16.01-2

May 31 2018, 9:35 PM

May 30 2018

mmoanis added inline comments to D1525: Add a lobby server port config option .
May 30 2018, 10:29 PM

May 28 2018

mmoanis added inline comments to D1525: Add a lobby server port config option .
May 28 2018, 9:49 PM
mmoanis updated the diff for D1525: Add a lobby server port config option .

Initialize member variable to default value to avoid UB

May 28 2018, 9:48 PM

May 26 2018

elexis awarded D1525: Add a lobby server port config option a Like token.
May 26 2018, 11:33 AM
mmoanis created D1525: Add a lobby server port config option .
May 26 2018, 11:29 AM

Oct 6 2017

mmoanis updated the diff for D567: Add spies to the summary screen.

Used the summaryArraySum and getPlayerValuesPerTeam instead of writing my own function

Oct 6 2017, 4:47 PM

Sep 26 2017

mmoanis added a comment to D567: Add spies to the summary screen.

@Imarok Please review my changes

Sep 26 2017, 7:23 PM

Sep 15 2017

mmoanis updated the diff for D567: Add spies to the summary screen.

Avoid using g_TeamHelperData and calculate team bribes when requested. Also, show stats about successful and failed bribes.

Sep 15 2017, 2:42 AM

Sep 4 2017

mmoanis added inline comments to D567: Add spies to the summary screen.
Sep 4 2017, 11:23 PM

Sep 3 2017

mmoanis updated the diff for D567: Add spies to the summary screen.

Added team statistics in summary screen

Sep 3 2017, 3:27 PM
mmoanis added a comment to D567: Add spies to the summary screen.

@Imarok Okay I am working on it, sorry my laptop was broken.

Sep 3 2017, 1:32 PM

Jul 23 2017

mmoanis added a comment to D624: Failed bribe should cost resources.
In D624#26388, @mimo wrote:

There is still the comment on line 552. No need to make a new call to Engine.GetTemplate
Apart from that, looks good to me, but need to wait for after A22 is released to be commited as we are in feature freeze now.

Jul 23 2017, 12:43 PM

Jun 16 2017

mmoanis updated the diff for D624: Failed bribe should cost resources.

Update the attribute cost. This is how the bribe tooltip will look like:

Jun 16 2017, 5:33 PM

Jun 11 2017

mmoanis updated the diff for D624: Failed bribe should cost resources.

Added the multiplier as a template. Update unit test for vision sharing.

Jun 11 2017, 11:15 PM
mmoanis updated the diff for D624: Failed bribe should cost resources.

Moved duplicate code into 1 function.

Jun 11 2017, 8:31 PM
mmoanis added a comment to D624: Failed bribe should cost resources.
In D624#25567, @mimo wrote:

Thanks, the patch looks much nicer (and simpler) now. There are still two possible enhancements if you are up to:

  • put the 0.25 in a template if a mod want to change it. Most logical would look to me in VisionSharing where we already have the Bribable and Duration properties.
  • addSpy and IncurUnsuccessfulBribeCost share some code for the bribe cost. Could be put in a common fonction.
Jun 11 2017, 8:00 PM

Jun 10 2017

mmoanis updated the diff for D624: Failed bribe should cost resources.

Reverted the multiplier and instead use a fixed value of 0.25 of the bribe cost.

Jun 10 2017, 3:59 PM
mmoanis updated the diff for D624: Failed bribe should cost resources.

Update tech bonus

Jun 10 2017, 10:49 AM
mmoanis added a comment to D624: Failed bribe should cost resources.
In D624#25465, @elexis wrote:

See menu.js of rP19357

Jun 10 2017, 10:00 AM
mmoanis updated the diff for D624: Failed bribe should cost resources.

Update the tooltip for the bribe button to show that a failed bribe will have a cost.
Also fixed a failed test case in test_player.js

Jun 10 2017, 9:56 AM
mmoanis created D624: Failed bribe should cost resources.
Jun 10 2017, 2:05 AM

Jun 9 2017

mmoanis updated the diff for D599: Remember selected graphs when switching tabs in summary.
Jun 9 2017, 9:33 AM

Jun 3 2017

mmoanis updated the diff for D599: Remember selected graphs when switching tabs in summary.

unnecessary white spaces

Jun 3 2017, 6:19 PM
mmoanis updated the diff for D599: Remember selected graphs when switching tabs in summary.

Removed the hack used to reset the saved selection also fixed the styling issues.

Jun 3 2017, 6:13 PM
mmoanis updated the test plan for D599: Remember selected graphs when switching tabs in summary.
Jun 3 2017, 5:23 PM
mmoanis created D599: Remember selected graphs when switching tabs in summary.
Jun 3 2017, 5:22 PM

Jun 2 2017

mmoanis added a comment to D567: Add spies to the summary screen.

Okay, I will wait the refactoring then continue.

Jun 2 2017, 10:42 AM

May 28 2017

mmoanis created D567: Add spies to the summary screen.
May 28 2017, 3:48 PM