@Stan @Dunedan I will work on it, Currently I am about to start my exams so I will be delayed for a bit of time.

Hi @Itms I am available for any further modification needed.

Sorry for the delay. Testing on a custom server (ejabberd 18.04) is done and working as expected, patch should be ready to go.

ejabberd Ubunut package for Xenial turned to be version 16.01-2

Initialize member variable to default value to avoid UB

Used the summaryArraySum and getPlayerValuesPerTeam instead of writing my own function

@Imarok Please review my changes

Avoid using g_TeamHelperData and calculate team bribes when requested. Also, show stats about successful and failed bribes.

Added team statistics in summary screen

@Imarok Okay I am working on it, sorry my laptop was broken.

In D624#26388, @mimo wrote:

There is still the comment on line 552. No need to make a new call to Engine.GetTemplate
Apart from that, looks good to me, but need to wait for after A22 is released to be commited as we are in feature freeze now.

Update the attribute cost. This is how the bribe tooltip will look like:

Added the multiplier as a template. Update unit test for vision sharing.

Moved duplicate code into 1 function.

In D624#25567, @mimo wrote:

Thanks, the patch looks much nicer (and simpler) now. There are still two possible enhancements if you are up to:

• put the 0.25 in a template if a mod want to change it. Most logical would look to me in VisionSharing where we already have the Bribable and Duration properties.
• addSpy and IncurUnsuccessfulBribeCost share some code for the bribe cost. Could be put in a common fonction.

Reverted the multiplier and instead use a fixed value of 0.25 of the bribe cost.

Update tech bonus

In D624#25465, @elexis wrote:

See menu.js of rP19357

Update the tooltip for the bribe button to show that a failed bribe will have a cost.
Also fixed a failed test case in test_player.js

unnecessary white spaces

Removed the hack used to reset the saved selection also fixed the styling issues.

Okay, I will wait the refactoring then continue.