Page MenuHomeWildfire Games

nwtour
User

Projects

User Details

User Since
Jan 5 2018, 5:45 AM (170 w, 3 d)

Recent Activity

Sat, Apr 10

nwtour requested review of D3829: Fix undefined values in barter tooltip.
Sat, Apr 10, 3:46 PM
nwtour added a comment to rP25225: Simplify GUI Proxy implementation & customisation..

can you be sure to make clean & delete compilation artifacts such as already-compiled static libraries?

Sat, Apr 10, 1:01 PM
nwtour added a comment to rP25225: Simplify GUI Proxy implementation & customisation..

Doesn't compile on my system:

Linking pyrogenesis
g++ -o "../../../binaries/system/pyrogenesis" obj/pyrogenesis_Release/main.o    -L../../../binaries/system -L../../../libraries/source/spidermonkey/lib -L../../../libraries/source/nvtt/lib -Wl,--no-undefined -Wl,--as-needed -Wl,-z,relro -Wl,-rpath,'$ORIGIN' -Wl,--enable-new-dtags -pthread -Wl,--start-group ../../../binaries/system/libmocks_real.a ../../../binaries/system/libnetwork.a ../../../binaries/system/librlinterface.a ../../../binaries/system/libtinygettext.a ../../../binaries/system/liblobby.a ../../../binaries/system/libsimulation2.a ../../../binaries/system/libscriptinterface.a ../../../binaries/system/libengine.a ../../../binaries/system/libgraphics.a ../../../binaries/system/libatlas.a ../../../binaries/system/libgui.a ../../../binaries/system/liblowlevel.a ../../../binaries/system/libmongoose.a -lGL -lSDL2 -lpng16 -lz -lmozjs78-ps-release -lmozjs78-ps-rust -lxml2 -lboost_filesystem-mt -lboost_system-mt -lenet -lcurl -licui18n -licuuc -licudata -lsodium -lfmt -latomic -lX11 -lnvcore -lnvmath -lnvimage -lnvtt -lrt -ldl -Wl,--end-group
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_GUIProxy.o): in function `JSI_GUIProxy<CButton>::CreateFunctions(ScriptRequest const&, GUIProxyProps*)':
/usr/include/fmt/printf.h:228: multiple definition of `JSI_GUIProxy<CButton>::CreateFunctions(ScriptRequest const&, GUIProxyProps*)'; ../../../binaries/system/libgui.a(JSInterface_CButton.o):/usr/include/fmt/format.h:2344: first defined here
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_GUIProxy.o): in function `JSI_GUIProxy<CText>::CreateFunctions(ScriptRequest const&, GUIProxyProps*)':
/usr/include/fmt/core.h:1060: multiple definition of `JSI_GUIProxy<CText>::CreateFunctions(ScriptRequest const&, GUIProxyProps*)'; ../../../binaries/system/libgui.a(JSInterface_CText.o):/usr/include/fmt/format.h:2344: first defined here
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_GUIProxy.o): in function `JSI_GUIProxy<CList>::CreateFunctions(ScriptRequest const&, GUIProxyProps*)':
/usr/include/fmt/core.h:1060: multiple definition of `JSI_GUIProxy<CList>::CreateFunctions(ScriptRequest const&, GUIProxyProps*)'; ../../../binaries/system/libgui.a(JSInterface_CList.o):/usr/include/fmt/format.h:2344: first defined here
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_GUIProxy.o): in function `JSI_GUIProxy<IGUIObject>::CreateFunctions(ScriptRequest const&, GUIProxyProps*)':
/usr/include/fmt/printf.h:232: multiple definition of `JSI_GUIProxy<IGUIObject>::CreateFunctions(ScriptRequest const&, GUIProxyProps*)'; ../../../binaries/system/libgui.a(JSInterface_IGUIObject.o):/usr/include/fmt/format.h:2459: first defined here
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CButton.o): in function `bool JSInterface_GUIProxy::apply_to<CButton, CButton, &CButton::getTextSize>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `CButton::getTextSize(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CButton.o): in function `bool JSInterface_GUIProxy::apply_to<CButton, IGUIObject, &IGUIObject::getComputedSize>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::getComputedSize(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CButton.o): in function `bool JSInterface_GUIProxy::apply_to<CButton, IGUIObject, &IGUIObject::blur>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::blur(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CButton.o): in function `bool JSInterface_GUIProxy::apply_to<CButton, IGUIObject, &IGUIObject::focus>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::focus(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CButton.o): in function `bool JSInterface_GUIProxy::apply_to<CButton, IGUIObject, &IGUIObject::toString>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::toString(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CList.o): in function `bool JSInterface_GUIProxy::apply_to<CList, IGUIObject, &IGUIObject::getComputedSize>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::getComputedSize(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CList.o): in function `bool JSInterface_GUIProxy::apply_to<CList, IGUIObject, &IGUIObject::blur>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::blur(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CList.o): in function `bool JSInterface_GUIProxy::apply_to<CList, IGUIObject, &IGUIObject::focus>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::focus(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CList.o): in function `bool JSInterface_GUIProxy::apply_to<CList, IGUIObject, &IGUIObject::toString>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::toString(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CText.o): in function `bool JSInterface_GUIProxy::apply_to<CText, CText, &CText::getTextSize>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `CText::getTextSize(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CText.o): in function `bool JSInterface_GUIProxy::apply_to<CText, IGUIObject, &IGUIObject::getComputedSize>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::getComputedSize(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CText.o): in function `bool JSInterface_GUIProxy::apply_to<CText, IGUIObject, &IGUIObject::blur>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::blur(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CText.o): in function `bool JSInterface_GUIProxy::apply_to<CText, IGUIObject, &IGUIObject::focus>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::focus(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_CText.o): in function `bool JSInterface_GUIProxy::apply_to<CText, IGUIObject, &IGUIObject::toString>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::toString(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_IGUIObject.o): in function `bool JSInterface_GUIProxy::apply_to<IGUIObject, IGUIObject, &IGUIObject::getComputedSize>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::getComputedSize(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_IGUIObject.o): in function `bool JSInterface_GUIProxy::apply_to<IGUIObject, IGUIObject, &IGUIObject::blur>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::blur(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_IGUIObject.o): in function `bool JSInterface_GUIProxy::apply_to<IGUIObject, IGUIObject, &IGUIObject::focus>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::focus(ScriptInterface&, JS::MutableHandle<JS::Value>)'
/usr/bin/ld.default: ../../../binaries/system/libgui.a(JSInterface_IGUIObject.o): in function `bool JSInterface_GUIProxy::apply_to<IGUIObject, IGUIObject, &IGUIObject::toString>(JSContext*, unsigned int, JS::Value*)':
/home/nwtour/ff/0ad/build/workspaces/gcc/../../../source/gui/Scripting/JSInterface_GUIProxy_impl.h:59: undefined reference to `IGUIObject::toString(ScriptInterface&, JS::MutableHandle<JS::Value>)'
collect2: error: ld returned 1 exit status
Sat, Apr 10, 11:55 AM

Thu, Apr 8

nwtour requested review of D3820: Make Introducing Tutorial compatible with D3686.
Thu, Apr 8, 11:10 PM

Mon, Mar 29

nwtour added a comment to D3767: Show non-default hotkeys that appear in JSON spec files in the hotkey editor..

Tested. It`s work.
Сome to the category "Other Hotkeys" - it is right.
If you make an unmapping of custom hotkeys - it disappears forever. It is possible bad

Mon, Mar 29, 7:12 PM
nwtour added inline comments to D3641: Improve & translate hotkey name/descriptions.
Mon, Mar 29, 6:14 PM
nwtour added inline comments to D3641: Improve & translate hotkey name/descriptions.
Mon, Mar 29, 6:08 PM

Sun, Mar 28

nwtour retitled D3764: Fix possibility first chapter of the campaign from Fix in the first chapter of the campaign to Fix possibility first chapter of the campaign .
Sun, Mar 28, 11:55 PM
nwtour updated the summary of D3764: Fix possibility first chapter of the campaign .
Sun, Mar 28, 11:19 PM
nwtour requested review of D3764: Fix possibility first chapter of the campaign .
Sun, Mar 28, 11:17 PM
nwtour updated the diff for D3733: Small fix text align and falsely tooltip in gamesetup.

setTooltip directly
it fixed wrong tooltip for "random" dropdown entity

Sun, Mar 28, 4:05 PM
nwtour added a comment to D3733: Small fix text align and falsely tooltip in gamesetup.

I tested it - a bad way. For dropdowns, the "random" tooltip filled with wrong value...

Sun, Mar 28, 3:45 PM
nwtour added a comment to D3733: Small fix text align and falsely tooltip in gamesetup.

definitely something we want to support IMO.

Sun, Mar 28, 3:35 PM
nwtour updated the diff for D3733: Small fix text align and falsely tooltip in gamesetup.

align to "left"
update tooltip after rendering
fill tooltip with civilisation info

Sun, Mar 28, 3:30 PM

Sat, Mar 27

nwtour updated the diff for D3754: Fix hotkeypage missing translation (translateWithContext).

add l10n with context -> hotkey category

Sat, Mar 27, 2:04 PM
nwtour updated the summary of D3754: Fix hotkeypage missing translation (translateWithContext).
Sat, Mar 27, 12:57 PM
nwtour requested review of D3754: Fix hotkeypage missing translation (translateWithContext).
Sat, Mar 27, 12:53 PM

Fri, Mar 26

nwtour updated the diff for D3745: Fix several missing translatation with context in tooltip.

translate with context receiverTooltip

Fri, Mar 26, 4:53 PM
nwtour added a comment to D3733: Small fix text align and falsely tooltip in gamesetup.

(Do we still have mixed maps in the current gamesetup iteration?)

Fri, Mar 26, 4:30 PM
nwtour retitled D3745: Fix several missing translatation with context in tooltip from Fix missing translatation with context in tooltip to Fix several missing translatation with context in tooltip.
Fri, Mar 26, 1:16 PM
nwtour requested review of D3745: Fix several missing translatation with context in tooltip.
Fri, Mar 26, 1:14 PM

Wed, Mar 24

nwtour requested review of D3733: Small fix text align and falsely tooltip in gamesetup.
Wed, Mar 24, 12:56 PM

Tue, Mar 23

nwtour updated the diff for D3575: Fix assert in topology.cpp.

2018 -> 2021

Tue, Mar 23, 3:39 PM
nwtour added a comment to D3575: Fix assert in topology.cpp.

In theory it might get working.

Tue, Mar 23, 1:22 PM
nwtour updated the diff for D3575: Fix assert in topology.cpp.

Change inline asm

Tue, Mar 23, 1:15 PM

Mon, Mar 22

nwtour added inline comments to D3726: attempt to update D3023.
Mon, Mar 22, 9:49 PM
nwtour added inline comments to D3726: attempt to update D3023.
Mon, Mar 22, 8:32 PM
nwtour added inline comments to D3726: attempt to update D3023.
Mon, Mar 22, 8:26 PM
nwtour updated the diff for D3725: Allow unset civ in Atlas editor.

update year

Mon, Mar 22, 7:44 PM
nwtour requested review of D3725: Allow unset civ in Atlas editor.
Mon, Mar 22, 6:28 PM

Sat, Mar 20

nwtour added a comment to D3710: Fix compilation in Clang/Linux (undefined reference to atomic).

Boost has own implementation under BOOST_LOCKFREE_FORCE_BOOST_ATOMIC define.

Sat, Mar 20, 6:12 PM
nwtour added a comment to D3710: Fix compilation in Clang/Linux (undefined reference to atomic).

Also adding --with-system-atomic might be a choice.

Sat, Mar 20, 4:55 PM

Fri, Mar 19

nwtour added inline comments to D3641: Improve & translate hotkey name/descriptions.
Fri, Mar 19, 9:58 PM
nwtour added a comment to D3710: Fix compilation in Clang/Linux (undefined reference to atomic).

How a similar problem was solved in open projects

Fri, Mar 19, 5:14 PM

Thu, Mar 18

nwtour added a comment to D3710: Fix compilation in Clang/Linux (undefined reference to atomic).

As I understand the problem, some distributions pack libatomics into a separate library. At the same time, the GCC knows that it is standard and the Clang needs to be indicated -latomic.

Thu, Mar 18, 5:56 PM
nwtour requested review of D3710: Fix compilation in Clang/Linux (undefined reference to atomic).
Thu, Mar 18, 2:57 PM

Tue, Mar 16

nwtour added a comment to D3641: Improve & translate hotkey name/descriptions.

QWERTY/AZERTY keyboards it's good to show the 'local' hotkeys

Tue, Mar 16, 11:51 PM
nwtour added a comment to D3641: Improve & translate hotkey name/descriptions.

The hotkeys are only shown in 'local' alphabets, but the actual position on the keyboard doesn't change.

Tue, Mar 16, 9:06 PM
nwtour added a comment to D3641: Improve & translate hotkey name/descriptions.

two notes (while translating):

Tue, Mar 16, 8:11 PM
nwtour added a comment to D3641: Improve & translate hotkey name/descriptions.

I also had to delete the "msgctx hotkey metadata" line from ".po" file - the translations did not shift with them. I don't know whether it is a bug or so it should be

Tue, Mar 16, 6:34 PM
nwtour added a comment to D3641: Improve & translate hotkey name/descriptions.

I downloaded the patch, found no problems

Tue, Mar 16, 6:14 PM

Mon, Mar 15

nwtour added a comment to D3575: Fix assert in topology.cpp.

Launched step-by-step instructions under the debugger. There is no reordering. Differences in only three lines (the meaning of which is magic for me)
standard cpuid

Mon, Mar 15, 4:31 PM
nwtour added a comment to D3575: Fix assert in topology.cpp.

cpuid should be thread-safe.

Mon, Mar 15, 12:01 PM
nwtour added a comment to D3575: Fix assert in topology.cpp.

So, both tests mean that the GCC_VERSION condition ins't necessary.

Mon, Mar 15, 10:19 AM

Sun, Mar 14

nwtour added a comment to D3575: Fix assert in topology.cpp.

Does it change if use clang instead of gcc?

$ clang++ -std=c++17 test_ht.cpp -o test_ht && chmod u+x ./test_ht && ./test_ht
hyperthreading : supported
$ clang++ -std=c++17 -fPIC test_ht.cpp -o test_ht && chmod u+x ./test_ht && ./test_ht
hyperthreading : supported
$ clang++ -std=c++17 -fPIE test_ht.cpp -o test_ht && chmod u+x ./test_ht && ./test_ht
hyperthreading : supported
$ clang++ -std=c++17 -msse -fPIC test_ht.cpp -o test_ht && chmod u+x ./test_ht && ./test_ht
hyperthreading : supported
$ clang++ -std=c++17 -msse -fPIE test_ht.cpp -o test_ht && chmod u+x ./test_ht && ./test_ht
hyperthreading : supported
$ clang++ -std=c++17 -msse test_ht.cpp -o test_ht && chmod u+x ./test_ht && ./test_ht
hyperthreading : supported
$ clang++ -v
clang version 11.0.0
Target: i686-pc-linux-gnu
Thread model: posix

Sun, Mar 14, 2:35 PM
nwtour added a comment to D3575: Fix assert in topology.cpp.

If insert in source/lib/sysdep/arch/x86_x64/topology.cpp string:

Sun, Mar 14, 12:46 PM
nwtour added a comment to D3575: Fix assert in topology.cpp.

Could you test the following code with different combinations of compiler arguments, like msse and fpic (g++ -std=c++17 test_ht.cpp -o test_ht && ./test_ht):

Sun, Mar 14, 12:29 PM
nwtour updated the diff for D3575: Fix assert in topology.cpp.

Returned to the original minimum change

Sun, Mar 14, 6:28 AM

Mar 13 2021

nwtour added a comment to D3604: responsive hotkey scrollspeed.
  • m_ViewRotate*Speed should have been printed for both components: X and Y
Mar 13 2021, 7:25 AM

Mar 12 2021

nwtour updated the diff for D3604: responsive hotkey scrollspeed.

Remove premake5.lua change
Build successfull and smoke test passed

Mar 12 2021, 10:42 AM
nwtour requested review of D3667: Fix typo in iberians blacksmith.xml.
Mar 12 2021, 10:25 AM
nwtour added inline comments to D3604: responsive hotkey scrollspeed.
Mar 12 2021, 8:31 AM
nwtour updated the diff for D3604: responsive hotkey scrollspeed.

to %0.1f

Mar 12 2021, 8:31 AM
nwtour updated the diff for D3604: responsive hotkey scrollspeed.

added zoom and rotate speed
translate smoke test passed

Mar 12 2021, 8:26 AM

Mar 11 2021

nwtour updated the diff for D3604: responsive hotkey scrollspeed.

sync with master

Mar 11 2021, 9:43 PM

Mar 10 2021

nwtour added a comment to D3657: Fixed round typo in selection_details.js.
In D3657#159801, @Angen wrote:

so now instead calling round, ceil, floor, toFixed functions

Mar 10 2021, 9:17 AM

Mar 9 2021

nwtour added a comment to D3657: Fixed round typo in selection_details.js.
In D3657#159799, @Angen wrote:

hence proposed global function which would returned correctly rounded values to be displayed in gui

Mar 9 2021, 9:19 PM
nwtour added a comment to D3657: Fixed round typo in selection_details.js.
In D3657#159744, @Angen wrote:

If you _really_ want to use round here,

Mar 9 2021, 8:59 PM
nwtour updated the diff for D3657: Fixed round typo in selection_details.js.

another way

Mar 9 2021, 8:48 PM
nwtour added a comment to D3657: Fixed round typo in selection_details.js.
In D3657#159739, @Angen wrote:

please keep in mind value in simulation can be 0.4 in this case it would show 0, what is wrong,
we rather use ceil

Mar 9 2021, 4:40 PM
nwtour requested review of D3657: Fixed round typo in selection_details.js.
Mar 9 2021, 10:58 AM

Mar 7 2021

nwtour added a comment to D3596: Translate hotkeys & customise categories..

@wraitii Great job.
Only case sensitivity is something that can scare off a casual user. When the first letter is capitalized - it is very difficult to search

Mar 7 2021, 8:59 AM

Mar 6 2021

nwtour added a comment to D3493: improve consistency in tutorial and random map descriptions.

That's odd.

Wide character in subroutine entry at checkrefs.pl line 335.

The line in question is:

my $settings = decode_json($map->{ScriptSettings});

I don't know what that means, nor which file, line, or character is causing it.

Mar 6 2021, 1:35 PM
nwtour added a comment to D3596: Translate hotkeys & customise categories..

Should I remove the hotkeys from the in-game manual?

Mar 6 2021, 1:00 AM

Mar 4 2021

nwtour updated the diff for D3615: Predictable Replay cache rebuild.

typedef -> using
displayReplayList(): replay_menu.js -> replay_menu.xml

Mar 4 2021, 7:05 PM
nwtour added a comment to D3631: Fix compilation with --without-audio.
In D3631#158768, @Stan wrote:

One could also wrap the constants in a macro?

Mar 4 2021, 6:15 PM
nwtour added a comment to D3631: Fix compilation with --without-audio.
Mar 4 2021, 5:52 PM
nwtour updated the diff for D3631: Fix compilation with --without-audio.

.

Mar 4 2021, 5:44 PM
nwtour added a comment to D3615: Predictable Replay cache rebuild.
Mar 4 2021, 5:29 PM
nwtour added a comment to D3631: Fix compilation with --without-audio.

I think it'd be better if you followed the usual conversion, which is doing something like

void someFunc()
Mar 4 2021, 4:42 PM

Mar 3 2021

nwtour requested review of D3631: Fix compilation with --without-audio.
Mar 3 2021, 10:18 PM

Mar 2 2021

nwtour added inline comments to D3615: Predictable Replay cache rebuild.
Mar 2 2021, 12:45 AM
nwtour updated the diff for D3615: Predictable Replay cache rebuild.

compare size as off_t, mtime as u64

Mar 2 2021, 12:44 AM

Mar 1 2021

nwtour added a comment to D3621: Fix profiler: graph.html.

(FYI, Profiler2 is generally used more for fine-grained profiling, in case you haven't run into that one)

Mar 1 2021, 10:30 PM
nwtour requested review of D3621: Fix profiler: graph.html.
Mar 1 2021, 10:20 PM
nwtour updated the diff for D3615: Predictable Replay cache rebuild.

fileTimeInCache -> fileMTime

Mar 1 2021, 9:57 PM
nwtour added a comment to D1593: Patches required to work with latest clang on FreeBSD.

Yes. Patch succesfully applied and Atlas successfuly build with wxWidget 3.0.5.1 @Stan

Mar 1 2021, 9:48 PM
nwtour updated the diff for D3615: Predictable Replay cache rebuild.

fixed typo

Mar 1 2021, 9:23 PM
nwtour updated the diff for D3615: Predictable Replay cache rebuild.

Update year
Name "_fileMTimeInCache" renamed to "fileTimeInCache"
std::pair -> std::tuple

Mar 1 2021, 9:21 PM
nwtour added inline comments to D3615: Predictable Replay cache rebuild.
Mar 1 2021, 8:14 PM

Feb 28 2021

nwtour requested review of D3615: Predictable Replay cache rebuild.
Feb 28 2021, 10:38 PM

Feb 26 2021

nwtour added a comment to D1202: Fix Atlas compilation error in wxWidget 3.0.X.
In D1202#157175, @Stan wrote:

One thing you can do is close this one (abandon) and commandeer the other one so we can finish it.

Feb 26 2021, 4:21 PM
nwtour added a comment to D1202: Fix Atlas compilation error in wxWidget 3.0.X.

I'm not sure which code is correct either. Mine is taken from official documentation but looks dirtier

Feb 26 2021, 3:36 PM
nwtour updated the diff for D1202: Fix Atlas compilation error in wxWidget 3.0.X.

Update patch for git 0ad

Feb 26 2021, 5:42 AM
nwtour added a comment to D1202: Fix Atlas compilation error in wxWidget 3.0.X.

With wxWidgets-3.1.X version compilation now successfull (linux+gcc)
With wxWidgets-3.0.X version compilation failed

Feb 26 2021, 5:39 AM

Feb 25 2021

nwtour updated the diff for D3604: responsive hotkey scrollspeed.
  • Update year
  • Value now natural digit
  • String can be translated
Feb 25 2021, 9:55 PM
nwtour updated the diff for D3604: responsive hotkey scrollspeed.

Full context + screenshot

Feb 25 2021, 12:16 AM

Feb 24 2021

nwtour requested review of D3604: responsive hotkey scrollspeed.
Feb 24 2021, 11:59 PM
nwtour updated the diff for D3582: Garbage in menu Language.

I still think that it is not working correct now
IMHO Game cannot add endonyms if you cannot provide the glyphs in which they are printed

Feb 24 2021, 10:48 PM

Feb 20 2021

nwtour added a comment to D3582: Garbage in menu Language.
In D3582#156547, @Stan wrote:

The reason we do not add those characters is that it makes the fonts too big. Instead CJK are provided as mods of around 100MB each.

Feb 20 2021, 2:52 AM
nwtour updated the diff for D3582: Garbage in menu Language.

fix

Feb 20 2021, 1:50 AM
nwtour updated the diff for D3582: Garbage in menu Language.

Remove endonym_generator.pl

Feb 20 2021, 1:37 AM

Feb 19 2021

nwtour requested review of D3582: Garbage in menu Language.
Feb 19 2021, 11:27 PM

Feb 18 2021

nwtour added a comment to D3575: Fix assert in topology.cpp.

What's wrong with my I386 detection macro?

Feb 18 2021, 8:16 AM
nwtour added inline comments to D3575: Fix assert in topology.cpp.
Feb 18 2021, 7:39 AM
nwtour requested review of D3579: Fix hotkey cannot be unset.
Feb 18 2021, 2:11 AM

Feb 17 2021

nwtour updated the diff for D3575: Fix assert in topology.cpp.

Define CPUID_IMPLEMENTATION_* in x86_x64.h and use them in x86_x64.cpp and topology.cpp

Feb 17 2021, 9:46 PM
nwtour added a comment to D3575: Fix assert in topology.cpp.

Attached codeblocks from x86_x64.cpp
Version 1 (Windows version): Probably this version correct in all CPU/architectures/compilator options/etc. I don't know if this assertion is possible there.
If another user (on Windows) receives this assertion, this is 99 percent a different issue.

Feb 17 2021, 8:59 PM
nwtour added a comment to D3575: Fix assert in topology.cpp.
In D3575#156310, @Stan wrote:

Well your patch does it anyway :)

Feb 17 2021, 6:49 PM
nwtour added a comment to D3575: Fix assert in topology.cpp.
In D3575#156260, @Stan wrote:

Hey thanks for the patch ! You might want to move that into the check for IsHyperThreading capable.

Feb 17 2021, 6:11 PM