Page MenuHomeWildfire Games

phosit
User

Projects

User Details

User Since
Mar 25 2022, 1:22 PM (8 w, 4 d)

Recent Activity

Yesterday

phosit updated the diff for D4614: Test for CFont.

Triger rebuild

Tue, May 24, 10:56 AM
phosit set the repository for D4614: Test for CFont to rP 0 A.D. Public Repository.
Tue, May 24, 10:51 AM

Mon, May 23

phosit updated the diff for D4614: Test for CFont.
Mon, May 23, 10:52 PM
phosit added inline comments to D4614: Test for CFont.
Mon, May 23, 10:08 PM
phosit updated the diff for D4614: Test for CFont.
Mon, May 23, 10:04 PM
phosit added inline comments to D4614: Test for CFont.
Mon, May 23, 9:42 PM
phosit added inline comments to D4614: Test for CFont.
Mon, May 23, 8:56 PM
phosit requested review of D4664: Non-local condition_variable.
Mon, May 23, 7:37 PM

Thu, May 19

phosit added inline comments to D4614: Test for CFont.
Thu, May 19, 3:56 PM
phosit added a comment to D4614: Test for CFont.

Ideally I'd prefer to not have back relation CFont > CFontManager (via callback). I don't think CFontManager being friend of CFont is worse than that, because it makes CFont a pure data holder without much logic.

Thu, May 19, 2:19 PM
phosit added a comment to D4657: [Gameplay] - Remove min distance from siege towers.

Heavy Warships also have this behavior.

Thu, May 19, 10:12 AM

Wed, May 18

phosit accepted D4655: Fix issues with han siege tower.

The Flag dont disapear on halt and on attack the spears dont move (this is good).
Just for understanding what is the Footprint stuff about?

Wed, May 18, 6:33 PM

Sun, May 15

phosit updated the diff for D4614: Test for CFont.

include and type change

Sun, May 15, 10:40 PM
phosit added inline comments to D4614: Test for CFont.
Sun, May 15, 9:33 PM
phosit updated the diff for D4614: Test for CFont.

CFont now only has const public member functions.
CFont can only be created using CFont::Create.

Sun, May 15, 4:31 PM

Thu, May 12

phosit added a comment to D4642: Add EGL support for Wayland.

Test results from Mentula on #0ad-dev with the patch: https://paste.gnome.org/KNeEYmHZZ
and bevore the patch:

Thu, May 12, 8:51 PM

Tue, May 10

phosit added inline comments to D4642: Add EGL support for Wayland.
Tue, May 10, 6:26 PM
phosit added a comment to D4642: Add EGL support for Wayland.

With SDL_VIDEODRIVER=wayland(or disabeling xwayland) sdl_video_backend is Wayland and without x11.
After using atlas sdl_video_backend is none.
Screenshots work in the game and atlas.

Tue, May 10, 12:31 PM

Sat, May 7

phosit accepted D4636: Adds dummy renderer backend.

It looks fine. I don't notice a performance difference.

Sat, May 7, 11:47 AM

Fri, May 6

phosit added a comment to D4636: Adds dummy renderer backend.

Why are the constructors private?

To emphasize that they should be created only by their device.

Fri, May 6, 6:10 PM

Thu, May 5

phosit added a comment to D4636: Adds dummy renderer backend.

Why not use variant? (instead of a pointer to base class)

A bit longer usage, having GL (and other backends) includes (direct or indirect) for regular code to know the size

Thu, May 5, 11:39 PM
phosit added a comment to D4636: Adds dummy renderer backend.

Why not use variant? (instead of a pointer to base class)

Thu, May 5, 6:46 PM

Sun, May 1

phosit requested review of D4633: Use corect value_type to iterate over the map.
Sun, May 1, 1:34 PM

Fri, Apr 29

phosit added a comment to rP26834: Adds AsFloatArray to CMatrix3D..

Why are so many CMatrix3D fonctions defined in the header?

Fri, Apr 29, 9:52 AM

Thu, Apr 28

phosit added inline comments to D4614: Test for CFont.
Thu, Apr 28, 11:41 AM

Tue, Apr 26

phosit added a comment to D4617: Restrict access for Read/WriteFile functions.

You don't know what they do:

  • They might just declare a constant
  • They might be a "function"
  • They might modify local variables, without me passing them as argument.
Tue, Apr 26, 2:26 PM
phosit updated the diff for D1578: Basic refactoring of FSM.
  • rebase
  • using instead of typedef
Tue, Apr 26, 12:35 PM
phosit commandeered D1578: Basic refactoring of FSM.
Tue, Apr 26, 12:08 PM

Mon, Apr 25

phosit added a comment to D4617: Restrict access for Read/WriteFile functions.

As always macros should be avoided but we can do that in another diff.

Mon, Apr 25, 1:02 PM
phosit updated the diff for D4614: Test for CFont.

test if the error/wargnig is logged.

Mon, Apr 25, 12:08 PM
phosit added inline comments to D4614: Test for CFont.
Mon, Apr 25, 10:14 AM

Apr 24 2022

phosit added inline comments to D4614: Test for CFont.
Apr 24 2022, 5:22 PM
phosit added a comment to D4617: Restrict access for Read/WriteFile functions.

I encountered no error.

Apr 24 2022, 4:04 PM

Apr 23 2022

phosit updated the diff for D4614: Test for CFont.

CFonts are const outside of CFontManager
Improved spelling in comments

Apr 23 2022, 8:52 AM

Apr 22 2022

phosit added inline comments to D4614: Test for CFont.
Apr 22 2022, 9:59 PM
phosit added inline comments to D4614: Test for CFont.
Apr 22 2022, 6:39 PM
phosit updated the diff for D4614: Test for CFont.

Pascal case for CFont::SetTexture

Apr 22 2022, 1:05 PM
phosit requested review of D4614: Test for CFont.
Apr 22 2022, 11:05 AM

Apr 18 2022

phosit added a comment to D4606: Remove the Profiler allocation counter.

This solves #6476

Apr 18 2022, 4:21 PM

Apr 16 2022

phosit added inline comments to D4530: Fix an infinite loop when trying to word-wrap.
Apr 16 2022, 11:39 AM

Apr 15 2022

phosit added inline comments to D4599: Allow setting the passability class dynamically..
Apr 15 2022, 11:22 AM

Apr 14 2022

phosit added a comment to D4603: LIB_URL zlib change.

Sory, i missonderstood Stans comment.
Go ahead

Apr 14 2022, 8:24 AM

Apr 13 2022

phosit added a comment to D4603: LIB_URL zlib change.
In D4603#195828, @Stan wrote:

Lib update is post FF material so committing this sounds good.

Apr 13 2022, 8:20 PM
phosit added a comment to D4602: Avoids assertions in case of corrupted game saves.

ther are more spots were i would use reinterpret_cast

Apr 13 2022, 11:48 AM
phosit added a comment to D4602: Avoids assertions in case of corrupted game saves.

Did you update to the last svn?

Apr 13 2022, 11:11 AM
phosit added a comment to D4602: Avoids assertions in case of corrupted game saves.

It does not compile on my machine:

Apr 13 2022, 9:15 AM

Apr 2 2022

phosit added inline comments to D4585: Fix research icon position.
Apr 2 2022, 9:14 PM
phosit added a comment to D4279: Improve minimap viewpoint-polygon placement.

I think using the sea level (as of now) is a nice mindset. So the solution would be to raise the wather level in the affected maps.

That doesn't work when a map is on a side of a hill.

Apr 2 2022, 9:02 PM
phosit added inline comments to D4585: Fix research icon position.
Apr 2 2022, 8:13 PM
phosit added a comment to D4279: Improve minimap viewpoint-polygon placement.

This is becoming to complex and we will never draw the exact "field of vision".
In my opinnion there should be one "intersection plain" across the map.

Apr 2 2022, 6:30 PM

Apr 1 2022

phosit updated the summary of D4585: Fix research icon position.
Apr 1 2022, 5:59 PM
phosit set the repository for D4585: Fix research icon position to rP 0 A.D. Public Repository.
Apr 1 2022, 5:53 PM
phosit requested review of D4585: Fix research icon position.
Apr 1 2022, 5:46 PM

Mar 30 2022

phosit added a comment to D4573: Atlas: Close the Actor Viewer if you leave the object tab.

If it might be the same bug isn't the patch just hiding it? Could you tell the reason of the crash from the ticket?

yes it is. no i don't

It'd be useful to understand the reason. Can you reproduce the crash from the ticket?

Mar 30 2022, 11:26 AM

Mar 28 2022

phosit added a comment to D4573: Atlas: Close the Actor Viewer if you leave the object tab.

The specivic defect from the trac issue is solved/unreachable.
But ther are other bugs in Atlas, or it is the same bug from a different angle.

If it might be the same bug isn't the patch just hiding it? Could you tell the reason of the crash from the ticket?

Mar 28 2022, 6:38 PM
phosit added a comment to D4573: Atlas: Close the Actor Viewer if you leave the object tab.

The specivic defect from the trac issue is solved/unreachable.
But ther are other bugs in Atlas, or it is the same bug from a different angle.

Mar 28 2022, 6:28 PM
phosit requested review of D4576: Update water-height-slider if the water-height is picked on the map.
Mar 28 2022, 11:33 AM
phosit added a comment to D4573: Atlas: Close the Actor Viewer if you leave the object tab.

I get sometimes a crash when doing the following:

  • Start Atlas
  • switch to object tab
  • click on Switch to Actor View
  • click on Switch to Game View
  • switch to map settings
  • click on generate map
  • switch to object tab
  • click on Switch to Actor View
Mar 28 2022, 8:19 AM

Mar 27 2022

phosit added a comment to D4573: Atlas: Close the Actor Viewer if you leave the object tab.

I am getting a crash when doing the following:
...

I followd your instructions but don't get a crash.

Mar 27 2022, 10:24 PM
phosit accepted D4400: Remove hardcoded shadows in Atlas UI.
Mar 27 2022, 10:07 PM
phosit requested review of D4573: Atlas: Close the Actor Viewer if you leave the object tab.
Mar 27 2022, 8:00 PM

Mar 26 2022

phosit updated the diff for D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.

Applied suggestions from @vladislavbelov.

Mar 26 2022, 9:13 PM
phosit added a comment to D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

builderr-release-gcc7.txt
In file included from ../../../source/pch/atlas/precompiled.h:26:
../../../source/tools/atlas/GameInterface/Messages.h: In function 'void AtlasMessage::fGetTerrainGroupPreviews(AtlasMessage::qGetTerrainGroupPreviews*)':
../../../source/tools/atlas/GameInterface/Messages.h:305:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
 struct sTerrainTexturePreview
        ^~~~~~~~~~~~~~~~~~~~~~
../../../source/tools/atlas/GameInterface/Messages.h:305:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
../../../source/tools/atlas/GameInterface/Messages.h:305:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
../../../source/tools/atlas/GameInterface/Messages.h:305:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
 struct sTerrainTexturePreview
        ^~~~~~~~~~~~~~~~~~~~~~
../../../source/tools/atlas/GameInterface/Messages.h:305:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
../../../source/tools/atlas/GameInterface/Messages.h:305:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/7564/display/redirect

Mar 26 2022, 2:46 PM
phosit updated the diff for D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.

Updated Copyright Year

Mar 26 2022, 1:54 PM
phosit updated the diff for D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.

last patch could not be applied

Mar 26 2022, 12:54 PM
phosit added a comment to D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.

git diff --no-prefix -U300 --output=diff

Mar 26 2022, 12:48 PM
phosit updated the diff for D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.
  • Direct initialization of two floats
  • More const variables
  • Folowing the brace-style
Mar 26 2022, 12:40 PM

Mar 25 2022

phosit updated the diff for D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.
Mar 25 2022, 4:54 PM
phosit requested review of D4570: Use return values instead of out-parameters in source/graphics/Camera.cpp.
Mar 25 2022, 4:37 PM