- User Since
- Dec 28 2016, 6:22 PM (138 w, 1 d)
Jun 4 2017
Addressed by r19735.
String change looks fine, although we should probably change capitalization to be consistent with other buttons: "Mark as Buddy"
May 31 2017
Are there any cases where we would get no player selected (like selected player leaving or finishing a game or something?) and the enabled=true still that would cause undefined behavior?
May 26 2017
Definitely agree with this change.
May 25 2017
After discussion on IRC, we agreed to also add an "unassign by default" option.
May 24 2017
Definitely agree with this change. :)
Not sure this is the right way to implement this. Other games often have a "spectate" button and a "join" button, with the join button (and/or the spectate button) settable to require a password by the host. IMO this seems like like over-use of the buddy system (and makes it harder to reason through).
Have you been able to successfully run newer versions of Ejabberd?
May 22 2017
Why are there rating parsing changes in the context of this patch?
May 17 2017
Sounds good to me.
Go for it! :)
May 4 2017
Just to confirm, that error was when you tried to connect your local ejabberd instance, correct?
Apr 28 2017
I think target time for a single fireship to destroy a dock should be around 15-25 seconds.
Apr 27 2017
Perhaps reduce HP of the fire ship? It doesn't sound unreasonable that a dock is vulnerable to fire and may require extra defenses around the dock if an opponent has Iberians.
Maybe increase repeatTie/prepareTime and decrease Hack and Pierce attack? Crush should be the primary damage as both crush and fire should be the most effective against structures.
Apr 26 2017
The dots seem like the best solution to me.
Apr 14 2017
Apr 13 2017
I'm going to have to agree with vladislav, "Create" rather hides the fact that they are the host (even if we have NAT traversal and stuff, it probably won't work on some networks and they might wonder why).
Apr 11 2017
Why not just "Registration Forbidden"?
Apr 7 2017
I'd lean toward name sorting, but either is fine.
I'd agree with elexis. The extra header doesn't add much in terms of helping the user understand the meaning of the column while making it less attractive.
Apr 5 2017
Can you add a screenshot as well?
Apr 3 2017
What is the function of the Buddies radiobutton?
Mar 31 2017
Mar 30 2017
Mar 23 2017
Mar 19 2017
Wouldn't you check all settings before you click "I'm ready"? If we can't take the time to look over all the settings before we press "I'm ready", I doubt that you're going to catch much more in 10 seconds.
In any case, if the process of readying-up involves too many steps, I think the overall better way would be to change the "Game settings have been changed." message to a more descriptive message mentioning exactly what has been changed.
Mar 17 2017
Maybe yellow for regular users, orange for friends, green for mods, light-blue for mod-friends?
Mar 16 2017
Seems like a good concept. :)
I'd actually be in favor of making all players one color, moderators in another, buddy in another, mod+buddy in another.
New numbers look acceptable.
I'm quite reluctant to add another radio button at the top. Can we make buddy games appear in bold instead?
Also, still don't really like buddy filtering. It seems like a lot of trouble for something that not many would use (and if many did use, new players might feel left out etc.) Could also increase the number of bug reports of "why is the lobby empty?" if someone accidentally presses the button.
Mar 15 2017
I'm not too sure about having chat filters...it may lead to an assumption on the part of the player that his or her messages are only visible to the filtered party, which I think (?) is not the case.
Mar 13 2017
Removes broken cleanup code.
New buddy column rather makes an already cramped list even more cramped. :/
Other sections still need some English proofing (which I will do later if I have time)
Would make it easier for the translators (and anyone who isn't fluent in English)
"Filter out open games" or "filter by leaving only the open games in."
Mar 12 2017
"Filter open games" seems a bit ambiguous (filter out?). Perhaps "Only show open games"?
Mar 11 2017
gonna change some things to how iqhandler works
Mar 6 2017
Some English suggestions. :)
Mar 2 2017
Mar 1 2017
Agree with fatherbushido. There are also a lot of changes in this diff that aren't mentioned in the summary. and thus, has no visible justification within this page. This revision should probably be split into multiple tickets.
Feb 13 2017
I'd rather see the game list only hold concrete values (attributes of the game itself) instead of derived fields, but after talking with elexis, this feature seems like it would only be used by a subset of the lobby; perhaps a config option customizing columns?
Feb 10 2017
Personally, I'm not sure really sure having an extra column really helps that much (1200 could mean a 1500 + 900 vs two 1200s), especially when we're already pressed for space in that box.
Feb 1 2017
Jan 28 2017
Dunno about you guys, but in about every game I've seen, catapults have more HP than ballistas :P
Jan 25 2017
Jan 19 2017
Ah okay, I was using the sandbox 2 for ptol.
I'm still getting 9 units for the mercenary camp. I'll check on my end to see if it's a caching issue or something.
I'd say nah. What's the purpose behind the tokens deletion line, btw?
I'm not really liking having 9 units in the mercenary camp stretching onto two lines...perhaps we can remove the non-mercenary units from that building?
Jan 15 2017
Or we could move most heroes to the CC (like Macedonians currently).
Jan 9 2017
Ah ok. Sounds good. I'll review the other parts soonish.
Perhaps we could include a warning the first time the player clicks this about the host being able to pull a fast one on them? :P
I'm probably quite out of touch for balance, but I envisioned the mercenary archers to be a bit like a handicap early game for Ptolemies (low health, costs metal) in terms of early game military might (with the exception of camel archers). With free basic structures, are there any handicaps for Ptolemies to stop developing quicker than other civs?