Page MenuHomeWildfire Games

smiley (M.L)
User

Projects

User Details

User Since
Jan 31 2018, 11:59 AM (44 w, 5 d)

Recent Activity

Today

smiley added a comment to D1692: Reset selection in findIdleUnits even if no units are idle.

To be honest, I find this behavior to be more unintuitive. Currently I won't lose my selection if I just wanted to check if there are any idle units (usually, if there are none I would do something with the current selection. But now, I would have to add the units to the selection after.
Maybe it's just me, but I think it would be best to remove that todo. Engine.PlayUISound(filename, looping); if interested.

Tue, Dec 11, 7:03 AM

Fri, Dec 7

smiley added a comment to rP21943: Update client\'s default.cfg for the new muc room `arena23b`.

Not to mention ~1GB for an upgrade which literally added nothing visible. Not really an issue for most though.

Fri, Dec 7, 7:11 AM

Thu, Dec 6

smiley added a comment to rP21943: Update client\'s default.cfg for the new muc room `arena23b`.

Not sure whether intentional, but wont this prevent 23 playing with 23b. I thought that was a requirement judging from all the hassle about compatibility.

Thu, Dec 6, 4:49 PM

Wed, Dec 5

smiley added inline comments to D1688: Ignore entities out of the passable map area in GetLandSpawnPoints.
Wed, Dec 5, 8:19 AM

Tue, Dec 4

smiley added inline comments to D1688: Ignore entities out of the passable map area in GetLandSpawnPoints.
Tue, Dec 4, 10:23 PM
smiley added inline comments to D1688: Ignore entities out of the passable map area in GetLandSpawnPoints.
Tue, Dec 4, 9:47 PM
smiley added inline comments to D1688: Ignore entities out of the passable map area in GetLandSpawnPoints.
Tue, Dec 4, 9:03 PM
smiley created D1688: Ignore entities out of the passable map area in GetLandSpawnPoints.
Tue, Dec 4, 8:57 PM
smiley added a comment to D1687: Fix build on OSX 10.9.5 Mavericks.
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: 0ad/libraries/osx/build-osx-libs.sh
|===================================================================
|--- 0ad/libraries/osx/build-osx-libs.sh
|+++ 0ad/libraries/osx/build-osx-libs.sh
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
1 out of 1 hunk ignored

Path of the file seems off.

Tue, Dec 4, 6:54 AM

Thu, Nov 29

smiley added inline comments to D1683: Removes hardcoded SkyBox sizes and use infinity sky.
Thu, Nov 29, 8:24 AM
smiley added inline comments to D1683: Removes hardcoded SkyBox sizes and use infinity sky.
Thu, Nov 29, 7:56 AM

Mon, Nov 26

smiley added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

What about people on those platforms who have fixed it themselves. Assuming this is a library bug.

Mon, Nov 26, 1:44 PM
smiley added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

I guess it’s low priority if it only affect a subset of a platform. Same goes for the glsl crash too.

Mon, Nov 26, 11:44 AM
smiley added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

The problem of crashes still persists. The average user would not know (wont even try probably) the cause of the crash. And there would be a lot of “disable TLS” replies to reports. Pop-up or a tooltip would do maybe.

Mon, Nov 26, 11:30 AM
smiley added a comment to D1679: Add an option to allow players to circumvent TLS bugs.

Some kind of a warning or a note under places which could end up crashing.

Mon, Nov 26, 10:35 AM

Sun, Nov 25

smiley added a comment to D1660: Move Wild Lake biome specifics to a JSON file.

+1 for that. But thats a lot of new directories. We got a lot of skirmish+scenario maps as well.

Sun, Nov 25, 5:19 PM
smiley added a comment to D1660: Move Wild Lake biome specifics to a JSON file.

While I do agree that the current directory structure is messy (especially the map specific biomes in rmbiome), I dont see a particular issue with this approach. We do the same thing for heightmaps, triggerscripts and pmp files.
But I suppose the object could be moved in to the script. Would not really change anything.

Sun, Nov 25, 2:42 PM
smiley added inline comments to D1660: Move Wild Lake biome specifics to a JSON file.
Sun, Nov 25, 10:40 AM
smiley added inline comments to D1680: Do not hardcode screen ratio in the main menu..
Sun, Nov 25, 10:33 AM

Sat, Nov 24

smiley added a comment to D1660: Move Wild Lake biome specifics to a JSON file.

(We should decide wether or not to add those to biomes or remove them from the map)

Why are those the only two options? As said, these are things *based* upon the selected mod. Not the biome itself. What would happen in “new_map” which want to do something extra like ponds or something if the selected biome was “xyz.json”. Sure, we could add the function to the core or let the map extend it.
In this case, the buildings were a nice addition. And most likely, they would be map specific. So we could either;

  • Do nothing and keep a bunch of related data seperately in the map.
  • Take all those data, combine them and make one nice json file.

...and another map may not want to use that base texture for that specific biome

At that point, isnt it a different biome in technical sense? When a map want to do something like that, they are already using a new map specifc biome regardless of how the script does it. Change enough, and you have to something like gulf_of_bothnia or fields_of_meroe.

Sat, Nov 24, 11:47 AM
smiley added a comment to D1660: Move Wild Lake biome specifics to a JSON file.

The way I see it, this is not a biome at all. This is just defining entities based on the biome. I do not think these should be put in to the biome files for the reason. The next such map may not want to have Romans in the Alpine biome. So, I think that keeping this as part of the map would be best.

Sat, Nov 24, 10:14 AM

Wed, Nov 21

smiley accepted D1675: Remove excess argument from shift call.

No issues still. Generated caledonian_meadows and roads are correct.

Wed, Nov 21, 5:58 PM

Mon, Nov 19

smiley added inline comments to D1677: [Minor cleanup] Use typed arrays where possible and worth it..
Mon, Nov 19, 7:58 PM
smiley added inline comments to D1677: [Minor cleanup] Use typed arrays where possible and worth it..
Mon, Nov 19, 7:22 PM
smiley created D1677: [Minor cleanup] Use typed arrays where possible and worth it..
Mon, Nov 19, 7:19 PM
smiley added inline comments to D1589: Get rid of TERRAIN_SEPARATOR.
Mon, Nov 19, 2:20 PM

Sat, Nov 17

smiley added a comment to D1640: ConvexPolygonPlacer optimization in rmgen..

What is the double meaning in respect to vectors? Different objects in math have an Absolute Value but each object type's absolute is unambiguous.

Exactly what I had in mind while I was writing that. In case of a simple number, it is the “value” of it. Which could be misunderstood as a "simple getting rid of the minus". Obviously, this is not the case with vectors. Not a big deal, pretty unlikely scenario anyway.

Sat, Nov 17, 5:22 PM
smiley added a comment to D1640: ConvexPolygonPlacer optimization in rmgen..

Also the prototype "length" should be called "abs" because the meaning of the resulting value depends on the case the lib's code usually doesn't know - in this case it happens to be the volume.

abs might have a double meaning, but so does length. It should technically be magnitude, no? But length is more intuitive when thinking about 2D space.
I mostly agree with the rest of the thing with regard to readability and vectors. Although, thats a pretty extreme example.

Sat, Nov 17, 10:36 AM
smiley added inline comments to D1675: Remove excess argument from shift call.
Sat, Nov 17, 5:09 AM
smiley accepted D1675: Remove excess argument from shift call.

Array.prototype.shift does not take any arguments according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/shift but JavaScript being JavaScript, it wont throw an error even if one is present.
This could have been intentional by the author in an attempt to shift by n, but that would make the algorithm wrong.
Either way, it wont break anything.

Sat, Nov 17, 4:54 AM
smiley added a comment to D1675: Remove excess argument from shift call.

On an unrelated note, what would be the impact of using squared distances here. Havent looked closely, but as far as I can tell, it’s only distance to distance comparisons.

Sat, Nov 17, 4:35 AM

Fri, Nov 16

smiley added a comment to D1674: Check translations for sprintf errors.

Whats in the test plan would be very useful.

Fri, Nov 16, 5:25 PM
smiley added inline comments to D1640: ConvexPolygonPlacer optimization in rmgen..
Fri, Nov 16, 2:25 PM
smiley added inline comments to D1640: ConvexPolygonPlacer optimization in rmgen..
Fri, Nov 16, 10:52 AM
smiley added a comment to D1640: ConvexPolygonPlacer optimization in rmgen..

I am going to have to side with elexis on this one. Apart from what he has said, using a point vector instead of an x and y variable makes more sense to me.
let point = new Vector2D(10, 10);
vs.

let point_x = 10;
let point_y = 10;

Now imagine trying to manipulate it.
This of course doesn't mean that stray coordinates are bad. But they should be avoided and only used when necessary.

Fri, Nov 16, 6:19 AM

Thu, Nov 15

smiley added inline comments to D1599: [WIP] Texture priority support for rmgen.
Thu, Nov 15, 2:15 PM

Wed, Nov 14

smiley added inline comments to D1599: [WIP] Texture priority support for rmgen.
Wed, Nov 14, 11:04 AM
smiley added inline comments to D1599: [WIP] Texture priority support for rmgen.
Wed, Nov 14, 9:41 AM

Mon, Nov 12

smiley added a comment to D1362: Remove the list of hardcoded training hotkeys..

Said diff changes C++ code to allow JS to insert hotkeys, allowing removal of all fixed XML while still using the event/subscription model.)

Does sound like a better solution,

Mon, Nov 12, 4:39 PM
smiley requested review of D1362: Remove the list of hardcoded training hotkeys..
Mon, Nov 12, 2:44 PM
smiley updated the diff for D1362: Remove the list of hardcoded training hotkeys..

Remove the list of hardcodings. I assume @elexis meant D1248 about the JS loading side. Which doesn't fix the fundamental issue of keeping a hardcoded list. This maybe a little less neat, but more maintainable in the long run.
Can revert if this is too ugly.

Mon, Nov 12, 2:36 PM

Sun, Nov 11

smiley added a comment to D1673: Update NULL to nullptr.

(Same thing for static_cast as well. Maybe a ticket to correct CC should be opened.)

Sun, Nov 11, 8:24 AM
smiley added a comment to D1599: [WIP] Texture priority support for rmgen.

I forgot about writing here before, but the IDs actually do somethig else. Its an index for the textures array. It could be removed, but keeping an int for each tile is more efficient than keeping a string. Plus, there is the cost of moving them around. The code was written a *long* time ago. 2004 to be exact. Maybe, current hardware would make it redundant or something.

Sun, Nov 11, 7:22 AM

Nov 10 2018

smiley added inline comments to D1666: Have mod_ipstamp insert hostJID and remove hardcoded 0ad JIDs.
Nov 10 2018, 4:30 PM
smiley added inline comments to D1670: Remove references to globals.
Nov 10 2018, 9:47 AM
smiley added inline comments to D1670: Remove references to globals.
Nov 10 2018, 5:18 AM
smiley added a comment to D1670: Remove references to globals.

Aside from these two things, I also thought nullptr was preffered.

Nov 10 2018, 5:12 AM

Nov 6 2018

smiley added inline comments to D1664: Small LICENES.txt cleanup.
Nov 6 2018, 6:30 PM
smiley added inline comments to D1664: Small LICENES.txt cleanup.
Nov 6 2018, 5:38 PM

Nov 5 2018

smiley added a comment to rP14955: Message extraction and localization.

Seems like whether they appear in the credits is up to them. Some *.po files have just nicks or nicks with no emails and whatnot. But not sure, never used the site.

Nov 5 2018, 5:06 PM

Nov 3 2018

smiley added a comment to D1629: Don't expose lobby nick change functionality to JS.

Either that or patch ejabberd which would in all likelihood end up being something regrettable in the long run. Closest thing in ejabberd is disabling visitor nick change.

Nov 3 2018, 2:55 PM
smiley added inline comments to D1661: lobby bots systemd service.
Nov 3 2018, 2:10 PM
smiley abandoned D1629: Don't expose lobby nick change functionality to JS.

Doesn't really fix anything.

Nov 3 2018, 7:18 AM

Nov 2 2018

smiley added a comment to D1662: Define the maximum number of players pyrogenesis can handle in a match..

As mentioned in the lobby, you have to keep in mind the territory manager limitation. Posting here just for the record.
https://code.wildfiregames.com/source/0ad/browse/ps/trunk/source/simulation2/components/CCmpTerritoryManager.cpp$86
I guess that is Gaia + 31 players.

Nov 2 2018, 5:53 PM
smiley added a comment to D1662: Define the maximum number of players pyrogenesis can handle in a match..

I am a bit skeptical that the rangemanager is the only thing which needs change. There could be stray 8 or 16 s too.

Nov 2 2018, 3:24 PM
smiley added a comment to D1663: Display lobby bots differently in the lobby.

Maybe the list should be split into parts like a normal client. Moderators, bots, players, muted players.

Nov 2 2018, 5:29 AM

Nov 1 2018

smiley added a comment to D1659: Correct and complete lobby server readme.

Apart from these two things and also two point 3 being present, it rendered without anything weird in VS Code.

Nov 1 2018, 8:35 PM
smiley added inline comments to D1661: lobby bots systemd service.
Nov 1 2018, 6:57 PM
smiley updated the diff for D1642: Allow to manipulate the heightmap in simulation.

Minor cleanup + test fix.

Nov 1 2018, 5:43 PM
smiley added a comment to D1662: Define the maximum number of players pyrogenesis can handle in a match..

https://code.wildfiregames.com/source/0ad/browse/ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Player/Player.cpp$525

Nov 1 2018, 2:01 PM
smiley added inline comments to D1659: Correct and complete lobby server readme.
Nov 1 2018, 10:28 AM

Oct 31 2018

smiley added inline comments to D1659: Correct and complete lobby server readme.
Oct 31 2018, 5:46 PM
smiley added inline comments to D1659: Correct and complete lobby server readme.
Oct 31 2018, 2:11 PM
smiley added inline comments to D1660: Move Wild Lake biome specifics to a JSON file.
Oct 31 2018, 4:42 AM

Oct 30 2018

smiley added inline comments to D1659: Correct and complete lobby server readme.
Oct 30 2018, 6:18 PM
smiley added a comment to D1642: Allow to manipulate the heightmap in simulation.

Thanks for the additional review. Would resume working on this soon.

Oct 30 2018, 5:51 PM
smiley added inline comments to D1660: Move Wild Lake biome specifics to a JSON file.
Oct 30 2018, 5:50 PM
smiley created D1660: Move Wild Lake biome specifics to a JSON file.
Oct 30 2018, 5:49 PM

Oct 28 2018

smiley added a comment to D1637: BoolArray array wrapper..

Why not move this to globalscript/? There could be use cases outside rmgen (triggerscripts comes to mind)

Oct 28 2018, 10:45 AM

Oct 26 2018

smiley added inline comments to D1658: Some terms rephrasing and IP policy update.
Oct 26 2018, 2:53 PM
smiley added inline comments to D1658: Some terms rephrasing and IP policy update.
Oct 26 2018, 1:13 PM

Oct 23 2018

smiley added a comment to D1654: Build gloox with GnuTLS on macOS.
In D1654#65495, @Stan wrote:

For the record. D1617 does this :)

Oct 23 2018, 5:40 PM

Oct 21 2018

smiley added a comment to D1654: Build gloox with GnuTLS on macOS.

(Travis would help out a lot in times like these)

Oct 21 2018, 4:56 PM

Oct 20 2018

smiley added a comment to D1653: Fix building population cost being ignored while placing it.

What about not creating the entity prematurely? Would make the code more consistent and reusable.

Oct 20 2018, 8:09 AM
smiley added a comment to D1653: Fix building population cost being ignored while placing it.

Unlike a unit, the entity (foundation) is already created before placing it. So this.popUsed from player.js would include the building’s population count. This is why it makes moving it to the component a bit more complicated. It doesnt work the same way as units.

Oct 20 2018, 6:26 AM

Oct 19 2018

smiley added a comment to D1653: Fix building population cost being ignored while placing it.

Actually, no. This only affects when buildings which have a population cost is being built. Currently an unused feature in the game.

Oct 19 2018, 11:06 PM
smiley updated the diff for D1653: Fix building population cost being ignored while placing it.

Minor cleanup

Oct 19 2018, 10:31 PM
smiley added a comment to D1653: Fix building population cost being ignored while placing it.

Good catch, it should be a "populationcount - popcost".

Oct 19 2018, 9:04 PM
smiley added a comment to D1653: Fix building population cost being ignored while placing it.

I guess it still needs a notification.

Oct 19 2018, 6:53 PM
smiley retitled D1653: Fix building population cost being ignored while placing it from Fix building population cost ignored while placing it to Fix building population cost being ignored while placing it.
Oct 19 2018, 6:41 PM
smiley updated the diff for D1653: Fix building population cost being ignored while placing it.

Testing code snuck in

Oct 19 2018, 6:38 PM
smiley created D1653: Fix building population cost being ignored while placing it.
Oct 19 2018, 6:33 PM
smiley added a comment to D1652: Freehand formation position .

2 minor changes for the next update.

Oct 19 2018, 4:08 PM

Oct 18 2018

smiley added inline comments to D1650: GridBrowser GUI addon.
Oct 18 2018, 7:05 PM
smiley added inline comments to D1650: GridBrowser GUI addon.
Oct 18 2018, 8:07 AM

Oct 17 2018

smiley added a comment to D1650: GridBrowser GUI addon.

Ah, makes sense. Reminds me of the libpng segfault bug which could lead to a DoS.

Oct 17 2018, 2:13 PM
smiley added a comment to D1650: GridBrowser GUI addon.

I'm wondering if there is a second use case for this prototype or if it's only used to achieve object-oriented style over procedural style.
What are other use cases? A hero selection dialog? A relic selection dialog?

A new mod browser for mod.io, now that they have implemented a proper versioning system (https://docs.mod.io/changelog/#how-we-handle-versioning) we can use the API to the fullest without worrying about breaking changes. Including getting the description and screenshots and stuff.

Oct 17 2018, 11:25 AM
smiley added inline comments to D1650: GridBrowser GUI addon.
Oct 17 2018, 8:25 AM

Oct 16 2018

smiley added inline comments to D1609: Small changes to the macOS scripts.
Oct 16 2018, 8:30 PM

Oct 15 2018

smiley added a comment to D1590: 0 A.D. Empires Ascendant Multiplayer Lobby Privacy Policy.

Somethings found from a quick skim.

Oct 15 2018, 8:27 PM

Oct 13 2018

smiley added a comment to P136 Diff of GridBrowser + example.

(Good enough for a Revision proposal)

Oct 13 2018, 1:41 PM
smiley added a comment to P135 Generic GUI Grid Paged addon .

In the future, instead of different pages it could be one page with a scroll bar. Needs scrollbars first ofcourse.

Oct 13 2018, 8:45 AM
smiley awarded P135 Generic GUI Grid Paged addon a Love token.
Oct 13 2018, 8:41 AM

Oct 11 2018

smiley added a comment to D1646: Delete Siwa Oasis Heightmap.

(There is a scenario map called Siwa Oasis which looks entirely different. More realistic if that map is centered around that western smaller oasis.)
That one doesn’t have to be deleted ofcourse. Looks like it was handmade. Just putting it out here.

Oct 11 2018, 5:09 PM
smiley added a comment to D1646: Delete Siwa Oasis Heightmap.

https://visibleearth.nasa.gov/useterms.php
Highly likely this one is public domain, but he could have took it from a copyrighted source too.
Regarding the accuracy, we could always scrap this one and remake the real thing.

Oct 11 2018, 4:53 PM

Oct 4 2018

smiley added a comment to D1646: Delete Siwa Oasis Heightmap.
lat=29.205278; lon=25.519444; width=5;
lat1=$(bc <<< ";scale=5;$lat-$width/2"); lon1=$(bc <<< ";scale=5;$lon+$width/2"); lat2=$(bc <<< ";scale=5;$lat+$width/2"); lon2=$(bc <<< ";scale=5;$lon-$width/2")
gdal_translate -projwin $lon2 $lat2 $lon1 $lat1 gebco_08_rev_elev_C1_grey_geo.tif siwa_oasis.tif
convert siwa_oasis.tif -resize 512 -contrast-stretch 0 siwa_oasis.png

What I had used, Couldn't get something related even after tweaking a lot.

Oct 4 2018, 1:39 PM
smiley added a comment to D1646: Delete Siwa Oasis Heightmap.

Is that heightmap accurate? I could find no resemblance with that heightmap or the skirmish map to the real place.
https://www.openstreetmap.org/#map=11/29.2325/25.5408
Edited for a better more trustworthy link.

Oct 4 2018, 9:28 AM
smiley added a comment to D1646: Delete Siwa Oasis Heightmap.

I think it would be wise to be prudent about this. Better safe than sorry.
I would try to reproduce the map with a heightmap from viable sources.

Oct 4 2018, 7:54 AM

Oct 3 2018

smiley added a comment to D1645: Civ:gaia template clear-up.

(It would be cool to have a script which dumps all templates after inheriting and stuff)
(parts of templateanalyzer could be used as well, if anyone got the time and will)

Oct 3 2018, 7:23 PM
smiley requested review of D1646: Delete Siwa Oasis Heightmap.

Put it to Stan's review queue as it would be him who would make the final decisions.

Oct 3 2018, 1:41 PM