- User Since
- Mar 28 2017, 9:27 AM (200 w, 17 h)
Sun, Jan 24
I could see this being very useful in differentiating some civs. Perhaps Romans, for example, only trains soldiers in these groups. Or maybe Champions train in groups. A group can include an officer (2x health, attack aura) and a bannerman (3x health, speed and health aura).
Thu, Jan 21
To encourage team play from the beginning, we'd need a "Shared Allied Vision" option in game setup instead of moving the Shared Allied Vision tech to Village phase. Perhaps enabling the option could auto-research the tech.
Sun, Jan 17
Almost all the "current" screenshots looked more dynamic. Sorry, but true. If it's to simplify the renderer for PBR or some other kind of intensive rendering, then fine.
Uh.... too late I guess, but I found it useful to be able to tweak unit and terrain ambient separately. Ever wonder why people love the way my screenshots look? There is probably not a single map where I use the exact same ambient color for both. But.... okay. I'll adapt to fewer lighting options.
Ehhh, I think it would make sense for a Forge tech to increase armor rather than health, but that's not really the focus of this patch.
Works good in Delenda Est.
Is this DIFF now obsolete?
Part of the problem too with vision techs is that with increasing vision comes an affect on gameplay, namely the command and control the player has on his troops. Since aggression range is completely tied to vision range, when vision range increases the player's troops are more likely to automatically target more enemy entities and engage them without player input. This is why I wish the game would decouple the two things. Then vision increases wouldn't affect units in this way.
If you'd like, you can take inspiration for their look from Delenda Est:
Mon, Jan 11
Thu, Jan 7
I'd keep the 2 settlements for now. I use the smaller one on a couple maps for decor. We should probably just update them to make them nicer. I could see capturable settlements being a thing, or usable once slotting is implemented.
Tue, Dec 29
Works in-game as advertised. Thank you very much. It was one of those really annoying little bugs. It didn't affect gameplay much, but is definitely a quality of experience improvement.
Dec 25 2020
There is a bug. Sometimes the building preview shows the default angle, but when I click to place it the preview flips suddenly and the building gets built backward from what this diff intended.
This fixes it for me! I'm playtesting it now and it works as desired. Good job. I can't speak on the code though.
Dec 16 2020
I like this change from a gameplay standpoint and also from just an aesthetic standpoint. Units will always arrive in an organized way. I removed the Box formation in DE, so I edited unit_actions to make the default Line_Closed, but it all worked as advertised.
Dec 15 2020
I like this patch a lot. One problem I see is that the maps are sorted by file name instead of map name. There could be any number of reasons why these can be mismatched. Ideally it would sort by map name (taken from the map xml file).
Has this concern been made obsolete by the <PatrolWaitTime>1</PatrolWaitTime> patch that was committed?
Dec 6 2020
I would suggest the receiverTooltip text "This unit is burning" come first in the tool tip, then the data.
Dec 5 2020
I recive this warning:
needs rebased: iber_champion_cavalry -> iber/champion_cavalry
May I suggest that the effect cause half the damage, but last twice as long? So as to make the effect more likely to be noticed by the players.
I really like this. It finally implements something that's been desired for 10 years.
Nov 9 2020
This looks and works very awesome. I agree with Wraitii in that I hope that we can have it extended for Battle for Middle Earth style battalions as well (where they are trained as a battalion and cannot be disbanded; extraneous units possible, such as officers, bannermen, etc.). But as an Empires Ascendant feature, this works pretty well with the banding and disbanding. One thing I noticed in Atlas though was when I playtested it, different ranks of the same unit could not be banded together. I assume this is not intentional.
Aug 29 2020
Patch needs rebased after https://trac.wildfiregames.com/changeset/24001
The only thing I don't like about this patch is that the player name ribbon has been reduced in height, and hence the civ icon background is not visible. That was the only small bit of civ specific UI work in the whole game. Other than that, this patch works wonderfully and should be committed.
Aug 15 2020
Palisades could go into a structures/common folder, at least until palisade models can be created on a per civ basis (if ever; largely a palisade is a palisade, not much culturally happening there, so I imagine the Palisades objects being common amonfg multiple civs for quite a while longer).
Aug 2 2020
ERROR: CCmpPosition::GetPosition2D called on entity when IsInWorld is false
Aug 1 2020
If you make women build everything, even military buildings and fortresses and stuff, then you should go the DE route and change "Female Citizens" to just Citizens (male and female) using the phenotype system.
Jul 6 2020
Jun 2 2020
I agree with this change. No problem with it.
May 17 2020
I agree for the most part. I've always hated the "Persian Hall" as a buildable structure.
May 16 2020
Sounds fine to me.
Apr 4 2020
Interesting diff. What kind of gameplay feature do you envision supporting?
Mar 27 2020
Is there another differential for the Seleucid Cavalry Javelinist? It's also a Persian unit.
Feb 17 2020
Nov 25 2019
Looks good in-game. Great job.
Sep 1 2019
Anything in particular blocking this one?
Aug 31 2019
This commit was to implement a design decision made long ago to make the Uffington White Horse the Briton wonder. Any discussion here should be about technical issues.
Jun 29 2019
The selection problem is fixed, but there's a related problem I did not notice until now. When trying to task a unit to capture/attack an enemy building in the FOW:
Jun 28 2019
I don't know anything about tests, but I applied the diff and can confirm it stops the errors.
Jun 7 2019
I guess allowing modifications to add new bonuses is maybe out of scope / not doable yet?
May 5 2019
I'm not sure, but I don't think this was fixed. Units still randomly enter run mode even after the autobuild.
Apr 25 2019
Not sure if related, but I got this in the game uploading loading a map:
Mar 5 2018
I suppose you should go all the way and rename any "mauryans" folders too.
Dec 13 2017
Sep 16 2017
Hi, sorry. This is what I mean when I say "lozenge":
As for the other shapes, they may be useful in the future. Honestly, I think a selection of rectangles for mechanical units would be nice, specifically siege, perhaps lozenge shaped, rectangles with rounded corners.
Tried the patch. The healer's changed selection is nice. It works because it is a totally different class of unit from the rest, so should stand out from the rest as well. Looked good. Approved. Also, the b/a/e chevrons worked as promised after the filename change.
Aug 11 2017
This may need fixed since the last changes moved a lot of GUI files around.
Jul 23 2017
Jul 16 2017
Eh, so you're mixing the audio flavor of the civs, instead of keeping them distinct? That's what you're doing, essentially.
Jul 5 2017
Jul 3 2017
Tested it on a Cycladic Archipelago skirmish map. AI does indeed build a Shipyard. Nice.
Jun 15 2017
Jun 13 2017
delenda est, which annoyingly has a copy of the Player component for any reason
Does it need to be player color? Why not just white or gray, currently not any player color? I agree the blue line is kind of an odd choice.
Jun 6 2017
IMHO, for gather commands you should see the target briefly flash white for visual verification. Same with attack command, maybe flash white, maybe flash red? Anyway, seems like it should be a different thing from this arrow indicator.
Jun 1 2017
May 30 2017
Oh thank you. I forgot it was in globalscripts. I thought it was in the components folder and when I saw it wasn't there, I thought I had removed it. I removed the offending file and reapplied the patch.
May 29 2017
Hi, I tried these files and I don't see the Upgrade units being displayed in the Trainer bar. Is that the intention?
May 23 2017
Tested it. Works great.
I definitely like this change!
May 21 2017
May I suggest a different approach? Renaming the parent templates entirely, to be more logical?
Sorry, not sure how this would be more fun. It's micro heavy.
Apr 29 2017
Works as advertised. I cannot comment on the code itself, but the end result gives the desired functionality as requested.