Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP13541

Display current/max gatherers or builders when a resource or foundation is…
AuditedrP13541
Actions

Tags

None

Subscribers

Description

Display current/max gatherers or builders when a resource or foundation is selected. Based on a patch by mimo. Fix #1871.

Details

Auditors

Committed

Jul 8 2013, 12:13 AM

Parents

rP13540: - Round attack numbers in the GUI. Patch by scythetwirler. Fix #1997.

Branches

Unknown

Tags

Unknown

Event Timeline

peter committed rP13541: Display current/max gatherers or builders when a resource or foundation is….Jul 8 2013, 12:13 AM

Freagarach added a subscriber: Freagarach.Oct 5 2019, 10:09 PM

Freagarach added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
2074	The `this.repairTarget` will become invalid if the target transforms. Causing a repairing entity to stop when the entity transforms (e.g. a siege weapon (un)packing). A fix will be to revert this to the target in the order, or to account for this in `OnGlobalEntityRenamed`.

Freagarach raised a concern with this commit.Oct 5 2019, 10:12 PM

This commit now has outstanding concerns.Oct 5 2019, 10:12 PM

Freagarach mentioned this in D2360: Fix entities not retaining repair order after target transforms..Oct 5 2019, 11:20 PM

A tad late, but my concern was fixed by rP23449.

All concerns with this commit have now been addressed.Mar 25 2020, 8:01 AM

Changes (5)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

selection_details.js

simulation/

components/

GuiInterface.js

rP13541

ps/trunk/binaries/data/mods/public/gui/session/selection_details.js

Loading...

ps/trunk/binaries/data/mods/public/gui/session/session.xml

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/Foundation.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Loading...