Multiplayer lobby based on the XmPP protocol. Special thanks to Philip, alpha123, scythetwirler, and anyone else who has helped build, debug or test the lobby.
Description
Description
Details
Details
- Committed
JoshuaJB Nov 7 2013, 9:07 PM - Parents
- rP14097: glooxwrapper by Philip to support building gloox on Windows.
- Branches
- Unknown
- Tags
Event Timeline
/ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js | ||
---|---|---|
568 | This is messy, first the text is escaped and then GUI tags are inserted, refs D720. But it should be escapeText(text1) + highlight(escapeText(username)) + escapeText(text2), otherwise it doesn't work with nicknames that contain an escaped character. |
/ps/trunk/source/tools/XpartaMuPP/README | ||
---|---|---|
69 | This orders to the user to execute a command and in the next sentence it says the command should not be executed. I can't identify a use case for the defaults, i.e. to join the room "arena" on "lobby.wildfiregames.com" with a password "XXXXXX". The sentence can be removed without replacement in favor of the suceeding sentence. | |
83 | Using SSL version, but does not inform the user how to configure SSL/TLS (nor how to run without SSL) |
/ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js | ||
---|---|---|
591 | mostly split(" ", 1) | |
594 | But the protocol implemented is XMPP, so IRC seems terribly off to the reader, especially since most commands are well defined in that protocol such as /me, /kick: https://xmpp.org/extensions/xep-0045.html
https://xmpp.org/extensions/xep-0245.html
The only command that is implemented in this function and in IRC but not in XMPP is the /say command. |
/ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js | ||
---|---|---|
4 | The /special command and the g_specialKey are an extraordinary way to implement a boolean that should have never been written. |
/ps/trunk/source/lobby/XmppClient.cpp | ||
---|---|---|
500 | "nice" should be "translatable" |