Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP14703

Better summary screen. Fixes #686. Patch by Bajter and Kabzerek
rP14703
Actions

Tags

None

Subscribers

Description

Better summary screen. Fixes #686. Patch by Bajter and Kabzerek

Details

Committed

Jan 29 2014, 7:30 PM

Parents

rP14702: Clean up the colorfade code. Patch by boeseRaupe, fixes #2395

Branches

Unknown

Tags

Unknown

Event Timeline

sanderd17 committed rP14703: Better summary screen. Fixes #686. Patch by Bajter and Kabzerek.Jan 29 2014, 7:30 PM

Imarok mentioned this in D494: Fix economy and military score.May 14 2017, 12:43 AM

elexis added a subscriber: elexis.Oct 20 2019, 4:44 PM

elexis added inline comments.

/ps/trunk/binaries/data/mods/public/gui/session/session.js
897	The duplication and hardcoding was present before, but it would have been the right opportunity to move the template values to the template.

elexis mentioned this in D2384: Remove duplicate hardcoded StatisticsTracker unit and building classes.Oct 20 2019, 5:35 PM

elexis added inline comments.Oct 20 2019, 7:05 PM

/ps/trunk/binaries/data/mods/public/gui/summary/summary.js
214	This counts vegetarian food twice, fixed in rP19584 for the summary screen but still present in `session.js` `reportGame` in the copy introduced by rP14752.

elexis mentioned this in D2385: Refactor session lobby bot client code to use object orientation and remove duplication and hardcoding.Oct 20 2019, 7:41 PM

elexis mentioned this in rP23086: Remove hardcoding and quadruplication of the StatisticsTracker unit and….Oct 21 2019, 10:48 AM

elexis mentioned this in rP23087: Refactor session lobby bot client code to use object orientation, refs #5387..Oct 21 2019, 5:01 PM

Changes (6)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

summary/

simulation/

components/

ProductionQueue.js

StatisticsTracker.js

rP14703

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...

ps/trunk/binaries/data/mods/public/gui/summary/summary.js

Loading...

ps/trunk/binaries/data/mods/public/gui/summary/summary.xml

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/Foundation.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/ProductionQueue.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/StatisticsTracker.js

Loading...