HomeWildfire Games

Reformat the database to accept the additional summary counters as well as…

Description

Reformat the database to accept the additional summary counters as well as adding a couple summary counters. Also deletes unnecessary welcome message and deletes whitespace. Refs #686.

Details

Committed
scythetwirlerFeb 16 2014, 7:06 AM
Parents
rP14751: Stanislas69' iberian tower modification commit.
Branches
Unknown
Tags
Unknown

Event Timeline

elexis added a subscriber: elexis.Sun, Oct 20, 4:41 PM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/gui/session/session.js
977

This duplicates the score computation logic and thus comes with all problems of duplication. It means one of the copies will be developed while noone cares about the other copy.

For example rP19584 and rP20543 fixing vegetarian food being counted twice in the economy score, and adds trading to the summary score but leaves this copy untouched.

Notice that this already computes the total score logic differently as the summary screen, as rP12914 added the exploration score to the total score.

elexis added inline comments.Mon, Oct 21, 3:20 PM
/ps/trunk/binaries/data/mods/public/gui/session/session.js
977

I guess the exploration score was not added to the total count so that totalScore will be the sum of economyScore and militaryScore in the database. But if that was to be meant that way, totalScore doesn't have to be stored as a column. If the space doesn't matter and the purpose of the ratings db is that one has a copy of the GUIInterface simstate at the time the game finished, why not store exploration score as well for consistency.