Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP1540

Initial (incomplete) tooltip code
rP1540
Actions

Tags

None

Subscribers

Description

Initial (incomplete) tooltip code

Details

Committed

Dec 21 2004, 2:37 PM

Parents

rP1539: Eliminated grayscale images.

Branches

Unknown

Tags

Unknown

Event Timeline

philip committed rP1540: Initial (incomplete) tooltip code.Dec 21 2004, 2:37 PM

elexis added a subscriber: elexis.Jul 29 2019, 1:55 PM

elexis added inline comments.

/ps/trunk/source/gui/CTooltip.cpp
15	This exposes a setting to JS but misses FromJSVal ToJSVal conversion.
/ps/trunk/source/gui/GUItypes.h
101	Depends on CPos ToJSVal FromJSVal conversion.
/ps/trunk/source/gui/scripting/JSInterface_IGUIObject.cpp
137	case GUIST_CPos: ...
314	case GUIST_CPos: ...

elexis mentioned this in rP22573: Add missing CPos FromJSVal, ToJSVal following rP1540..Jul 29 2019, 1:56 PM

Can be tested by adding this in session.js init:

Engine.GetGUIObjectByName("placementTooltip").offset = new Vector2D(200, 0);

elexis mentioned this in D2214: Delete broken fallback font for broken fonts.Aug 23 2019, 5:17 AM

elexis added inline comments.Aug 27 2019, 12:44 AM

/ps/trunk/source/gui/GUITooltip.cpp
107	Since rP141, `SetSetting` sends the `GUIM_SETTINGS_UPDATED`, so this call is calling it a second time.

elexis mentioned this in rP1554: More tooltip updates. Made the main menu buttons and the in-game resource….Aug 27 2019, 1:17 AM

elexis added inline comments.

/ps/trunk/source/gui/GUITooltip.cpp
107	Finally I get why this is here. `CTooltip::SetupText()` depends on `_mousepos`. So an alternative would have been to have `CTooltip::HandleMessage` check for `_mousepos` updated.

elexis mentioned this in rP22790: Delete SGUIMessage GUIM_SETTINGS_UPDATED broadcasts redundant with the….Aug 27 2019, 1:40 AM

elexis mentioned this in D2231: Move GUIUtil SetSetting to IGUIObject.Aug 27 2019, 5:01 PM

Changes (26)

Path

Size

ps/

trunk/

binaries/

data/

mods/

official/

gui/

source/

gui/

CProgressBar.cpp

IGUITextOwner.cpp

scripting/

JSInterface_IGUIObject.cpp

JSInterface_IGUIObject.h

i18n/

StringBuffer.cpp

ps/

scripting/

rP1540

ps/trunk/binaries/data/mods/official/gui/gui.dtd

Loading...

ps/trunk/source/gui/CButton.cpp

Loading...

ps/trunk/source/gui/CCheckBox.cpp

Loading...

ps/trunk/source/gui/CGUI.cpp

Loading...

ps/trunk/source/gui/CGUI.h

Loading...

ps/trunk/source/gui/CImage.cpp

Loading...

ps/trunk/source/gui/CInput.cpp

Loading...

ps/trunk/source/gui/CProgressBar.cpp

Loading...

ps/trunk/source/gui/CText.cpp

Loading...

ps/trunk/source/gui/CTooltip.cpp

Loading...

ps/trunk/source/gui/CTooltip.h

Loading...

ps/trunk/source/gui/GUITooltip.cpp

Loading...

ps/trunk/source/gui/GUITooltip.h

Loading...

ps/trunk/source/gui/GUItext.cpp

Loading...

ps/trunk/source/gui/GUItext.h

Loading...

ps/trunk/source/gui/GUItypes.h

Loading...

ps/trunk/source/gui/GUIutil.cpp

Loading...

ps/trunk/source/gui/IGUIObject.h

Loading...

ps/trunk/source/gui/IGUITextOwner.cpp

Loading...

ps/trunk/source/gui/MiniMap.cpp

Loading...

ps/trunk/source/gui/scripting/JSInterface_IGUIObject.cpp

Loading...

ps/trunk/source/gui/scripting/JSInterface_IGUIObject.h

Loading...

ps/trunk/source/i18n/StringBuffer.cpp

Loading...

ps/trunk/source/ps/Overlay.cpp

Loading...

ps/trunk/source/ps/Overlay.h

Loading...

ps/trunk/source/scripting/ScriptGlue.cpp

Loading...