HomeWildfire Games

Fixes small memory leak introduced in r15568.

Description

Fixes small memory leak introduced in r15568.

Thanks to leper for pointing it out.

Details

Committed
YvesJul 27 2014, 1:09 AM
Parents
rP15568: Quite a lot of stack rooting related changes.
Branches
Unknown
Tags
Unknown

Event Timeline

elexis added a subscriber: elexis.EditedJul 16 2019, 3:24 PM

From 2014-07-26-QuakeNet-#0ad-dev.log:

22:36 <@leper> CMapGeneratorWorker::Run() seems to leak stuff
22:37 < Yves`> leak? memory?
22:38 <@leper> the SAFE_DELETE is only reached when all checks succeed
22:39 < Yves`> hmm yes, looks like that
22:44 < Yves`> look like I can just remove the outer scope braces and have to keep the rest
22:45 <@leper> you could change the return false to goto err or add a struct that takes a pointer and frees that in the dtor

Fix of the fix at rP15572.