HomeWildfire Games

Makes the bot more lenient on case sensitivity due to inconsistencies in case…
Concern RaisedrP15813

Description

Makes the bot more lenient on case sensitivity due to inconsistencies in case between Windows and Unix.

Details

Auditors
elexis
Committed
scythetwirlerSep 27 2014, 3:06 AM
Parents
rP15812: check ResourceGatherer interface before trying to gather, fixes #2801
Branches
Unknown
Tags
Unknown

Event Timeline

elexis raised a concern with this commit.EditedOct 28 2018, 2:45 PM
elexis added a subscriber: elexis.

This replaces wrong code with wrong code, since ilike interprets the underscore _ as a wildcard, thus breaking the rating service for some people, opening up for database attacks.

The database should store only lowercase playernames, so that players cannot modify the resource either, don't dont spam the database with many accounts if they join with an alternative XMPP client.

See D628 (also refs rP15888)

This commit now has outstanding concerns.Oct 28 2018, 2:45 PM

cc @Dunedan @user1 is this still valid?

Yes, that's still relevant. I just opened a PR with a fix for that: https://github.com/0ad/lobby-bots/pull/10