HomeWildfire Games

internationalization of ai chat messages

Description

internationalization of ai chat messages

Details

Committed
mimoOct 14 2014, 9:43 PM
Parents
rP15865: fix translation of ai chat messages (allowing for parameters)
Branches
Unknown
Tags
Unknown

Event Timeline

elexis added a subscriber: elexis.Nov 6 2019, 5:29 PM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/ai/petra/chatHelper.js
13

The translateMessage argument is not used for simulation chat (aichat) messages, chat is always translated, only guiinterface "timenotifications" have a translateMessage property.

elexis added inline comments.Nov 6 2019, 5:46 PM
/ps/trunk/binaries/data/mods/public/simulation/ai/petra/chatHelper.js
13

Concern:
The "name" should not be translated, because it has already been translated in the gamesetup as of rP14954 (chosenName = translate(chosenName);). So this actually results in translation errors (as there is no translation of a translation unless the translation is the same as the english string).

rP16533 changed it to colorize the playenrame which totally breaky the translation:

tinygettext: Couldn't translate: [color="50 170 170"]Lysander[/color]
tinygettext: Couldn't translate: [color="220 115 16"]Hampsicora[/color]
tinygettext: Couldn't translate: [color="64 64 64"]Kambyses II.[/color]

In rP17382 it was changed to not translate in multiplayer, then this line would translate without runtime errors but against the design to not translate in multiplayer.