HomeWildfire Games

Highlight all player names in the lobby chat. Patch by stanislas69, fixes #3281.
Concern RaisedrP17041

Description

Highlight all player names in the lobby chat. Patch by stanislas69, fixes #3281.

Details

Auditors
elexis
Committed
ItmsSep 19 2015, 2:15 PM
Parents
rP17040: change player color in gamesetup in random and skirmish maps, patch by elexis…
Branches
Unknown
Tags
Unknown

Event Timeline

elexis raised a concern with this commit.Jan 23 2019, 9:27 PM
elexis added a subscriber: elexis.

This should have taken word boundaries into account: #4343, #3281#comment:8.

This commit now has outstanding concerns.Jan 23 2019, 9:27 PM
Stan added a subscriber: Stan.Jan 23 2019, 11:59 PM

I guess that means I have to fix it somehow, per the guidelines, correct ?

A guideline isn't a rule, you don't have to work on it. Just formalized the defect.

Stan added a comment.Jan 24 2019, 8:45 AM

The function you submitted seemed good but as you said on another diff there might be broken edge cases we need to check for. I was wondering why we don't just check if the word is surrounded by spaces or punctuation ?

Thanks for the answer