HomeWildfire Games

Cinematic camera core functionality. Patch by Vladislav Belov.
AuditedrP17594

Description

Cinematic camera core functionality. Patch by Vladislav Belov.
Based on existing code that was still around from an old(not working) implementation.
Supports basic control from trigger scirpts (queue, start and stop camera paths) and works in multiplayer.

Details

Auditors
elexis
Committed
YvesJan 3 2016, 1:41 PM
Parents
rP17593: Code style cleanups for CinemaPath in preparation for the cinematic camera…
Branches
Unknown
Tags
Unknown

Event Timeline

elexis raised a concern with this commit.Jan 17 2017, 6:09 PM
elexis added a subscriber: elexis.

Causes a hash mismatch in non-visual replay mode.

(Most recent cleanup patch laying the road to fixing this should be reviewed at #3814)

elexis added a comment.Apr 5 2017, 6:04 AM

D271 fixed the hash mismatch.

But there is still an actual OOS on rejoin because the started path isn't continued upon rejoin and thus the map revelation won't be reset for that client.

elexis accepted this commit.Apr 10 2017, 7:44 PM

Should be fixed now by D271 / rP19375 and D299 / rP19382 respectively. In case I find something else, be sure the concern will be raised again ;-) Thanks a lot for these fixes!!

All concerns with this commit have now been addressed.Apr 10 2017, 7:44 PM