HomeWildfire Games

Update the idle-worker-button onSimulationUpdate. Patch by svott, fixes #3736.

Description

Update the idle-worker-button onSimulationUpdate. Patch by svott, fixes #3736.

Details

Committed
elexisJan 19 2016, 5:04 PM
Parents
rP17673: Deep freeze simulation commands to prevent accidental updates. Fixes #3647.
Branches
Unknown
Tags
Unknown

Event Timeline

lyv added a subscriber: lyv.Dec 11 2018, 7:23 AM
lyv added inline comments.
/ps/trunk/binaries/data/mods/public/gui/session/session.js
87

This is pretty prone to errors and oversights in maintenance on the long run. In fact, it is already missing a class for the Mauryan Elephant worker. Maybe, the best course of action would be to have a Worker class.

Silier added a subscriber: Silier.Dec 11 2018, 9:18 AM
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/gui/session/session.js
87

Certain units are already marked with class Worker in VisibleClasses.

Silier added inline comments.Dec 11 2018, 9:23 AM
/ps/trunk/binaries/data/mods/public/gui/session/session.js
87

I forgot to mention, Petra is using it in headquarters.js line 337

elexis added a subscriber: elexis.Dec 11 2018, 1:42 PM
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/gui/session/session.js
87

Introduced by rP9349 / #209, modified by rP9791, rP9349, rP9791, rP10146, rP10194, rP11211, rP11958, rP14580, rP15388, rP16654, rP17674, ....

Notice that this defines classes, not templates with the Worker class.

lyv added inline comments.Dec 11 2018, 1:50 PM
/ps/trunk/binaries/data/mods/public/gui/session/session.js
87

It had "Worker" class before. And then it was removed. Not unexpected as none (or few) of the worker unit's template has the class defined.