HomeWildfire Games

Implement buttons for up to 10 heroes. Patch by Clockwork-Muse, fixes #3000.
Concern RaisedrP18361

Description

Implement buttons for up to 10 heroes. Patch by Clockwork-Muse, fixes #3000.

Details

Auditors
leper
Committed
elexisJun 11 2016, 3:46 PM
Parents
rP18360: Fixes a bug introduced in r18312 that prevents entity placement on some…
Branches
Unknown
Tags
Unknown

Event Timeline

leper raised a concern with this commit.Sep 5 2017, 3:09 AM
leper added a subscriber: leper.

When many entities are shown (but 10 entites at minimal supported resolution suffice), the buttons overlap the civ icon (which opens the structure tree). If one tries to focus one of the icons, overlapping it, then one doesn't get the tooltip as expected, but the civ icon is highlighted, which results in the buttongs only partially overlapping the civ icon.

Either the number of buttons should be reduced so that the civ icon isn't overlapped (true, that many entities are unlikely and I only found that issue on the unit demo map, but if we support that many we should do it properly), or there should be some offset so that there is no overlap and the buttons are below that. Actually one could do some sort of double row thing so that there is no overlap.

This commit now has outstanding concerns.Sep 5 2017, 3:09 AM
elexis added a subscriber: elexis.Sep 5 2017, 11:12 AM

civ icon

Noticed that issue in D814 too.
The same overlap issue occurs for the gamespeed dropdown.
Changing the Z index of the dropdown causes messed up transparency as described in D148.

number of buttons reduced

Seeing 8 heroes in observermode will be common next alpha.
12 relics can already be seen in a22 in observermode if the host set lunatic gamesettings.

offset / double row

Sounds ugly as there would be a lot of unused space in between

The correct but painful fix would be to set the Z order IMO.
I expect all buttons to become accessible if the civ icon and gamespeed dropdown are shown above it.