HomeWildfire Games

Always save the replay metadata (summary screen info) when ending the…

Description

Always save the replay metadata (summary screen info) when ending the application. Patch by Imarok, fixes #4020.

Details

Committed
elexisAug 17 2016, 5:17 PM
Parents
rP18612: Fixes off-by-one error.
Branches
Unknown
Tags
Unknown

Event Timeline

elexis added a subscriber: elexis.Aug 22 2019, 5:16 PM
elexis added inline comments.
/ps/trunk/source/ps/GameSetup/GameSetup.cpp
707

This condition is a mess, not only because it's complex hardcoded logic, but also because it duplicates the logic when to store a replay, which should rather be obtained from the original source (CGame constructor arguments, existence of a ReplayLogger).
If rP17054 had introduced the SaveReplayMetadata function to the ReplayLogger, this line wouldn't have made an appearance, but that's what one learns years later after studying the files more. -> D2211, D2197