HomeWildfire Games
Diffusion 0 A.D. Public Repository rP18977

Remove silencing of resource-not-found errors (that were introduced with an…
AuditedrP18977
Actions

Description

Remove silencing of resource-not-found errors (that were introduced with an enabled property in the JSON resource files that got removed later). Refs #3934.

Details

Auditors
Polakrity
Committed
elexisNov 21 2016, 6:32 PM
Parents
rP18976: Disable all unusable structures on survival of the fittest, refs #3102.
Branches
Unknown
Tags
Unknown

Event Timeline

elexis committed rP18977: Remove silencing of resource-not-found errors (that were introduced with an….Nov 21 2016, 6:32 PM
elexis mentioned this in D23: Correct resource order in the GUI.Jun 9 2017, 4:23 PM
elexis mentioned this in D625: Resource name translation cleanup.Jun 11 2017, 1:48 AM
Polakrity raised a concern with this commit.May 25 2019, 4:49 AM
Polakrity added a subscriber: Polakrity.

Templates.js
resources parameter in GetTemplateDataHelper() became unused in the function.

Probably, the actual damageTypes parameter can be also removed with 4801

This commit now has outstanding concerns.May 25 2019, 4:49 AM
elexis mentioned this in rP22527: Easier introduction of new damage types..Sep 3 2019, 11:16 AM
elexis requested verification of this commit.Sep 3 2019, 11:42 AM

Thank you for the report @Polakrity!

This commit now requires verification by auditors.Sep 3 2019, 11:42 AM
elexis mentioned this in rP22836: Remove two GetTemplateDataHelper unused arguments following rP18977 and rP22527….Sep 3 2019, 11:43 AM
Polakrity accepted this commit.Sep 17 2019, 12:11 PM

It looks good to me.
All calls to this function with unused arguments have been removed.

All concerns with this commit have now been addressed.Sep 17 2019, 12:11 PM

Changes (9)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
globalscripts/
simulation/
ai/
petra/
components/

rP18977

View Options

ps/trunk/binaries/data/mods/public/globalscripts/Templates.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/researchManager.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/Cost.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/Player.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/ProductionQueue.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/ResourceDropsite.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/ResourceSupply.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/ResourceTrickle.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/StatisticsTracker.js

Loading...
Wildfire Games · Phabricator