HomeWildfire Games
Diffusion 0 A.D. Public Repository rP18979

Colorize selected units in observermode, reviewed by elexis, fixes #4167
AuditedrP18979
Actions

Description

Colorize selected units in observermode, reviewed by elexis, fixes #4167

Details

Auditors
elexis
Committed
ImarokNov 21 2016, 10:35 PM
Parents
rP18978: move the diminishing returns computation from the ResourceGatherer to the…
Branches
Unknown
Tags
Unknown

Event Timeline

Imarok committed rP18979: Colorize selected units in observermode, reviewed by elexis, fixes #4167.Nov 21 2016, 10:35 PM
elexis raised a concern with this commit.Jan 16 2017, 5:22 PM
elexis added a subscriber: elexis.

Broke rallypoints on huntable animals, #4425

Imarok mentioned this in D123: Properly sort selected entities by owner.Feb 3 2017, 11:14 PM
Imarok mentioned this in rP19202: Properly sort selected entities by owner.Feb 6 2017, 11:18 PM
Imarok requested verification of this commit.Feb 6 2017, 11:23 PM

Fixed by rP19202

This commit now requires verification by auditors.Feb 6 2017, 11:23 PM
elexis accepted this commit.Feb 9 2017, 8:41 PM

Didn't test, but I assume mimo did when he reviewed the fix

All concerns with this commit have now been addressed.Feb 9 2017, 8:41 PM

Changes (5)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
session/
selection_panels_middle/
simulation/
components/

rP18979

View Options

ps/trunk/binaries/data/mods/public/gui/session/input.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/selection.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_panels_middle/multiple_details_area.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

Loading...
Wildfire Games · Phabricator