Remove team bonus when the source player is defeated. Reviewed by wraitii.
Differential Revision: https://code.wildfiregames.com/D12
Description
Description
Details
Details
- Auditors
• leper elexis - Committed
fatherbushido Jan 1 2017, 6:23 PM - Differential Revision
- D12: Removes team bonus when the source player is defeated.
- Parents
- rP19092: Don't use range queries for global auras. Fix related team bonus. Add Mauryan…
- Branches
- Unknown
- Tags
- Build Status
Buildable 91 Build 147: Post-Commit Build Jenkins
Event Timeline
Comment Actions
Thanks (sorry for that)!
Edit: (Well, I should have add the new diff here instead of commiting directly. Adressed in r19094.)
Comment Actions
Hard to notice in inline diffs here, guess I'll have to look at plain/raw diffs again...
No clue how to handle that, I'm also not quite sure how to handle you fixing that, but I'll just link to rP19094 (r19094 doesn't work here it seems) and hope it works (in addition to accepting this commit; which is strange given that I can't link to a reason for doing so)
Comment Actions
(fixes incoming)
/ps/trunk/binaries/data/mods/public/simulation/components/Auras.js | ||
---|---|---|
97 | The defeated player still receives team bonuses. | |
431 | This cleans the aura of every entity globally instead of only working on player entities, as pointed out by fatherbushido in the according ticket #5099. (The defeat message shouldn't be broadcasted to begin with by the looks of things however.) |
/ps/trunk/binaries/data/mods/public/simulation/components/Auras.js | ||
---|---|---|
97 | That wasn't really a leftover of this commit. |
/ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Auras.js | ||
---|---|---|
131 | testAuras("global", (name, cmpAuras) => { could have been better |
/ps/trunk/binaries/data/mods/public/simulation/components/Auras.js | ||
---|---|---|
97 | Which use case could apply to applying auras to defeated players? | |
/ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Auras.js | ||
131 | To be continued at D1430. |
/ps/trunk/binaries/data/mods/public/simulation/components/Auras.js | ||
---|---|---|
97 | Remark was mainly about gaia. |
/ps/trunk/binaries/data/mods/public/simulation/components/Auras.js | ||
---|---|---|
97 | It said "Remove team bonus when the source player is defeated", so I commented it here as to me it looks like this commit should have therefore introduced a defeated check in this line. But blame is not so important as getting it fixed. Do you agree that I can add the defeated condition here? |
/ps/trunk/binaries/data/mods/public/simulation/components/Auras.js | ||
---|---|---|
97 | I still don't see the link with that commit ('source' vs 'target'). I have not to agree with anything right now. But removing defeated player when recomputing affected players seems probably wanted and probably an optimization. Though it's hardly noticeable. (All target entities but player entities should already have been caught somewhere when changing ownership to gaia, so the only remaining case is when the player entity is the target. Example : resource counter of a defeated player which continue to increase). I didn't/don't know what is done for techs. |
/ps/trunk/binaries/data/mods/public/simulation/components/Auras.js | ||
---|---|---|
97 | Which is noticeable to players in the summary graphs or when changing the perspective in observermode. |