HomeWildfire Games
Diffusion 0 A.D. Public Repository rP19202

Properly sort selected entities by owner
AuditedrP19202
Actions

Description

Properly sort selected entities by owner

Fixes #4425. Refs #1807, #4167. Fixes rP18979

Reviewed by: mimo

Differential Revision: https://code.wildfiregames.com/D123

Details

Auditors
elexis
Group Auditors
Restricted Owners Package
Provenance
ImarokAuthored on
Reviewer
mimo
Differential Revision
D123: Properly sort selected entities by owner
Parents
rP19201: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 465
Build 753: Post-Commit BuildJenkins

Event Timeline

Imarok committed rP19202: Properly sort selected entities by owner.Feb 6 2017, 11:17 PM
Imarok mentioned this in rP18979: Colorize selected units in observermode, reviewed by elexis, fixes #4167.Feb 6 2017, 11:23 PM
Harbormaster completed building B465: rP19202: Properly sort selected entities by owner.Feb 7 2017, 12:04 AM
elexis raised a concern with this commit.Feb 9 2017, 11:50 AM
elexis added a subscriber: elexis.

Doesn't extend tests but breaks them

This commit now has outstanding concerns.Feb 9 2017, 11:50 AM
elexis accepted this commit.Feb 9 2017, 4:56 PM
In null, @elexis wrote:

Doesn't extend tests but breaks them

Sorry, the tests (from D90) were not committed yet and survived the revert

All concerns with this commit have now been addressed.Feb 9 2017, 4:56 PM

Changes (7)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
session/
simulation/
components/
helpers/

rP19202

View Options

ps/trunk/binaries/data/mods/public/gui/session/input.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/selection.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/GarrisonHolder.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/Commands.js

Loading...
Wildfire Games ยท Phabricator