HomeWildfire Games

Implement clientside kick/ban support for the lobby.
AuditedrP19250

Description

Implement clientside kick/ban support for the lobby.
Displays a chat notification for all lobby clients if a client is kicked or banned, pop up a message box for the affected one, including the kick reason.
Clean the player- and gamelist upon disconnect and disable the control elements.

Reviewed By: Imarok
Differential Revision: https://code.wildfiregames.com/D116

Details

Auditors
Imarok
Committed
elexisFeb 28 2017, 12:16 PM
Reviewer
Imarok
Differential Revision
D116: Clientside Lobby Kick support
Parents
rP19249: Focus camera on the spy after bribing it.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 630
Build 1001: Post-Commit BuildJenkins

Event Timeline

Imarok raised a concern with this commit.Jul 29 2017, 10:38 AM
Imarok added a subscriber: Imarok.
Imarok added inline comments.
/ps/trunk/source/lobby/XmppClient.cpp
814

Typo? When enabling xmpp debug(L42), flags is undefined.

This commit now has outstanding concerns.Jul 29 2017, 10:38 AM
elexis requested verification of this commit.Jul 31 2017, 6:34 PM

Thanks for the report!
rP19941

This commit now requires verification by auditors.Jul 31 2017, 6:34 PM
Imarok accepted this commit.Jul 31 2017, 6:53 PM
All concerns with this commit have now been addressed.Jul 31 2017, 6:53 PM
elexis added inline comments.Nov 16 2019, 1:30 PM
/ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js
168

I don't see why this was inserted as this code path is not triggered for kicking.
It might make sense to disconnect because there is no room rejoin other than reconnecting upon disconnecting, but not sure how this code path could be triggered other than maybe the room getting destroyed. (Kicking and joining the lobby with a second intsance doesn't seem to trigger it.)

Perhaps its a leftover from a previous version of the patch where there hadn't been a distinction between kick and leave yet in XmppClient.