HomeWildfire Games

Polar Sea random map script.
AuditedrP19254

Description

Polar Sea random map script.

Based on map by Hannibal Baraq.
Differential Revision: https://code.wildfiregames.com/D156
Map generation reviewed by FeXoR
Trigger Script and UnitAI change reviewed by Sandarac
Environment settings reviewed by niektb and wowgetoffyourcellphone

Details

Auditors
Sandarac
Committed
elexisFeb 28 2017, 9:53 PM
Differential Revision
D156: Polar Sea Random Map
Parents
rP19253: AddSpy should always return something
Branches
Unknown
Tags
Unknown
Build Status
Buildable 635
Build 1007: Post-Commit BuildJenkins

Event Timeline

Sandarac raised a concern with this commit.Mar 1 2017, 6:31 AM
Sandarac added a subscriber: Sandarac.

I am sorry - the UnitAI changes were poorly reviewed. I will try to address the issues (In particular, Order.Patrol shouldn't have been modified).

This commit now has outstanding concerns.Mar 1 2017, 6:31 AM
mimo raised a concern with this commit.Mar 1 2017, 7:45 PM
mimo added a subscriber: mimo.

When testing this map, we get debug messages which should be removed
Spawned 3 gaia/fauna_wolf_snow at 35 points
Spawned 2 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points
Spawned 3 gaia/fauna_wolf_snow at 35 points
Spawned 3 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points
Spawned 2 gaia/fauna_wolf_snow at 35 points
Spawned 2 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points
Spawned 3 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points

elexis added a comment.Mar 1 2017, 7:48 PM
In rP19254#19723, @mimo wrote:

When testing this map, we get debug messages which should be removed
Spawned 3 gaia/fauna_wolf_snow at 35 points
Spawned 2 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points
Spawned 3 gaia/fauna_wolf_snow at 35 points
Spawned 3 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points
Spawned 2 gaia/fauna_wolf_snow at 35 points
Spawned 2 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points
Spawned 3 gaia/fauna_wolf_snow at 35 points
Spawned 1 gaia/fauna_wolf_snow at 35 points

It was intentionally added as it helps with debugging the number of attackers. Same proposed in D145

mimo added a comment.Mar 1 2017, 7:56 PM

Usually when i debug some code, i add my own printouts and don't want them to be hidden among other printouts i really don't care. Why don't you add them when doing your own test, or at least comment them and uncomment when needed?

elexis added a comment.Mar 1 2017, 7:59 PM
In rP19254#19727, @mimo wrote:

Usually when i debug some code, i add my own printouts and don't want them to be hidden among other printouts i really don't care. Why don't you add them when doing your own test, or at least comment them and uncomment when needed?

For survival I've already added them removed, added them again, removed again. As adding commented out code is frowned upon and as the attack-wave balancing will always be relevant, adding a boolean that is false by default would cover all use cases

elexis requested verification of this commit.Mar 23 2017, 12:52 AM

ping @mimo @Sandarac
UnitAI changes reverted for now in rP19323 / D176
Logging disabled by default in rP19263 / D184

This commit now requires verification by auditors.Mar 23 2017, 12:52 AM
Sandarac accepted this commit.Mar 23 2017, 2:52 AM
elexis removed an auditor: mimo.Apr 26 2017, 6:14 PM

Since logging was disabled as requested in rP19263

All concerns with this commit have now been addressed.Apr 26 2017, 6:14 PM