HomeWildfire Games

Add sortable columns to the loading screen and a compatibility filter for saved…

Description

Add sortable columns to the loading screen and a compatibility filter for saved games.

Replace the unexplained orange and red colorization and replace it with the greyout equal to the replay menu,
as the difference between compatibility types is explained when trying to load the game.
Rename the ambiguous generateLabel to generateSavegameLabel.

Patch By: Vladislav
Differential Revision: https://code.wildfiregames.com/D246

Details

Committed
elexisMar 27 2017, 2:55 PM
Differential Revision
D392: Fixed lost selection in the load game page
Parents
rP19350: Unit tests for JS Pack component
Branches
Unknown
Tags
Unknown
Build Status
Buildable 913
Build 1436: Post-Commit BuildJenkins

Event Timeline

mimo raised a concern with this commit.Apr 28 2017, 10:23 PM
mimo added a subscriber: mimo.

When deleting a saved game which is neither the first nor the last, the selection is lost, which is annoying when we want to delete several files consecutively.

/ps/trunk/binaries/data/mods/public/gui/savedgames/load.js
92

When we delete a game which is neither the first nor the last, this returns -1

This commit now has outstanding concerns.Apr 28 2017, 10:23 PM
vladislavbelov added inline comments.
/ps/trunk/binaries/data/mods/public/gui/savedgames/load.js
92

Do you know why it happens? Because it was working.

/ps/trunk/binaries/data/mods/public/gui/savedgames/load.js
92

Stop, it's ok, it shouldn't select something.

/ps/trunk/binaries/data/mods/public/gui/savedgames/load.js
92

Selection should be saved only if a selected item still exists. So select first if nothing found, it's an additional feature.

mimo added inline comments.Apr 28 2017, 11:59 PM
/ps/trunk/binaries/data/mods/public/gui/savedgames/load.js
92

No the previous behaviour (before that patch) was to select the following one, and that was exactly what was expected: allowing to delete several consecutive files easily while now you have to always reselect.

/ps/trunk/binaries/data/mods/public/gui/savedgames/load.js
92

Ok, I fixed it in D392.

elexis requested verification of this commit.May 1 2017, 8:00 AM
This commit now requires verification by auditors.May 1 2017, 8:00 AM
elexis removed an auditor: mimo.May 16 2017, 3:10 PM

@mimo correct me if I'm wrong by raising a concern, this commit should be accepted now following rP19471

This commit no longer requires audit.May 16 2017, 3:10 PM