HomeWildfire Games
Diffusion 0 A.D. Public Repository rP19356

Petra: Initial Capture The Relic support
AuditedrP19356
Actions

Description

Petra: Initial Capture The Relic support
Patch by Sandarac
Differential Revision: https://code.wildfiregames.com/D236

Details

Auditors
Sandarac
Committed
mimoMar 28 2017, 8:51 PM
Differential Revision
D236: Petra: Initial Capture The Relic support
Parents
rP19355: Replace many deprecated randInt calls with randBool.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 926
Build 1457: Post-Commit BuildJenkins

Event Timeline

mimo committed rP19356: Petra: Initial Capture The Relic support.Mar 28 2017, 8:51 PM
Harbormaster completed building B926: rP19356: Petra: Initial Capture The Relic support.Mar 28 2017, 9:38 PM
Sandarac mentioned this in D283: Better relic error handling for edge cases.Apr 5 2017, 3:38 AM
Sandarac raised a concern with this commit.
This commit now has outstanding concerns.Apr 5 2017, 3:39 AM
Sandarac added a subscriber: Sandarac.Apr 5 2017, 3:40 AM
Sandarac added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/ai/petra/gameTypeManager.js
272

I'm sorry, this should be this.criticalEnts.delete(criticalEntId);

elexis added a subscriber: elexis.Apr 5 2017, 6:06 AM

(As reported in https://code.wildfiregames.com/D283#11469)

elexis added a comment.Apr 7 2017, 7:19 PM

Thanks for the report and the fix! I have reproduced the issue with rP19380 and could confirm the bug and the fix

commands.txt68 KBDownload

elexis mentioned this in rP19381: Fix copy & past error in the initial petra AI relic support of rP19356..Apr 7 2017, 7:23 PM
Sandarac accepted this commit.Apr 8 2017, 5:40 AM

Thanks!

All concerns with this commit have now been addressed.Apr 8 2017, 5:40 AM

Changes (3)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
ai/
petra/

rP19356

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/attackManager.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/attackPlan.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/gameTypeManager.js

Loading...
Wildfire Games ยท Phabricator