HomeWildfire Games

Move multiplayer host and join page to a new directory, as it is not related…
AuditedrP19380

Description

Move multiplayer host and join page to a new directory, as it is not related nor doesn't share anything with the gamesetup.

Differential Revision: https://code.wildfiregames.com/D298
Reviewed By: wraitii

Event Timeline

s0600204 raised a concern with this commit.Aug 31 2018, 8:12 PM
s0600204 added a subscriber: s0600204.

Due to the move to a differently named folder, the strings marked for translation contained within gamesetup_mp.{js|xml} are no longer being picked up for translation.

mods/public/l10n/message.json should be updated.

(Attribution for discovery should go to Requin on the forums (link))

This commit now has outstanding concerns.Aug 31 2018, 8:12 PM
elexis requested verification of this commit.Fri, Dec 28, 2:36 PM

Should be fixed by rP21960, refs #5155, thanks for the report and fix!

This commit now requires verification by auditors.Fri, Dec 28, 2:36 PM
s0600204 accepted this commit.Thu, Jan 10, 6:02 PM
All concerns with this commit have now been addressed.Thu, Jan 10, 6:02 PM