Diffusion 0 A.D. Public Repository rP19408

Fix CChart scaling edgecases (constant value and infinity)
rP19408
Actions

Description

Fix CChart scaling edgecases (constant value and infinity)

Reviewed by: vladislavbelov
Differential Revision: https://code.wildfiregames.com/D167

Details

Auditors

• leper

Committed

Imarok

Apr 11 2017, 2:27 PM

Reviewer

vladislavbelov

Differential Revision

D167: Fix CChart scaling edgecases

Parents

rP19407: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 1092
Build 1721: Trigger Windows Autobuild
Build 1720: Post-Commit Build	Jenkins

Event Timeline

Imarok committed rP19408: Fix CChart scaling edgecases (constant value and infinity).Apr 11 2017, 2:27 PM

Harbormaster completed building B1092: rP19408: Fix CChart scaling edgecases (constant value and infinity).Apr 11 2017, 3:13 PM

• leper raised a concern with this commit.Nov 25 2017, 4:05 AM

• leper added a subscriber: • leper.

• leper added inline comments.

/ps/trunk/source/gui/CChart.cpp
124	See https://github.com/0ad/0ad/commit/c2647d6e853f6e7f14ccc2d4b14e73f0fab40d3c#diff-046d62b1f156cd63a5d67320b254805b.

This commit now has outstanding concerns.Nov 25 2017, 4:05 AM

See #4722

Ah, hadn't noticed that one.

This commit no longer requires audit.Nov 25 2017, 4:15 AM

(It was just for reference, don't disagree with getting Imarok to fix it ;) )

Imarok mentioned this in D1072: Fix oversight in rP19408.Nov 26 2017, 4:47 PM

Imarok mentioned this in rP20544: Fix oversight in rP19408 noticed by Geramoto.Nov 27 2017, 8:51 PM

Changes (2)

Path

Size

ps/

trunk/

source/

gui/

CChart.cpp

CChart.h

rP19408

View Options

ps/trunk/source/gui/CChart.cpp