List, add and delete cinematic paths in Atlas.
Doesn't provide a way to add/delete nodes of paths yet.
Differential Revision: https://code.wildfiregames.com/D348
Patch By: Vladislav
List, add and delete cinematic paths in Atlas.
Description
Details
Event TimelineComment Actions This commit introduced the use of wxString::ToStdWstring which was introduced in wxWidgets 3. This effectively breaks compatibility with wxWidgets 2.8. ? We could of course look into dropping 2.8, but it would make much more sense to change this and convert this string the same way we convert all other strings, in a legacy fashion.
Comment Actions Since we have no strict rules about wxWidget (https://trac.wildfiregames.com/wiki/BuildInstructions?action=history), it's not the issue. Comment Actions
Not explicitly recommending old versions (2.8) is not the same thing as silently breaking support for it. Comment Actions Because I don't want to look a the dependencies for each OS each time, when I'm writing a code. So we fix the lib version or/and we fix how we use the lib. Comment Actions Per distro commands/hints are user provided, outdated, and should be taken with about an ocean of salt. But trying to remove those just results in people adding them back or crying about how reading and figuring out what packages are needed is hard. That said if someone wants to improve the commands, it is a wiki. Comment Actions Well by writing code that uses wxWidgets, you are responsible for breaking changes like this one, so you should ideally take a look at the dependencies... But if you miss something, that's not a big deal: someone else will notice during review or through an Audit ? @leper: To settle the wiki page issue, would it be OK to write
? Comment Actions
I don't think the https://trac.wildfiregames.com/wiki/BuildInstructions page should be concerned with what the code should do (staying compatible). We might want to add a comment about (at least wxWidgets version X.Y.Z) to https://trac.wildfiregames.com/wiki/BuildInstructions#Dependencies, which we might want to unify for *nix (or *nix without OS X, or macOS, or Mac OS X, or the operating system formerly known as NeXTSTEP). That said I'd add some warnings about those specific install commands most likely being outdated and that people should look at that dependency list instead. (Or just remove those commands and tell users to RTFM.) |