Fix the aiming code when performing an attack. Reviewed by wraitii.
Differential Revision: https://code.wildfiregames.com/D20
Description
Description
Details
Details
- Auditors
vladislavbelov - Committed
fatherbushido Apr 19 2017, 9:39 AM - Differential Revision
- D20: Fix the aiming code when performing an attack.
- Parents
- rP19431: Make random map Caledonian Meadows circular and some style changes. Reviewed by…
- Branches
- Unknown
- Tags
- Build Status
Buildable 1188 Build 1879: Post-Commit Build Jenkins
Event Timeline
/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js | ||
---|---|---|
583 | It should be let disc = b * b - 4 * a * c;. |
/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js | ||
---|---|---|
583 | it should not, see math in https://code.wildfiregames.com/D2940?id=13712#inline-61855 |
/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js | ||
---|---|---|
583 | The math seems correct from the first sight. The naming is the problem then, since it's not just a discriminant. But that's the less problem. So it's not the raise then, but it'd be good to fix. |