HomeWildfire Games

Fix the aiming code when performing an attack. Reviewed by wraitii.

Description

Fix the aiming code when performing an attack. Reviewed by wraitii.
Differential Revision: https://code.wildfiregames.com/D20

Event Timeline

vladislavbelov raised a concern with this commit.Nov 4 2020, 7:38 PM
vladislavbelov added a subscriber: vladislavbelov.
vladislavbelov added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js
583

It should be let disc = b * b - 4 * a * c;.

This commit now has outstanding concerns.Nov 4 2020, 7:38 PM
Silier added a subscriber: Silier.Nov 4 2020, 10:08 PM
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js
583
vladislavbelov resigned from this commit.Nov 4 2020, 10:26 PM
vladislavbelov added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js
583

The math seems correct from the first sight. The naming is the problem then, since it's not just a discriminant. But that's the less problem. So it's not the raise then, but it'd be good to fix.

This commit no longer requires audit.Nov 4 2020, 10:26 PM