HomeWildfire Games

Commit Detail
AuditedrP19444

Description

Event Timeline

Replace input.js doubleclick hack and ease doubleclicking on moving units.

Differential Revision: https://code.wildfiregames.com/D326
Patch By: causative
Refs #4414

minohaka raised a concern with this commit.Apr 23 2017, 4:37 AM
minohaka added a subscriber: minohaka.

Hey guys, I'm not sure if this is the right place, but in this revision (19444) file
gui/session/input.js line: 863 is failing when trying to select individual units or structures, click an drag for selecting works correctly double clicking or single click doesn't work

This commit now has outstanding concerns.Apr 23 2017, 4:37 AM

Hey guys, I'm not sure if this is the right place, but in this revision (19444) file
gui/session/input.js line: 863 is failing when trying to select individual units or structures, click an drag for selecting works correctly double clicking or single click doesn't work

Did you compile or use the most recent, outdated exe file?

Hey guys, I'm not sure if this is the right place, but in this revision (19444) file
gui/session/input.js line: 863 is failing when trying to select individual units or structures, click an drag for selecting works correctly double clicking or single click doesn't work

Did you compile or use the most recent, outdated exe file?

I use whatever comes down when I update from SVN. I've been testing the game for while every time there are changes I test. I went to the IRC channel and then came over here. I'm glad this is the right place. I didn't compile it the source gonna try to do that now

elexis added a comment.EditedApr 23 2017, 4:47 AM

Hey guys, I'm not sure if this is the right place, but in this revision (19444) file
gui/session/input.js line: 863 is failing when trying to select individual units or structures, click an drag for selecting works correctly double clicking or single click doesn't work

Did you compile or use the most recent, outdated exe file?

I use whatever comes down when I update from SVN. I've been testing the game for while every time there are changes I test. I went to the IRC channel and then came over here. I'm glad this is the right place. I didn't compile it the source gonna try to do that now

If you're using the old .exe file, then this will certainly be the cause of the error and might want to wait some days until we have fixed our build systems and committed the new one to svn.

Make sure to accept the commit once you can confirm that it works

Hey guys, I'm not sure if this is the right place, but in this revision (19444) file
gui/session/input.js line: 863 is failing when trying to select individual units or structures, click an drag for selecting works correctly double clicking or single click doesn't work

Did you compile or use the most recent, outdated exe file?

I use whatever comes down when I update from SVN. I've been testing the game for while every time there are changes I test. I went to the IRC channel and then came over here. I'm glad this is the right place. I didn't compile it the source gonna try to do that now

If you're using the old .exe file, then this will certainly be the cause of the error and might want to wait some days until we have fixed our build systems and committed the new one to svn.
Make sure to accept the commit once you can confirm that it works

Sure thing setting up the environment right now, I'll compile and test. Thanks man you guys rock!

Hey guys, I'm not sure if this is the right place, but in this revision (19444) file
gui/session/input.js line: 863 is failing when trying to select individual units or structures, click an drag for selecting works correctly double clicking or single click doesn't work

Did you compile or use the most recent, outdated exe file?

I use whatever comes down when I update from SVN. I've been testing the game for while every time there are changes I test. I went to the IRC channel and then came over here. I'm glad this is the right place. I didn't compile it the source gonna try to do that now

If you're using the old .exe file, then this will certainly be the cause of the error and might want to wait some days until we have fixed our build systems and committed the new one to svn.
Make sure to accept the commit once you can confirm that it works

Sure thing setting up the environment right now, I'll compile and test. Thanks man you guys rock!

Do I need Visual Studio 2013 specifically? I'm on the latest version (2017) and the build fails on it

Do I need Visual Studio 2013 specifically?

Yes. https://trac.wildfiregames.com/wiki/BuildInstructions#Windows

I have noticed no issues with this commit (after compiling of course).

minohaka accepted this commit.Apr 23 2017, 6:50 AM

Finally compiled latest version of and it works correctly, thanks

All concerns with this commit have now been addressed.Apr 23 2017, 6:50 AM