HomeWildfire Games

Use the slider for the number of shader graphics setting.

Description

Use the slider for the number of shader graphics setting.
Thereby remove the only hardcoded reference of options.json from options.js.
Rename Gain to Volume, refs #4039.

Differential Revision: https://code.wildfiregames.com/D398
Reviewed By: Vladislav

Event Timeline

Sandarac raised a concern with this commit.May 1 2017, 12:14 AM
Sandarac added a subscriber: Sandarac.

If the slider position is modified and the config menu is closed without saving any changes, the slider will not update properly when the menu is opened again (the slider will not take into account the actual saved config value).

Also, values like materialmgr.quality = "4.0268473625183105" will appear in user.cfg; I'm not sure if such messy, unrounded values are to be expected.

This commit now has outstanding concerns.May 1 2017, 12:14 AM
elexis added a comment.EditedMay 1 2017, 12:21 AM

Seems like the wrong commit, since both applies to the volume equally

If the slider position is modified and the config menu is closed without saving any changes, the slider will not update properly when the menu is opened again (the slider will not take into account the actual saved config value).

Closing the dialog without saving = keeping the current settings (contrary to the revert button)

Also, values like materialmgr.quality = "4.0268473625183105" will appear in user.cfg; I'm not sure if such messy, unrounded values are to be expected.

A granularity option was requested in #4039 #2593 and mentioned in https://code.wildfiregames.com/D398#16499.
The purpose of this commit was mostly to make options.js agnostic of options.json and to allow the values in between.

elexis requested verification of this commit.May 1 2017, 12:27 AM
This commit now requires verification by auditors.May 1 2017, 12:27 AM

We all want the granularity patch to be finished, but I don't think that this commit needs to be in the list of active audits.

This commit no longer requires audit.Oct 12 2017, 3:51 PM