Clientside Lobby support for muted players (visitor role).
rP19514
Actions

Description

Clientside Lobby support for muted players (visitor role).
Displays a chat message and a notification in the player details to everyone if someone was muted and
hides the chat input to visitors.

Differential Revision: https://code.wildfiregames.com/D339
Reviewed By: user1

Details

Committed

elexis

May 5 2017, 3:13 AM

Reviewer

user1

Differential Revision

D339: Clientside lobby visitor role support (muting clients)

Parents

rP19513: petra: remove some unneeded parentheses

Branches

Unknown

Tags

Unknown

Build Status

Buildable 1458
Build 2307: Trigger Windows Autobuild
Build 2306: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP19514: Clientside Lobby support for muted players (visitor role)..May 5 2017, 3:13 AM

Harbormaster completed building B1458: rP19514: Clientside Lobby support for muted players (visitor role)..May 5 2017, 4:30 AM

elexis mentioned this in rP19634: Fix a warning when clicking on offline players in the leaderboard following….May 22 2017, 4:42 AM

elexis added a subscriber: user1.Nov 26 2017, 7:12 PM

elexis added inline comments.

/ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js
189	@user1 has reported that sometimes we get the `%(nick)s is not a moderator anymore` string when someone was unmuted after returning from a game. The reason must be that this `role` variable is not set at the time when the message is received but at the time of displaying it (which can be hours later after several role changes). It is easy to solve by extending the `CreateMessage` call in `XmppClient.cpp` to also send that role.