HomeWildfire Games
Diffusion 0 A.D. Public Repository rP19569

Make phase technology researchable in all captured civic center. Reviewed by…
rP19569
Actions

Description

Make phase technology researchable in all captured civic center. Reviewed by elexis. Fix #4572.

Details

Committed
fatherbushidoMay 13 2017, 3:58 PM
Parents
rP19568: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 1696
Build 2682: Post-Commit BuildJenkins

Event Timeline

fatherbushido committed rP19569: Make phase technology researchable in all captured civic center. Reviewed by….May 13 2017, 3:58 PM
mimo raised a concern with this commit.May 13 2017, 4:57 PM
mimo added a subscriber: mimo.

Was this tested with athen in AI? this can not work without changes in the init function of common-api/gamestate.js

This commit now has outstanding concerns.May 13 2017, 4:57 PM
Harbormaster completed building B1696: rP19569: Make phase technology researchable in all captured civic center. Reviewed by….May 13 2017, 5:00 PM
fatherbushido added a comment.May 13 2017, 5:00 PM
In rP19569#21022, @mimo wrote:

Was this tested with athen in AI? this can not work without changes in the init function of common-api/gamestate.js

Oups. Sorry for that.

fatherbushido added a comment.EditedMay 13 2017, 7:32 PM

Ok it is indeed not working for the AI with athen.
Well, I see different way to fix it, but I don't know which one is the best.

  • splitting that phase tech. On one side it's fine for testing the replace thing but it's also annoying as it's a crucial tech.
  • using some hardcoding, anyway it's a bit hardcoded.
  • doing a bit more work in the for loop

(or revert that :p)

mimo mentioned this in D491: AI should support phase technologies of different civs / Adress concern in rP19569.May 14 2017, 11:36 AM
s0600204 mentioned this in D500: Test for phase techs' tech requirements in Structure Tree.May 14 2017, 10:06 PM
elexis accepted this commit.Jul 9 2017, 1:52 AM
elexis removed an auditor: mimo.
elexis added a subscriber: elexis.

Fixed by rP19578 / D491 and D500 / rP19585

This commit no longer requires audit.Jul 9 2017, 1:52 AM

Changes (3)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
templates/
structures/

rP19569

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/athen_civil_centre.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_civil_centre.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_civil_centre_military_colony.xml

Loading...
Wildfire Games · Phabricator