Diffusion 0 A.D. Public Repository rP19599

New economic tutorial based on triggers, accessible from the "learn to play"…
AuditedrP19599
Actions

Tags

None

Subscribers

Tokens

"Love" token, awarded by Itms.

Description

New economic tutorial based on triggers, accessible from the "learn to play" button

Reviewed By: elexis

Differential Revision: https://code.wildfiregames.com/D194

Details

Auditors

Committed

mimo	May 17 2017, 7:33 PM

Reviewer

Differential Revision

D194: New tutorial based on triggers.

Parents

rP19598: petra captureRelics cleanup following rP19596

Branches

Unknown

Tags

Unknown

Build Status

Buildable 1781
Build 2822: Trigger Windows Autobuild
Build 2821: Post-Commit Build	Jenkins

Event Timeline

mimo committed rP19599: New economic tutorial based on triggers, accessible from the "learn to play"….May 17 2017, 7:33 PM

Harbormaster completed building B1781: rP19599: New economic tutorial based on triggers, accessible from the "learn to play"….May 17 2017, 8:57 PM

I love the tutorial ? Thanks for putting effort in that!

I only have one remark, the warnings don't always seem to fit. Especially the one I'm pointing does not fit and is unreadable ? It should be an easy fix.

/ps/trunk/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js
52	This one

This commit now has outstanding concerns.May 18 2017, 11:23 PM

Itms awarded a token.May 18 2017, 11:23 PM

mimo mentioned this in D520: fixes to the economic tutorial (D194) following rP19599.May 19 2017, 6:48 PM

mimo mentioned this in rP19628: fixes to the economic tutorial (D194) following rP19599.May 21 2017, 6:42 PM

mimo mentioned this in D602: tutorials not translated.Jun 4 2017, 12:15 PM

(I forgot to close this audit)

All concerns with this commit have now been addressed.Jun 4 2017, 1:37 PM

It was proposed to use shorter instructions: https://wildfiregames.com/forum/index.php?/topic/15271-0-ad-on-youtube/&page=52#comment-335581

Perhaps fonts and colors could also be used to make it easier to distinguish the explanations from the instructions.

In rP19599#22498, @elexis wrote:

It was proposed to use shorter instructions: https://wildfiregames.com/forum/index.php?/topic/15271-0-ad-on-youtube/&page=52#comment-335581

Perhaps fonts and colors could also be used to make it easier to distinguish the explanations from the instructions.

1.) There really should be shorter instructions, most people rather close tutorial because of long text.
2.) Long instructions are more annoying for readers, and readers can miss something important in such long text.

elexis mentioned this in D755: Fix typos in the tutorial.Aug 9 2017, 1:49 PM

elexis mentioned this in D2483: Gamesetup class rewrite.Dec 18 2019, 5:49 PM

elexis added inline comments.Jan 10 2020, 8:33 PM

/ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js
1752	The map should not be hardcoded by the gamesetup, but passed by the caller, this way allowing this autostart mechanism to be reused. (Equally the function name shouldn't restrict the maptype). Fixed in D2483.

elexis mentioned this in rP23374: Gamesetup class rewrite, fixes #5322, refs #5387..Jan 11 2020, 9:14 PM

Langbart mentioned this in D4314: Double click tutorial bug.Oct 20 2021, 9:26 PM

Changes (12)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

common/

gamesetup/

pregame/

session/

tutorial_panel.xml

l10n/

maps/

scripts/

tutorials/

starting_economy_walkthrough.js

starting_economy_walkthrough.xml

simulation/

components/

source/

simulation2/

scripting/

MessageTypeConversions.cpp

rP19599

ps/trunk/binaries/data/mods/public/gui/common/styles.xml

Loading...

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js

Loading...

ps/trunk/binaries/data/mods/public/gui/pregame/mainmenu.xml

Loading...

ps/trunk/binaries/data/mods/public/gui/session/messages.js

Loading...

ps/trunk/binaries/data/mods/public/gui/session/session.xml

Loading...

ps/trunk/binaries/data/mods/public/gui/session/tutorial_panel.xml

Loading...

ps/trunk/binaries/data/mods/public/l10n/messages.json

Loading...

ps/trunk/binaries/data/mods/public/maps/scripts/Tutorial.js

Loading...

ps/trunk/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.js

Loading...

ps/trunk/binaries/data/mods/public/maps/tutorials/starting_economy_walkthrough.xml

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/Trigger.js

Loading...

ps/trunk/source/simulation2/scripting/MessageTypeConversions.cpp

Loading...