Diffusion 0 A.D. Public Repository rP19624

Try to recognise unknown hotkey mappings using SDL2.
rP19624
Actions

Description

Try to recognise unknown hotkey mappings using SDL2.
This improves our international keyboard until we completely rework the hotkey system which seems to be quite legacy at this point.

Reviewed by Itms.
Differential Revision: https://code.wildfiregames.com/D303

Details

Committed

wraitii

May 21 2017, 10:05 AM

Differential Revision

D303: Try to recognise unknown hotkey mappings using SDL2

Parents

rP19623: Fix an oversight in rP19615.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 1848
Build 2924: Trigger Windows Autobuild
Build 2923: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP19624: Try to recognise unknown hotkey mappings using SDL2..May 21 2017, 10:05 AM

Harbormaster completed building B1848: rP19624: Try to recognise unknown hotkey mappings using SDL2..May 21 2017, 2:52 PM

This improves our international keyboard until we completely rework the hotkey system which seems to be quite legacy at this point.

I'm not sure what you consider lacking in our hotkey system (apart from nobody having implemented a way to set hotkeys in the gui), but I guess just wanting to rewrite everything that isn't broken is just what you do.

I'm not sure what you consider lacking in our hotkey system (apart from nobody having implemented a way to set hotkeys in the gui),

Well that for one thing, also the fact that pretty much all the code to handle specific key mappings is useless since we can safely use SDL_GetKeyFromName anywhere. That's like 40% of the code.

Edit: and well unitMotion is broken, so I don't see what you mean.

wraitii mentioned this in rP24215: Let players remap hotkeys in-game, fix default hotkeys being qwerty-specific..Nov 19 2020, 10:28 AM