HomeWildfire Games

Allow to show capture, resource and health bar at the same time. (needed for…

Description

Allow to show capture, resource and health bar at the same time. (needed for D450)

Reviewed by: elexis
Differential Revision: https://code.wildfiregames.com/D516

Details

Committed
ImarokMay 27 2017, 10:38 PM
Reviewer
elexis
Differential Revision
D516: Allow to show capture, resource and health bar
Parents
rP19674: Fix replay menu loading time by using a cache file
Branches
Unknown
Tags
Unknown
Build Status
Buildable 2012
Build 3235: Post-Commit BuildJenkins

Event Timeline

While using the Observer Perspective, i experienced thi issue:
the player 2 structures capture point status bar color doesn't match with the player color ( they are diplayed green like hp bar).
I don't pay attention during the game but after something went on in game, new built structures only correctly displayed capture bar. Using Player 2 perspective, the bars appear correctly as intended.
here is a screenshot.

Grugnas raised a concern with this commit.Sep 13 2017, 1:19 PM
This commit now has outstanding concerns.Sep 13 2017, 1:19 PM

While using the Observer Perspective, i experienced thi issue:
the player 2 structures capture point status bar color doesn't match with the player color ( they are diplayed green like hp bar).
I don't pay attention during the game but after something went on in game, new built structures only correctly displayed capture bar. Using Player 2 perspective, the bars appear correctly as intended.
here is a screenshot.

Could you reproduce it?
Are you sure it's because of that commit?
And why?

elexis added a subscriber: elexis.May 8 2018, 11:01 PM

Reported at #5154 most likely the same bug: mirages

elexis removed an auditor: Grugnas.May 8 2018, 11:09 PM

I don't think this commit introduced the bug seen above and reported in the ticket, because the status bars of mirages should not be displayed if the mirages are not displayed.

This commit no longer requires audit.May 8 2018, 11:09 PM