Add random map Wild Lake. Patch by FeXoR. Reviewed by elexis and Imarok.
Differential Revision: https://code.wildfiregames.com/D548
This mixes actor and non-actor entities, but actor entities can be placed on the 3 tiles at the map border whereas non-actor entities may not be placed there, leading to either unreachable trees and other code complaining about unreachable entities or the 3 border tiles not being placed on the map border.
The solution is to either split this into two arrays each or detecting if the handled entity is an actor.
(It's not clear what HS means. Looking at the code reveals a slope difference. Perhaps the SlopeConstraint could be used for consistency. Also it would be less fragmented if the height intervals are contained in this object too, for example like pyrennean sierra. It is just a HeightConstraint, so these two constraints might ormight not be combined here.)
"[...] or detecting if the handled entity is an actor."
(So rather open a ticket than raising a concern about an old commit would IMO be the way to go so we can talk about that in terms of line numbers or make use of Phabricator's inline comments ;) )
The line where the check could happen should contain: if (actor)
HS stands for "High Slope".
So your proposal would make this 14 times slower, need 7 more lines where nothing is set ... so I'm not for it ;p
Also the distance to gaia in nomad mode must be increased, otherwise spawnkill. Actually it's probably better to not place gaia in nomad mode at all, as the placeable map area might be too few if the distance is increased, or if just a player runs into a gaia group.