Fix hero selection rings becoming unsaturated when moving. Patch by Sandarac, refs r16274, #2627.
Differential Revision: https://code.wildfiregames.com/D563
Fix hero selection rings becoming unsaturated when moving. Patch by Sandarac…
Description
Details
Event TimelineComment Actions InvalidateStaticOverlay(); is not called anymore if (!m_AlwaysVisible) and there is no reason provided in D563. * This must be called after changing anything that will affect the * return value of GetPosition2D() or GetRotation().Y: * - m_InWorld * - m_X, m_Z * - m_RotY In ICmpSelectable.h we have this comment: /// A more complex textured line overlay, composed of several textured line segments. Intended for entities that do not /// move often, such as buildings (structures). STATIC_OUTLINE, Adding the InvalidateStaticOverlay() call isn't causing any performance issues as it only SAFE_DELETEs a member. If it's not a static overlay, this will always be null. If it is a static overlay, it must be called.
|