HomeWildfire Games
Diffusion 0 A.D. Public Repository rP20046

JS Cleanup.
rP20046
Actions

Description

JS Cleanup.

Don't change the Upgrade costs in the entity state when displaying the Upgrade tooltip.

Refs #2706, D829

Details

Committed
elexisAug 26 2017, 9:34 PM
Parents
rP20045: JS cleanup.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 2912
Build 5008: Post-Commit BuildJenkins

Event Timeline

elexis committed rP20046: JS Cleanup..Aug 26 2017, 9:34 PM
Harbormaster completed building B2912: rP20046: JS Cleanup..Aug 27 2017, 10:38 PM
bb added a subscriber: bb.Sep 14 2020, 9:00 PM
bb added inline comments.
/ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js
1116

Don't understand the need for this change. I do understand passing data.unitEntStates.length in the old function. But this returns an array instead of a string and does not include the translated header

1121

and if not existing, it will say ![]==true and thus give a newline

bb mentioned this in D3008: Correct cost tooltip for upgrades.Sep 14 2020, 9:01 PM
bb added inline comments.Sep 14 2020, 11:38 PM
/ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js
1116

Header was added later in rP21310

bb mentioned this in rP24437: Display header from rP21310 also for upgrades..Dec 22 2020, 11:27 PM

Changes (1)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
session/

rP20046

View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js

Loading...
Wildfire Games ยท Phabricator